diff mbox

[U-Boot,RFC,05/10] ARM: SPL: do not set gd again

Message ID 1401568344-4441-6-git-send-email-jeroen@myspectrum.nl
State RFC
Delegated to: Tom Rini
Headers show

Commit Message

Jeroen Hofstee May 31, 2014, 8:32 p.m. UTC 
---
 arch/arm/lib/spl.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Simon Glass June 3, 2014, 2:07 a.m. UTC | #1 
On 31 May 2014 14:32, Jeroen Hofstee <jeroen@myspectrum.nl> wrote:
> ---
>  arch/arm/lib/spl.c | 3 ---
>  1 file changed, 3 deletions(-)

Needs commit message/signoff, but this seems to be throughout the
series. Apart from that:

Acked-by: Simon Gass <sjg@chromium.org>


>
> diff --git a/arch/arm/lib/spl.c b/arch/arm/lib/spl.c
> index dfcc596..75ab546 100644
> --- a/arch/arm/lib/spl.c
> +++ b/arch/arm/lib/spl.c
> @@ -28,9 +28,6 @@ void __weak board_init_f(ulong dummy)
>         /* Clear the BSS. */
>         memset(__bss_start, 0, __bss_end - __bss_start);
>
> -       /* Set global data pointer. */
> -       gd = &gdata;
> -
>         board_init_r(NULL, 0);
>  }
>
> --
> 1.8.3.2
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
Tim Harvey June 3, 2014, 3:38 p.m. UTC | #2 
On Sat, May 31, 2014 at 1:32 PM, Jeroen Hofstee <jeroen@myspectrum.nl> wrote:
> ---
>  arch/arm/lib/spl.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/arch/arm/lib/spl.c b/arch/arm/lib/spl.c
> index dfcc596..75ab546 100644
> --- a/arch/arm/lib/spl.c
> +++ b/arch/arm/lib/spl.c
> @@ -28,9 +28,6 @@ void __weak board_init_f(ulong dummy)
>         /* Clear the BSS. */
>         memset(__bss_start, 0, __bss_end - __bss_start);
>
> -       /* Set global data pointer. */
> -       gd = &gdata;
> -
>         board_init_r(NULL, 0);
>  }
>

Agree with Simon's comment

otherwise

Acked-by: Tim Harvey <tharvey@gateworks.com>
diff mbox

Patch

diff --git a/arch/arm/lib/spl.c b/arch/arm/lib/spl.c
index dfcc596..75ab546 100644
--- a/arch/arm/lib/spl.c
+++ b/arch/arm/lib/spl.c
@@ -28,9 +28,6 @@  void __weak board_init_f(ulong dummy)
 	/* Clear the BSS. */
 	memset(__bss_start, 0, __bss_end - __bss_start);
 
-	/* Set global data pointer. */
-	gd = &gdata;
-
 	board_init_r(NULL, 0);
 }