diff mbox

[U-Boot,v6,4/4] Config: Exynos5: Enable Generic GPIO and CMD configs

Message ID 1397295812-4010-5-git-send-email-Akshay.s@samsung.com
State Changes Requested
Delegated to: Minkyu Kang
Headers show

Commit Message

Akshay Saraswat April 12, 2014, 9:43 a.m. UTC
From: Rajeshwari Shinde <rajeshwari.s@samsung.com>

Enable configs for GPIO CMD and Generic GPIO.

Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
Signed-off-by: Akshay Saraswat <akshay.s@samsung.com>
---
 include/configs/exynos5-dt.h | 3 +++
 1 file changed, 3 insertions(+)

Comments

Simon Glass April 12, 2014, 8:33 p.m. UTC | #1
On 12 April 2014 02:43, Akshay Saraswat <akshay.s@samsung.com> wrote:

> From: Rajeshwari Shinde <rajeshwari.s@samsung.com>
>
> Enable configs for GPIO CMD and Generic GPIO.
>
> Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
> Signed-off-by: Akshay Saraswat <akshay.s@samsung.com>
>

Acked-by: Simon Glass <sjg@chromium.org>

Tested on snow with backlight GPIOs.



> ---
>  include/configs/exynos5-dt.h | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/include/configs/exynos5-dt.h b/include/configs/exynos5-dt.h
> index 414db42..e81b5cd 100644
> --- a/include/configs/exynos5-dt.h
> +++ b/include/configs/exynos5-dt.h
> @@ -288,4 +288,7 @@
>
>  #define CONFIG_CMD_BOOTZ
>
> +#define HAVE_GENERIC_GPIO
>

Will someone be implementing this for other Samsung SoCs?

Regards,
Simon
Simon Glass April 12, 2014, 8:39 p.m. UTC | #2
Hi Akshay,

On 12 April 2014 13:33, Simon Glass <sjg@chromium.org> wrote:

> On 12 April 2014 02:43, Akshay Saraswat <akshay.s@samsung.com> wrote:
>
>> From: Rajeshwari Shinde <rajeshwari.s@samsung.com>
>>
>> Enable configs for GPIO CMD and Generic GPIO.
>>
>> Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
>> Signed-off-by: Akshay Saraswat <akshay.s@samsung.com>
>>
>
> Acked-by: Simon Glass <sjg@chromium.org>
>
> Tested on snow with backlight GPIOs.
>

One more question - it looks like Pit doesn't boot on ToT. It is missing a
device tree file, but it seems to be more than that - have you had it
working?

Regards,
Simon
diff mbox

Patch

diff --git a/include/configs/exynos5-dt.h b/include/configs/exynos5-dt.h
index 414db42..e81b5cd 100644
--- a/include/configs/exynos5-dt.h
+++ b/include/configs/exynos5-dt.h
@@ -288,4 +288,7 @@ 
 
 #define CONFIG_CMD_BOOTZ
 
+#define HAVE_GENERIC_GPIO
+#define CONFIG_CMD_GPIO
+
 #endif	/* __CONFIG_H */