From patchwork Fri Apr 11 05:55:20 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaehoon Chung X-Patchwork-Id: 338363 X-Patchwork-Delegate: panto@antoniou-consulting.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id B0A3A1400D2 for ; Fri, 11 Apr 2014 15:57:47 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 3A15B4B6F5; Fri, 11 Apr 2014 07:57:03 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6hr290CRs4nD; Fri, 11 Apr 2014 07:57:03 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 6253F4B6F6; Fri, 11 Apr 2014 07:56:00 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 8B07D4B610 for ; Fri, 11 Apr 2014 07:55:51 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sSxptwUrwHAT for ; Fri, 11 Apr 2014 07:55:48 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mailout2.samsung.com (mailout2.samsung.com [203.254.224.25]) by theia.denx.de (Postfix) with ESMTPS id 7DEA14B6AF for ; Fri, 11 Apr 2014 07:55:39 +0200 (CEST) Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N3U0058AR4I6C30@mailout2.samsung.com> for u-boot@lists.denx.de; Fri, 11 Apr 2014 14:55:30 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [172.20.52.115]) by epcpsbgr1.samsung.com (EPCPMTA) with SMTP id CA.6A.12635.2D387435; Fri, 11 Apr 2014 14:55:30 +0900 (KST) X-AuditID: cbfee68d-b7fcd6d00000315b-77-534783d21a88 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 00.83.28157.2D387435; Fri, 11 Apr 2014 14:55:30 +0900 (KST) Received: from localhost.localdomain ([10.252.81.186]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0N3U001PJR4FUM80@mmp2.samsung.com>; Fri, 11 Apr 2014 14:55:30 +0900 (KST) From: Jaehoon Chung To: u-boot@lists.denx.de Date: Fri, 11 Apr 2014 14:55:20 +0900 Message-id: <1397195727-29969-7-git-send-email-jh80.chung@samsung.com> X-Mailer: git-send-email 1.7.9.5 In-reply-to: <1397195727-29969-1-git-send-email-jh80.chung@samsung.com> References: <1397195727-29969-1-git-send-email-jh80.chung@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrHLMWRmVeSWpSXmKPExsWyRsSkWPdSs3uwwctmE4sbv9pYLdYvX8Nu 0bL2AKvF272d7A4sHvM2NrF5nL2zg9Gjb8sqxgDmKC6blNSczLLUIn27BK6MJQtnsBf8dqlY dXUfawPjH7MuRk4OCQETiTXdLUwQtpjEhXvr2boYuTiEBJYySjw68JgVpujRiTNMEInpjBJH u26xQjhtTBLfnx5kB6liE9CR2P7tONgoEQEJiV/9VxlBipgFJgKN+r0crEhYwFuibXETG4jN IqAqsfcchM0r4CZx9/ZboAYOoHUKEnMm2YCEOQXcJX61/2AHCQsBlXzaCXaEhMBvNomuVxtZ IMYISHybfIgFolVWYtMBZoijJSUOrrjBMoFReAEjwypG0dSC5ILipPQiQ73ixNzi0rx0veT8 3E2MwLA9/e9Z7w7G2wesDzEmA42byCwlmpwPDPu8knhDYzMjC1MTU2Mjc0sz0oSVxHmTHiYF CQmkJ5akZqemFqQWxReV5qQWH2Jk4uCUamDclPsibN35RRyJjJyLIzic33bOfth+t3/F/Lx4 8YD4g5e8+efPbJxuuVW46Kse02TLrJctnZulKzgmajy8M9m1tulSvqGmoYJv9gHO2RfOlF4T 43xzwqNYo6sy9H72osi8Px/EpnIrXn507XDrdeXSjdtT3D98PrX2zB3ddN9Pr2dvaIlIL45S YinOSDTUYi4qTgQAn3Np9nECAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrNIsWRmVeSWpSXmKPExsVy+t9jQd1Lze7BBrsnaFnc+NXGarF++Rp2 i5a1B1gt3u7tZHdg8Zi3sYnN4+ydHYwefVtWMQYwRzUw2mSkJqakFimk5iXnp2TmpdsqeQfH O8ebmhkY6hpaWpgrKeQl5qbaKrn4BOi6ZeYA7VNSKEvMKQUKBSQWFyvp22GaEBripmsB0xih 6xsSBNdjZIAGEtYwZixZOIO94LdLxaqr+1gbGP+YdTFyckgImEg8OnGGCcIWk7hwbz1bFyMX h5DAdEaJo123WCGcNiaJ708PsoNUsQnoSGz/dhysQ0RAQuJX/1VGkCJmgYmMEo9+LwcrEhbw lmhb3MQGYrMIqErsPQdh8wq4Sdy9/RaogQNonYLEnEk2IGFOAXeJX+0/2EHCQkAln3YyTWDk XcDIsIpRNLUguaA4KT3XSK84Mbe4NC9dLzk/dxMjOCqeSe9gXNVgcYhRgINRiYf3wCW3YCHW xLLiytxDjBIczEoivGb+7sFCvCmJlVWpRfnxRaU5qcWHGJOBbprILCWanA+M2LySeENjEzMj SyNzQwsjY3PShJXEeQ+2WgcKCaQnlqRmp6YWpBbBbGHi4JRqYHRbFdTJ8TjLPL156+r4q8ZH 90SkZ4bd1zUyWXJl97+6jdt+Sdh4r7q7+DDPhNXnJjZ6z5PkKjV8x/N9peDLD/2X3QJ+OnyY 9SH/2CaG158YQlk2bT+xZUsMe39siFLwdIY/np/2NMw/9uGksj1PgkRtop5ji9vcID4O2Z4V jeUl8y9MctHqcFRiKc5INNRiLipOBAB/2LoMzgIAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Cc: Jaehoon Chung , Pantelis Antoniou , Rajeshawari Shinde Subject: [U-Boot] [PATCHv3 06/13] mmc: exynos_dw_mmc: restore the property into host X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.11 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de Restore the platdata(property of dt) into host struct. Then data's information is maintained and reused anywhere. Signed-off-by: Jaehoon Chung Tested-by: Lukasz Majewski Acked-by: Lukasz Majewski --- drivers/mmc/exynos_dw_mmc.c | 208 +++++++++++++++++++++++++++---------------- include/dwmmc.h | 2 + 2 files changed, 132 insertions(+), 78 deletions(-) diff --git a/drivers/mmc/exynos_dw_mmc.c b/drivers/mmc/exynos_dw_mmc.c index e9d00e7..131ff72 100644 --- a/drivers/mmc/exynos_dw_mmc.c +++ b/drivers/mmc/exynos_dw_mmc.c @@ -14,6 +14,7 @@ #include #include #include +#include #define DWMMC_MAX_CH_NUM 4 #define DWMMC_MAX_FREQ 52000000 @@ -45,6 +46,13 @@ unsigned int exynos_dwmci_get_clk(struct dwmci_host *host) & DWMCI_DIVRATIO_MASK) + 1; sclk = get_mmc_clk(host->dev_index); + /* + * Assume to know divider value. + * When clock unit is broken, need to set "host->div" + */ + if (host->div) + sclk /= (host->div + 1); + return sclk / clk_div; } @@ -61,26 +69,17 @@ static void exynos_dwmci_board_init(struct dwmci_host *host) } } -/* - * This function adds the mmc channel to be registered with mmc core. - * index - mmc channel number. - * regbase - register base address of mmc channel specified in 'index'. - * bus_width - operating bus width of mmc channel specified in 'index'. - * clksel - value to be written into CLKSEL register in case of FDT. - * NULL in case od non-FDT. - */ -int exynos_dwmci_add_port(int index, u32 regbase, int bus_width, u32 clksel) +static int exynos_dwmci_core_init(struct dwmci_host *host, int index) { - struct dwmci_host *host = NULL; unsigned int div; unsigned long freq, sclk; - host = malloc(sizeof(struct dwmci_host)); - if (!host) { - printf("dwmci_host malloc fail!\n"); - return 1; - } + + if (host->bus_hz) + freq = host->bus_hz; + else + freq = DWMMC_MAX_FREQ; + /* request mmc clock vlaue of 52MHz. */ - freq = 52000000; sclk = get_mmc_clk(index); /* @@ -94,19 +93,15 @@ int exynos_dwmci_add_port(int index, u32 regbase, int bus_width, u32 clksel) set_mmc_clk(index, div); host->name = "EXYNOS DWMMC"; - host->ioaddr = (void *)regbase; - host->buswidth = bus_width; #ifdef CONFIG_EXYNOS5420 host->quirks = DWMCI_QUIRK_DISABLE_SMU; #endif host->board_init = exynos_dwmci_board_init; - if (clksel) { - host->clksel_val = clksel; - } else { - if (0 == index) + if (!host->clksel_val) { + if (index == 0) host->clksel_val = DWMMC_MMC0_CLKSEL_VAL; - if (2 == index) + if (index == 2) host->clksel_val = DWMMC_MMC2_CLKSEL_VAL; } @@ -121,77 +116,134 @@ int exynos_dwmci_add_port(int index, u32 regbase, int bus_width, u32 clksel) return 0; } +/* + * This function adds the mmc channel to be registered with mmc core. + * index - mmc channel number. + * regbase - register base address of mmc channel specified in 'index'. + * bus_width - operating bus width of mmc channel specified in 'index'. + * clksel - value to be written into CLKSEL register in case of FDT. + * NULL in case od non-FDT. + */ +int exynos_dwmci_add_port(int index, u32 regbase, int bus_width, u32 clksel) +{ + struct dwmci_host *host = NULL; + + host = malloc(sizeof(struct dwmci_host)); + if (!host) { + error("dwmci_host malloc fail!\n"); + return -ENOMEM; + } + + host->ioaddr = (void *)regbase; + host->buswidth = bus_width; + + if (clksel) + host->clksel_val = clksel; + + return exynos_dwmci_core_init(host, index); +} + #ifdef CONFIG_OF_CONTROL -int exynos_dwmmc_init(const void *blob) +struct dwmci_host dwmci_host[DWMMC_MAX_CH_NUM]; + +static int do_dwmci_init(struct dwmci_host *host) { - int index, bus_width; - int node_list[DWMMC_MAX_CH_NUM]; - int err = 0, dev_id, flag, count, i, compat_id; - u32 clksel_val, base, timing[3]; + int index, flag = 0, err = 0; - compat_id = COMPAT_SAMSUNG_EXYNOS_DWMMC; + index = host->dev_index; - count = fdtdec_find_aliases_for_id(blob, "mmc", - compat_id, node_list, DWMMC_MAX_CH_NUM); + flag = host->buswidth == 8 ? PINMUX_FLAG_8BIT_MODE : PINMUX_FLAG_NONE; + err = exynos_pinmux_config(host->dev_id, flag); + if (err) { + debug("DWMMC not configure\n"); + return err; + } - for (i = 0; i < count; i++) { - int node = node_list[i]; - struct fdt_gpio_state pwr_gpio; + return exynos_dwmci_core_init(host, index); +} - if (node <= 0) - continue; +static int exynos_dwmci_get_config(const void *blob, int node, + struct dwmci_host *host) +{ + int err = 0; + u32 base, clksel_val, timing[3]; - /* Extract device id for each mmc channel */ - dev_id = pinmux_decode_periph_id(blob, node); + /* Extract device id for each mmc channel */ + host->dev_id = pinmux_decode_periph_id(blob, node); - /* Get the bus width from the device node */ - bus_width = fdtdec_get_int(blob, node, "samsung,bus-width", 0); - if (bus_width <= 0) { - debug("DWMMC: Can't get bus-width\n"); - return -1; - } - if (8 == bus_width) - flag = PINMUX_FLAG_8BIT_MODE; - else - flag = PINMUX_FLAG_NONE; + /* Get the bus width from the device node */ + host->buswidth = fdtdec_get_int(blob, node, "samsung,bus-width", 0); + if (host->buswidth <= 0) { + debug("DWMMC: Can't get bus-width\n"); + return -EINVAL; + } - fdtdec_decode_gpio(blob, node, "pwr-gpios", &pwr_gpio); - if (fdt_gpio_isvalid(&pwr_gpio)) - gpio_direction_output(pwr_gpio.gpio, 1); + host->dev_index = fdtdec_get_int(blob, node, "index", host->dev_id); + if (host->dev_index == host->dev_id) + host->dev_index = host->dev_id - PERIPH_ID_SDMMC0; - /* config pinmux for each mmc channel */ - err = exynos_pinmux_config(dev_id, flag); - if (err) { - debug("DWMMC not configured\n"); - return err; - } + /* Set the base address from the device node */ + base = fdtdec_get_addr(blob, node, "reg"); + if (!base) { + debug("DWMMC: Can't get base address\n"); + return -EINVAL; + } + host->ioaddr = (void *)base; - index = fdtdec_get_int(blob, node, "index", dev_id); - if (index == dev_id) - index = dev_id - PERIPH_ID_SDMMC0; + /* Extract the timing info from the node */ + err = fdtdec_get_int_array(blob, node, "samsung,timing", timing, 3); + if (err) { + debug("Can't get sdr-timings for devider\n"); + return -EINVAL; + } - /* Get the base address from the device node */ - base = fdtdec_get_addr(blob, node, "reg"); - if (!base) { - debug("DWMMC: Can't get base address\n"); - return -1; - } - /* Extract the timing info from the node */ - err = fdtdec_get_int_array(blob, node, "samsung,timing", - timing, 3); + clksel_val = (DWMCI_SET_SAMPLE_CLK(timing[0]) | + DWMCI_SET_DRV_CLK(timing[1]) | + DWMCI_SET_DIV_RATIO(timing[2])); + if (clksel_val) + host->clksel_val = clksel_val; + + host->fifoth_val = fdtdec_get_int(blob, node, "fifoth_val", 0); + host->bus_hz = fdtdec_get_int(blob, node, "bus_hz", 0); + host->div = fdtdec_get_int(blob, node, "div", 0); + + return 0; +} + +static int exynos_dwmci_process_node(const void *blob, + int node_list[], int count) +{ + struct dwmci_host *host; + int i, node, err; + + for (i = 0; i < count; i++) { + node = node_list[i]; + if (node <= 0) + continue; + host = &dwmci_host[i]; + err = exynos_dwmci_get_config(blob, node, host); if (err) { - debug("Can't get sdr-timings for divider\n"); - return -1; + debug("%s: failed to decode dev %d\n", __func__, i); + return err; } - clksel_val = (DWMCI_SET_SAMPLE_CLK(timing[0]) | - DWMCI_SET_DRV_CLK(timing[1]) | - DWMCI_SET_DIV_RATIO(timing[2])); - /* Initialise each mmc channel */ - err = exynos_dwmci_add_port(index, base, bus_width, clksel_val); - if (err) - debug("dwmmc Channel-%d init failed\n", index); + do_dwmci_init(host); } return 0; } + +int exynos_dwmmc_init(const void *blob) +{ + int compat_id; + int node_list[DWMMC_MAX_CH_NUM]; + int err = 0, count; + + compat_id = COMPAT_SAMSUNG_EXYNOS_DWMMC; + + count = fdtdec_find_aliases_for_id(blob, "mmc", + compat_id, node_list, DWMMC_MAX_CH_NUM); + err = exynos_dwmci_process_node(blob, node_list, count); + + return err; +} #endif diff --git a/include/dwmmc.h b/include/dwmmc.h index c9bdf51..14c7db8 100644 --- a/include/dwmmc.h +++ b/include/dwmmc.h @@ -134,7 +134,9 @@ struct dwmci_host { unsigned int version; unsigned int clock; unsigned int bus_hz; + unsigned int div; int dev_index; + int dev_id; int buswidth; u32 clksel_val; u32 fifoth_val;