From patchwork Sat Jan 4 16:31:37 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 306869 X-Patchwork-Delegate: sbabic@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 7ADA62C0099 for ; Sun, 5 Jan 2014 03:33:13 +1100 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id EE90A4ACC4; Sat, 4 Jan 2014 17:32:52 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CIqtAx7PQQWu; Sat, 4 Jan 2014 17:32:52 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id D1EC94AD18; Sat, 4 Jan 2014 17:32:25 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id ABAE84AC8F for ; Sat, 4 Jan 2014 17:32:13 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kvj7q+n3d8eX for ; Sat, 4 Jan 2014 17:32:09 +0100 (CET) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-qa0-f54.google.com (mail-qa0-f54.google.com [209.85.216.54]) by theia.denx.de (Postfix) with ESMTPS id 13A774ACBE for ; Sat, 4 Jan 2014 17:31:57 +0100 (CET) Received: by mail-qa0-f54.google.com with SMTP id f11so1518271qae.6 for ; Sat, 04 Jan 2014 08:31:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=0uN5gsfSHkDwrXbEyjrGtm4nR9WlnMnbKku2rVazC1E=; b=Y+GgniOyO9Mny2Ssp4QhV491P3sVePhge+Q1ZmCbs4WkeKe5ipb3yfxRrojteM34lx dsCxFcthy3GNggN/o5yTR4R+gwjdM35i/qlHc9X0Yh2Rr0iUjC25kUU2kPbCzwwkcExI Ol/LRxzyDoOfYJ2d81QShmtV2eQQOHiDKo+n8jO2eAeQZOMxNmfXvTVYS37d+Gih7oaF s239URyq4AzL7KGoMUIe71IC4f7rktF5yojijLpDHJYywyf3FlPLGlIsm2PaKdY7nKJL l6yVtFTW6NNPP4NkUS/3SLPowtNDNUMnTVkimlGXX8krRAgv3hNhW4ozpbZYaapDb1Y7 1qBw== X-Received: by 10.224.119.200 with SMTP id a8mr36496200qar.7.1388853116296; Sat, 04 Jan 2014 08:31:56 -0800 (PST) Received: from localhost.localdomain ([186.207.93.139]) by mx.google.com with ESMTPSA id g1sm85418123qec.9.2014.01.04.08.31.54 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 04 Jan 2014 08:31:54 -0800 (PST) From: Fabio Estevam To: sbabic@denx.de Date: Sat, 4 Jan 2014 14:31:37 -0200 Message-Id: <1388853097-3068-6-git-send-email-festevam@gmail.com> X-Mailer: git-send-email 1.8.1.2 In-Reply-To: <1388853097-3068-1-git-send-email-festevam@gmail.com> References: <1388853097-3068-1-git-send-email-festevam@gmail.com> Cc: Fabio Estevam , u-boot@lists.denx.de Subject: [U-Boot] [PATCH 6/6] mx6slevk: Return from cpu_eth_init() directly X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.11 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de From: Fabio Estevam There is no need to print an error message when cpu_eth_init() fails because net/eth.c already prints it. In order to simplify the code, just return the value from cpu_eth_init(bis) directly. Signed-off-by: Fabio Estevam --- board/freescale/mx6slevk/mx6slevk.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/board/freescale/mx6slevk/mx6slevk.c b/board/freescale/mx6slevk/mx6slevk.c index 47c04ce..c496254 100644 --- a/board/freescale/mx6slevk/mx6slevk.c +++ b/board/freescale/mx6slevk/mx6slevk.c @@ -106,17 +106,9 @@ int board_mmc_init(bd_t *bis) #ifdef CONFIG_FEC_MXC int board_eth_init(bd_t *bis) { - int ret; - setup_iomux_fec(); - ret = cpu_eth_init(bis); - if (ret) { - printf("FEC MXC: %s:failed\n", __func__); - return ret; - } - - return 0; + return cpu_eth_init(bis); } static int setup_fec(void)