diff mbox

[U-Boot,2/2] smdk5250: Remove 'board_usb_vbus_init()' function

Message ID 1388745653-7069-2-git-send-email-gautam.vivek@samsung.com
State Accepted
Delegated to: Minkyu Kang
Headers show

Commit Message

Vivek Gautam Jan. 3, 2014, 10:40 a.m. UTC
Previously as a part of moving the VBUS gpio support to device tree
following patch removed this and added relevant support in driver:
4a271cb exynos: usb: Switch USB VBUS GPIOs to be device tree configured

Recent changes for common board file migration for exynos platform
added it again. So removing it now.

Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
Cc: Julius Werner <jwerner@chromium.org>
Cc: Minkyu Kang <mk7.kang@samsung.com>
Cc: Marek Vasut <marex@denx.de>
---
 board/samsung/smdk5250/smdk5250.c |   19 -------------------
 1 file changed, 19 deletions(-)

Comments

Vivek Gautam Jan. 3, 2014, 10:39 a.m. UTC | #1
On Fri, Jan 3, 2014 at 4:10 PM, Vivek Gautam <gautam.vivek@samsung.com> wrote:
> Previously as a part of moving the VBUS gpio support to device tree
> following patch removed this and added relevant support in driver:
> 4a271cb exynos: usb: Switch USB VBUS GPIOs to be device tree configured
>
> Recent changes for common board file migration for exynos platform
> added it again. So removing it now.
>
> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
> Cc: Julius Werner <jwerner@chromium.org>
> Cc: Minkyu Kang <mk7.kang@samsung.com>
> Cc: Marek Vasut <marex@denx.de>
> ---

Based on u-boot-samsung 'master' branch.

>  board/samsung/smdk5250/smdk5250.c |   19 -------------------
>  1 file changed, 19 deletions(-)
>
> diff --git a/board/samsung/smdk5250/smdk5250.c b/board/samsung/smdk5250/smdk5250.c
> index 943c29a..a69f73d 100644
> --- a/board/samsung/smdk5250/smdk5250.c
> +++ b/board/samsung/smdk5250/smdk5250.c
> @@ -26,22 +26,6 @@
>
>  DECLARE_GLOBAL_DATA_PTR;
>
> -#ifdef CONFIG_USB_EHCI_EXYNOS
> -static int board_usb_vbus_init(void)
> -{
> -       struct exynos5_gpio_part1 *gpio1 = (struct exynos5_gpio_part1 *)
> -                                               samsung_get_base_gpio_part1();
> -
> -       /* Enable VBUS power switch */
> -       s5p_gpio_direction_output(&gpio1->x2, 6, 1);
> -
> -       /* VBUS turn ON time */
> -       mdelay(3);
> -
> -       return 0;
> -}
> -#endif
> -
>  #ifdef CONFIG_SOUND_MAX98095
>  static void  board_enable_audio_codec(void)
>  {
> @@ -56,9 +40,6 @@ static void  board_enable_audio_codec(void)
>
>  int exynos_init(void)
>  {
> -#ifdef CONFIG_USB_EHCI_EXYNOS
> -       board_usb_vbus_init();
> -#endif
>  #ifdef CONFIG_SOUND_MAX98095
>         board_enable_audio_codec();
>  #endif
> --
> 1.7.10.4
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
Marek Vasut Jan. 4, 2014, 7:14 a.m. UTC | #2
On Friday, January 03, 2014 at 11:40:53 AM, Vivek Gautam wrote:
> Previously as a part of moving the VBUS gpio support to device tree
> following patch removed this and added relevant support in driver:
> 4a271cb exynos: usb: Switch USB VBUS GPIOs to be device tree configured
> 
> Recent changes for common board file migration for exynos platform
> added it again. So removing it now.
> 
> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
> Cc: Julius Werner <jwerner@chromium.org>
> Cc: Minkyu Kang <mk7.kang@samsung.com>
> Cc: Marek Vasut <marex@denx.de>
> ---
>  board/samsung/smdk5250/smdk5250.c |   19 -------------------
>  1 file changed, 19 deletions(-)

Reiewed-by: Marek Vasut <marex@denx.de>

Minkyu, can you please pick this?

Best regards,
Marek Vasut
Minkyu Kang Jan. 6, 2014, 1:43 a.m. UTC | #3
On 04/01/14 16:14, Marek Vasut wrote:
> On Friday, January 03, 2014 at 11:40:53 AM, Vivek Gautam wrote:
>> Previously as a part of moving the VBUS gpio support to device tree
>> following patch removed this and added relevant support in driver:
>> 4a271cb exynos: usb: Switch USB VBUS GPIOs to be device tree configured
>>
>> Recent changes for common board file migration for exynos platform
>> added it again. So removing it now.
>>
>> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
>> Cc: Julius Werner <jwerner@chromium.org>
>> Cc: Minkyu Kang <mk7.kang@samsung.com>
>> Cc: Marek Vasut <marex@denx.de>
>> ---
>>  board/samsung/smdk5250/smdk5250.c |   19 -------------------
>>  1 file changed, 19 deletions(-)
> 
> Reiewed-by: Marek Vasut <marex@denx.de>
> 
> Minkyu, can you please pick this?

OK.

> 
> Best regards,
> Marek Vasut
> 

Thanks,
Minkyu Kang.
Minkyu Kang Feb. 3, 2014, 4:45 a.m. UTC | #4
On 03/01/14 19:40, Vivek Gautam wrote:
> Previously as a part of moving the VBUS gpio support to device tree
> following patch removed this and added relevant support in driver:
> 4a271cb exynos: usb: Switch USB VBUS GPIOs to be device tree configured
> 
> Recent changes for common board file migration for exynos platform
> added it again. So removing it now.
> 
> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
> Cc: Julius Werner <jwerner@chromium.org>
> Cc: Minkyu Kang <mk7.kang@samsung.com>
> Cc: Marek Vasut <marex@denx.de>
> ---
>  board/samsung/smdk5250/smdk5250.c |   19 -------------------
>  1 file changed, 19 deletions(-)
> 

applied to u-boot-samsung.

Thanks,
Minkyu Kang.
diff mbox

Patch

diff --git a/board/samsung/smdk5250/smdk5250.c b/board/samsung/smdk5250/smdk5250.c
index 943c29a..a69f73d 100644
--- a/board/samsung/smdk5250/smdk5250.c
+++ b/board/samsung/smdk5250/smdk5250.c
@@ -26,22 +26,6 @@ 
 
 DECLARE_GLOBAL_DATA_PTR;
 
-#ifdef CONFIG_USB_EHCI_EXYNOS
-static int board_usb_vbus_init(void)
-{
-	struct exynos5_gpio_part1 *gpio1 = (struct exynos5_gpio_part1 *)
-						samsung_get_base_gpio_part1();
-
-	/* Enable VBUS power switch */
-	s5p_gpio_direction_output(&gpio1->x2, 6, 1);
-
-	/* VBUS turn ON time */
-	mdelay(3);
-
-	return 0;
-}
-#endif
-
 #ifdef CONFIG_SOUND_MAX98095
 static void  board_enable_audio_codec(void)
 {
@@ -56,9 +40,6 @@  static void  board_enable_audio_codec(void)
 
 int exynos_init(void)
 {
-#ifdef CONFIG_USB_EHCI_EXYNOS
-	board_usb_vbus_init();
-#endif
 #ifdef CONFIG_SOUND_MAX98095
 	board_enable_audio_codec();
 #endif