From patchwork Wed Dec 4 12:01:54 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 296499 X-Patchwork-Delegate: agust@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 0A4932C00A0 for ; Wed, 4 Dec 2013 23:10:14 +1100 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id C9C874B601; Wed, 4 Dec 2013 13:10:12 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mcip7aapAeeL; Wed, 4 Dec 2013 13:10:12 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 3EA3E4A9E1; Wed, 4 Dec 2013 13:10:07 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 6997C4B5F6 for ; Wed, 4 Dec 2013 13:09:57 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id h4Hen+sAJHpW for ; Wed, 4 Dec 2013 13:09:50 +0100 (CET) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-qe0-f49.google.com (mail-qe0-f49.google.com [209.85.128.49]) by theia.denx.de (Postfix) with ESMTPS id 1E3594B5F3 for ; Wed, 4 Dec 2013 13:09:41 +0100 (CET) Received: by mail-qe0-f49.google.com with SMTP id w7so15678367qeb.8 for ; Wed, 04 Dec 2013 04:09:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=NkxXSLWiNSeom9vw4xSbvS7mdvSHPay/FyngJwBq5Mg=; b=rJKxvlc5tlBfaU4n8FseORZ9hokjfea0fG3RySrHDoJmHlVcCbVWvxN/isLWAOCump 3XhKh+8P5wXJdxyXduZdjyFPrVTNKyzNkRk/3qLN4C6lvR+uQB/GIQL08yBQrJGuxkr7 O9gq648g1a++HLKTTbFGMJk9rqlhY6uB9AQS9RpDkSm5kPObIJ94Ms0QvRK+0ZHJdDC1 84DdBGsB33qgfWrLj2WxerRzMJ2zD+9nYOpUZSKFCFiEn474thvVLCmzoM6pUO70H1wo yqWfTOs75q79GRVkNioPRMTIOW5n7FK5kszblm8kDFBsWc5iJtKyYRdQfJVeGcJNd73M jP5g== X-Received: by 10.49.105.138 with SMTP id gm10mr105495222qeb.7.1386158531779; Wed, 04 Dec 2013 04:02:11 -0800 (PST) Received: from localhost.localdomain ([177.194.40.144]) by mx.google.com with ESMTPSA id ki4sm17020760qeb.0.2013.12.04.04.02.10 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 04 Dec 2013 04:02:11 -0800 (PST) From: Fabio Estevam To: agust@denx.de Date: Wed, 4 Dec 2013 10:01:54 -0200 Message-Id: <1386158514-3988-1-git-send-email-festevam@gmail.com> X-Mailer: git-send-email 1.8.1.2 Cc: Fabio Estevam , u-boot@lists.denx.de Subject: [U-Boot] [PATCH] video: ipu_disp: Return a negative value on error X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.11 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de From: Fabio Estevam We should return a negative error number (-EINVAL) on error. Signed-off-by: Fabio Estevam --- drivers/video/ipu_disp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/ipu_disp.c b/drivers/video/ipu_disp.c index 22ac142..cefd2dc 100644 --- a/drivers/video/ipu_disp.c +++ b/drivers/video/ipu_disp.c @@ -889,7 +889,7 @@ int32_t ipu_init_sync_panel(int disp, uint32_t pixel_clk, debug("panel size = %d x %d\n", width, height); if ((v_sync_width == 0) || (h_sync_width == 0)) - return EINVAL; + return -EINVAL; adapt_panel_to_ipu_restricitions(&pixel_clk, width, height, h_start_width, h_end_width,