From patchwork Mon Jun 24 14:18:18 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?=C5=81ukasz_Majewski?= X-Patchwork-Id: 253854 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id BD1D42C0089 for ; Tue, 25 Jun 2013 00:19:12 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id CEF2B4A02C; Mon, 24 Jun 2013 16:19:09 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wHnuMRx30RXS; Mon, 24 Jun 2013 16:19:09 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id A1C144A02D; Mon, 24 Jun 2013 16:19:03 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 2A4654A02D for ; Mon, 24 Jun 2013 16:18:57 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3C0KLJm00tWZ for ; Mon, 24 Jun 2013 16:18:50 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mailout4.samsung.com (mailout4.samsung.com [203.254.224.34]) by theia.denx.de (Postfix) with ESMTP id 0B1814A02C for ; Mon, 24 Jun 2013 16:18:42 +0200 (CEST) Received: from epcpsbgm2.samsung.com (epcpsbgm2 [203.254.230.27]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MOW00JZEIEYE8E0@mailout4.samsung.com> for u-boot@lists.denx.de; Mon, 24 Jun 2013 23:18:38 +0900 (KST) X-AuditID: cbfee61b-b7f8e6d00000524c-f6-51c8553e6577 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id E1.8B.21068.E3558C15; Mon, 24 Jun 2013 23:18:38 +0900 (KST) Received: from mcdsrvbld02.digital.local ([106.116.37.23]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MOW00KS3IELBT00@mmp1.samsung.com>; Mon, 24 Jun 2013 23:18:38 +0900 (KST) From: Lukasz Majewski To: u-boot@lists.denx.de Date: Mon, 24 Jun 2013 16:18:18 +0200 Message-id: <1372083498-19938-1-git-send-email-l.majewski@samsung.com> X-Mailer: git-send-email 1.7.10 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrBJMWRmVeSWpSXmKPExsVy+t9jAV270BOBBksPalqcbXrDbvHmEbfF m4ebGS123Z7MYjF58Xxmi7d7O9kd2Dzm/ZzI5HH2zg5Gj3XT3jJ79G1Zxehx/MZ2pgDWKC6b lNSczLLUIn27BK6Mz+f3sRfM4ao4fG4PYwPjHo4uRk4OCQETiQsdt5ghbDGJC/fWs3UxcnEI CSxilFjTf5oZwulikphyegMjSBWbgJ7E57tPmUBsEQEJiV/9VxlBipgFLjJKzHl4mB0kISzg KvF0ynOwIhYBVYneKQfAbF4BN4m5C+czQayTl3h6v49tAiP3AkaGVYyiqQXJBcVJ6blGesWJ ucWleel6yfm5mxjB4fFMegfjqgaLQ4wCHIxKPLwLzI8HCrEmlhVX5h5ilOBgVhLhDRU5ESjE m5JYWZValB9fVJqTWnyIUZqDRUmc92CrdaCQQHpiSWp2ampBahFMlomDU6qBkdv2Qn9Rh+9M l3fatqpSCrKCS6o3neL6fESYKejrZfM/HNNUjBNPiMW+MGSv/n3hvIFQ2mc5q79M09KXbRMQ KDwhs9j1ruUt44YH77XnOc1b4nDIwmHaH/cf5SckXYsbNY+sKcteF/JRqc9dMMba8ZDu8fjT r0rSa7Y1u4dvusbDM3Xu9KKdSizFGYmGWsxFxYkAthrspwsCAAA= Cc: Tom Rini , Kyungmin Park , Lukasz Majewski , Pantelis Antoniou Subject: [U-Boot] [PATCH] dfu:ext4:fix Fix ext4{read|write} command formatting X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.11 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de In the following commit: "dfu: Support larger than memory transfers." SHA1: ea2453d56b8860dbd18a3c517531ffc8dcb5c839 The ext4{read|write} command formatting has been changed. It removed a mandatory [sizebytes] parameter. It prevented from ext4 update via dfu. This commit restored the previous behaviour. Signed-off-by: Lukasz Majewski Signed-off-by: Kyungmin Park Cc: Tom Rini Cc: Pantelis Antoniou --- drivers/dfu/dfu_mmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/dfu/dfu_mmc.c b/drivers/dfu/dfu_mmc.c index e2f3978..032c6a7 100644 --- a/drivers/dfu/dfu_mmc.c +++ b/drivers/dfu/dfu_mmc.c @@ -94,10 +94,10 @@ static int mmc_file_op(enum dfu_mmc_op op, struct dfu_entity *dfu, sprintf(cmd_buf + strlen(cmd_buf), " %lx", *len); break; case DFU_FS_EXT4: - sprintf(cmd_buf, "ext4%s mmc %d:%d 0x%x /%s", + sprintf(cmd_buf, "ext4%s mmc %d:%d 0x%x /%s %ld", op == DFU_OP_READ ? "load" : "write", dfu->data.mmc.dev, dfu->data.mmc.part, - (unsigned int) buf, dfu->name); + (unsigned int) buf, dfu->name, *len); break; default: printf("%s: Layout (%s) not (yet) supported!\n", __func__,