From patchwork Thu May 2 14:04:16 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 241009 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id F2FAF2C00C2 for ; Fri, 3 May 2013 00:15:35 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 87F354A228; Thu, 2 May 2013 16:15:29 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jYGB-MVJ12+K; Thu, 2 May 2013 16:15:29 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 28AA24A0F7; Thu, 2 May 2013 16:14:48 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id D02134A1FC for ; Thu, 2 May 2013 16:09:00 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XutPw6g-kndh for ; Thu, 2 May 2013 16:05:46 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 BL_NJABL=SKIP(-1.5) (only DNSBL check requested) Received: from co1outboundpool.messaging.microsoft.com (co1ehsobe003.messaging.microsoft.com [216.32.180.186]) by theia.denx.de (Postfix) with ESMTPS id 0DA924A1AC for ; Thu, 2 May 2013 16:04:56 +0200 (CEST) Received: from mail20-co1-R.bigfish.com (10.243.78.230) by CO1EHSOBE021.bigfish.com (10.243.66.84) with Microsoft SMTP Server id 14.1.225.23; Thu, 2 May 2013 14:04:53 +0000 Received: from mail20-co1 (localhost [127.0.0.1]) by mail20-co1-R.bigfish.com (Postfix) with ESMTP id 97D99C40196; Thu, 2 May 2013 14:04:53 +0000 (UTC) X-Forefront-Antispam-Report: CIP:70.37.183.190; KIP:(null); UIP:(null); IPV:NLI; H:mail.freescale.net; RD:none; EFVD:NLI X-SpamScore: 0 X-BigFish: VS0(zzzz1f42h1fc6h1ee6h1de0h1fdah1202h1e76h1d1ah1d2ahzz8275bhz2dh2a8h668h839hd24he5bhf0ah1288h12a5h12a9h12bdh12e5h137ah139eh13b6h1441h1504h1537h162dh1631h1758h1898h18e1h1946h19b5h1ad9h1b0ah1d0ch1d2eh1d3fh1155h) Received: from mail20-co1 (localhost.localdomain [127.0.0.1]) by mail20-co1 (MessageSwitch) id 1367503490910348_19439; Thu, 2 May 2013 14:04:50 +0000 (UTC) Received: from CO1EHSMHS004.bigfish.com (unknown [10.243.78.238]) by mail20-co1.bigfish.com (Postfix) with ESMTP id D86D480007E; Thu, 2 May 2013 14:04:50 +0000 (UTC) Received: from mail.freescale.net (70.37.183.190) by CO1EHSMHS004.bigfish.com (10.243.66.14) with Microsoft SMTP Server (TLS) id 14.1.225.23; Thu, 2 May 2013 14:04:50 +0000 Received: from tx30smr01.am.freescale.net (10.81.153.31) by 039-SN1MMR1-001.039d.mgd.msft.net (10.84.1.13) with Microsoft SMTP Server (TLS) id 14.2.328.11; Thu, 2 May 2013 14:04:49 +0000 Received: from fabio-Latitude-E6410.am.freescale.net ([10.29.244.56]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id r42E4OiP026112; Thu, 2 May 2013 07:04:43 -0700 From: Fabio Estevam To: Date: Thu, 2 May 2013 11:04:16 -0300 Message-ID: <1367503462-24742-3-git-send-email-fabio.estevam@freescale.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1367503462-24742-1-git-send-email-fabio.estevam@freescale.com> References: <1367503462-24742-1-git-send-email-fabio.estevam@freescale.com> MIME-Version: 1.0 X-OriginatorOrg: freescale.com Cc: marex@denx.de, Estevam , Fabio@theia.denx.de, otavio@ossystems.com.br, Lauri Hintsala , u-boot@lists.denx.de Subject: [U-Boot] [PATCH v2 2/8] mxs: Fix PULLUP/NOPULL definitions X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.11 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de On mx23 and mx28 the pullup bits are defined as: - 0: Enable the internal pad keeper - 1: Disable the internal pad keeper Fix the definitions as they are currently the opposite. Cc: Lauri Hintsala Signed-off-by: Fabio Estevam --- This affects mx28 as well, so also adding Lauri. I also tested on mx28evk and behavior is fine after this change. Changes since v1: - Newly introduced arch/arm/include/asm/arch-mxs/iomux.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/include/asm/arch-mxs/iomux.h b/arch/arm/include/asm/arch-mxs/iomux.h index 66dcd36..70300d5 100644 --- a/arch/arm/include/asm/arch-mxs/iomux.h +++ b/arch/arm/include/asm/arch-mxs/iomux.h @@ -78,8 +78,8 @@ typedef u32 iomux_cfg_t; #define PAD_3V3 0 #endif -#define PAD_NOPULL 0 -#define PAD_PULLUP 1 +#define PAD_PULLUP 0 +#define PAD_NOPULL 1 #define MXS_PAD_4MA ((PAD_4MA << MXS_PAD_MA_SHIFT) | \ MXS_PAD_MA_VALID_MASK)