diff mbox

[U-Boot,3/3] mx53ard: Move register masks into imx-regs.h

Message ID 1366850673-23907-3-git-send-email-festevam@gmail.com
State Awaiting Upstream
Delegated to: Stefano Babic
Headers show

Commit Message

Fabio Estevam April 25, 2013, 12:44 a.m. UTC 
From: Fabio Estevam <fabio.estevam@freescale.com>

imx-regs.h is more appropriate location for containing register masks. 

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 arch/arm/include/asm/arch-mx5/imx-regs.h |    2 ++
 board/freescale/mx53ard/mx53ard.c        |    2 --
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Marek Vasut April 25, 2013, 1:17 a.m. UTC | #1 
Dear Fabio Estevam,

> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> imx-regs.h is more appropriate location for containing register masks.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Thanks,

Acked-by: Marek Vasut <marex@denx.de>

Best regards,
Marek Vasut
Stefano Babic April 25, 2013, 7:50 p.m. UTC | #2 
On 25/04/2013 02:44, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> imx-regs.h is more appropriate location for containing register masks. 
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic
diff mbox

Patch

diff --git a/arch/arm/include/asm/arch-mx5/imx-regs.h b/arch/arm/include/asm/arch-mx5/imx-regs.h
index a71cc13..6aff3be 100644
--- a/arch/arm/include/asm/arch-mx5/imx-regs.h
+++ b/arch/arm/include/asm/arch-mx5/imx-regs.h
@@ -267,6 +267,8 @@ 
 /* M4IF */
 #define M4IF_FBPM0	0x40
 #define M4IF_FIDBP	0x48
+#define M4IF_GENP_WEIM_MM_MASK		0x00000001
+#define WEIM_GCR2_MUX16_BYP_GRANT_MASK	0x00001000
 
 /* Assuming 24MHz input clock with doubler ON */
 /*                            MFI         PDF */
diff --git a/board/freescale/mx53ard/mx53ard.c b/board/freescale/mx53ard/mx53ard.c
index 8d433a3..32c4d5f 100644
--- a/board/freescale/mx53ard/mx53ard.c
+++ b/board/freescale/mx53ard/mx53ard.c
@@ -62,8 +62,6 @@  void dram_init_banksize(void)
 static void setup_iomux_nand(void)
 {
 	u32 i, reg;
-	#define M4IF_GENP_WEIM_MM_MASK		0x00000001
-	#define WEIM_GCR2_MUX16_BYP_GRANT_MASK	0x00001000
 
 	reg = __raw_readl(M4IF_BASE_ADDR + 0xc);
 	reg &= ~M4IF_GENP_WEIM_MM_MASK;