| Message ID | 1324639752-26856-1-git-send-email-wd@denx.de |
|---|---|
| State | Accepted |
| Headers | show |
Hello Wolfgang, Looks good. A minor commend below. On Fri, 23 Dec 2011 12:29:10 +0100 Wolfgang Denk <wd@denx.de> wrote: > Signed-off-by: Wolfgang Denk <wd@denx.de> > Cc: Anatolij Gustschin <agust@denx.de> > Cc: Stefan Roese <sr@denx.de> > Cc: Kumar Gala <galak@kernel.crashing.org> > Cc: Kim Phillips <kim.phillips@freescale.com> > Cc: Andy Fleming <afleming@gmail.com> > --- > post/lib_powerpc/multi.c | 54 +++++++++++++++++++++------------------------ > 1 files changed, 25 insertions(+), 29 deletions(-) > > diff --git a/post/lib_powerpc/multi.c b/post/lib_powerpc/multi.c > index 5845616..4b4b119 100644 > --- a/post/lib_powerpc/multi.c > +++ b/post/lib_powerpc/multi.c > @@ -38,45 +38,41 @@ > > #if CONFIG_POST & CONFIG_SYS_POST_CPU > > -extern void cpu_post_exec_02 (ulong *code, ulong op1, ulong op2); > +extern void cpu_post_exec_02(ulong * code, ulong op1, ulong op2); IIRC checkpatch complains like "foo * bar" should be "foo *bar", There is surely no need to resubmit the patch, it could be changed when applying. Otherwise Acked-by: Anatolij Gustschin <agust@denx.de> Thanks, Anatolij
Dear Wolfgang Denk, In message <1324639752-26856-1-git-send-email-wd@denx.de> you wrote: > Signed-off-by: Wolfgang Denk <wd@denx.de> > Cc: Anatolij Gustschin <agust@denx.de> > Cc: Stefan Roese <sr@denx.de> > Cc: Kumar Gala <galak@kernel.crashing.org> > Cc: Kim Phillips <kim.phillips@freescale.com> > Cc: Andy Fleming <afleming@gmail.com> > > --- > post/lib_powerpc/multi.c | 54 +++++++++++++++++++++------------------------ > 1 files changed, 25 insertions(+), 29 deletions(-) Applied, thanks. Best regards, Wolfgang Denk
Dear Anatolij Gustschin, In message <20111223133952.5e09a8b4@wker> you wrote: > > Looks good. A minor commend below. ... > > -extern void cpu_post_exec_02 (ulong *code, ulong op1, ulong op2); > > +extern void cpu_post_exec_02(ulong * code, ulong op1, ulong op2); > > IIRC checkpatch complains like "foo * bar" should be "foo *bar", > There is surely no need to resubmit the patch, it could be changed > when applying. Otherwise You are right. Fixed this. Thanks for the review! Best regards, Wolfgang Denk
diff --git a/post/lib_powerpc/multi.c b/post/lib_powerpc/multi.c index 5845616..4b4b119 100644 --- a/post/lib_powerpc/multi.c +++ b/post/lib_powerpc/multi.c @@ -38,45 +38,41 @@ #if CONFIG_POST & CONFIG_SYS_POST_CPU -extern void cpu_post_exec_02 (ulong *code, ulong op1, ulong op2); +extern void cpu_post_exec_02(ulong * code, ulong op1, ulong op2); -int cpu_post_test_multi (void) +int cpu_post_test_multi(void) { - int ret = 0; - unsigned int i; - int flag = disable_interrupts(); + int ret = 0; + unsigned int i; + int flag = disable_interrupts(); - if (ret == 0) - { - ulong src [26], dst [26]; + if (ret == 0) { + ulong src[26], dst[26]; - ulong code[] = - { - ASM_LMW(5, 3, 0), - ASM_STMW(5, 4, 0), - ASM_BLR, - }; + ulong code[] = { + ASM_LMW(5, 3, 0), + ASM_STMW(5, 4, 0), + ASM_BLR, + }; - for (i = 0; i < ARRAY_SIZE(src); ++i) - { - src[i] = i; - dst[i] = 0; - } + for (i = 0; i < ARRAY_SIZE(src); ++i) { + src[i] = i; + dst[i] = 0; + } - cpu_post_exec_02(code, (ulong)src, (ulong)dst); + cpu_post_exec_02(code, (ulong) src, (ulong) dst); - ret = memcmp(src, dst, sizeof(dst)) == 0 ? 0 : -1; - } + ret = memcmp(src, dst, sizeof(dst)) == 0 ? 0 : -1; + } - if (ret != 0) - { - post_log ("Error at multi test !\n"); - } + if (ret != 0) { + post_log("Error at multi test !\n"); + } - if (flag) - enable_interrupts(); + if (flag) + enable_interrupts(); - return ret; + return ret; } #endif
Signed-off-by: Wolfgang Denk <wd@denx.de> Cc: Anatolij Gustschin <agust@denx.de> Cc: Stefan Roese <sr@denx.de> Cc: Kumar Gala <galak@kernel.crashing.org> Cc: Kim Phillips <kim.phillips@freescale.com> Cc: Andy Fleming <afleming@gmail.com> --- post/lib_powerpc/multi.c | 54 +++++++++++++++++++++------------------------ 1 files changed, 25 insertions(+), 29 deletions(-)