diff mbox

[U-Boot] mv_common.c: get rid of 'defined but not used' warning

Message ID 1319110638-20331-1-git-send-email-michael.jones@matrix-vision.de
State Accepted
Commit a1d88f43e44d016b073ded77343faad87d14e516
Delegated to: Anatolij Gustschin
Headers show

Commit Message

Michael Jones Oct. 20, 2011, 11:37 a.m. UTC
When CONFIG_ENV_IS_NOWHERE, got following warning:
mv_common.c:32:14: warning: 'entries_to_keep' defined but not used.
Get rid of this warning.

Signed-off-by: Michael Jones <michael.jones@matrix-vision.de>
---
 board/matrix_vision/common/mv_common.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Andre Schwarz Oct. 20, 2011, 11:48 a.m. UTC | #1
Am 20.10.2011 13:37, schrieb Michael Jones:
> When CONFIG_ENV_IS_NOWHERE, got following warning:
> mv_common.c:32:14: warning: 'entries_to_keep' defined but not used.
> Get rid of this warning.
>
> Signed-off-by: Michael Jones<michael.jones@matrix-vision.de>
Acked-by: Andre Schwarz <andre.schwarz@matrix-vision.de>

> ---
>   board/matrix_vision/common/mv_common.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/board/matrix_vision/common/mv_common.c b/board/matrix_vision/common/mv_common.c
> index 404c8b4..acb72c5 100644
> --- a/board/matrix_vision/common/mv_common.c
> +++ b/board/matrix_vision/common/mv_common.c
> @@ -29,6 +29,7 @@
>
>   DECLARE_GLOBAL_DATA_PTR;
>
> +#ifndef CONFIG_ENV_IS_NOWHERE
>   static char* entries_to_keep[] = {
>   	"serial#", "ethaddr", "eth1addr", "model_info", "sensor_cnt",
>   	"fpgadatasize", "ddr_size", "use_dhcp", "use_static_ipaddr",
> @@ -38,7 +39,6 @@ static char* entries_to_keep[] = {
>   #define MV_MAX_ENV_ENTRY_LENGTH	64
>   #define MV_KEEP_ENTRIES		ARRAY_SIZE(entries_to_keep)
>
> -#ifndef CONFIG_ENV_IS_NOWHERE
>   void mv_reset_environment(void)
>   {
>   	int i;
Anatolij Gustschin Dec. 3, 2011, 12:32 p.m. UTC | #2
On Thu, 20 Oct 2011 13:37:18 +0200
Michael Jones <michael.jones@matrix-vision.de> wrote:

> When CONFIG_ENV_IS_NOWHERE, got following warning:
> mv_common.c:32:14: warning: 'entries_to_keep' defined but not used.
> Get rid of this warning.
> 
> Signed-off-by: Michael Jones <michael.jones@matrix-vision.de>
> ---
>  board/matrix_vision/common/mv_common.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Applied to u-boot-staging/agust@denx.de. Thanks!

Anatolij
diff mbox

Patch

diff --git a/board/matrix_vision/common/mv_common.c b/board/matrix_vision/common/mv_common.c
index 404c8b4..acb72c5 100644
--- a/board/matrix_vision/common/mv_common.c
+++ b/board/matrix_vision/common/mv_common.c
@@ -29,6 +29,7 @@ 
 
 DECLARE_GLOBAL_DATA_PTR;
 
+#ifndef CONFIG_ENV_IS_NOWHERE
 static char* entries_to_keep[] = {
 	"serial#", "ethaddr", "eth1addr", "model_info", "sensor_cnt",
 	"fpgadatasize", "ddr_size", "use_dhcp", "use_static_ipaddr",
@@ -38,7 +39,6 @@  static char* entries_to_keep[] = {
 #define MV_MAX_ENV_ENTRY_LENGTH	64
 #define MV_KEEP_ENTRIES		ARRAY_SIZE(entries_to_keep)
 
-#ifndef CONFIG_ENV_IS_NOWHERE
 void mv_reset_environment(void)
 {
 	int i;