diff mbox

[U-Boot,v2,4/6] da850: revert cache disable patch

Message ID 1318066118-20152-5-git-send-email-manjunath.hadli@ti.com
State Rejected
Delegated to: Tom Rini
Headers show

Commit Message

Hadli, Manjunath Oct. 8, 2011, 9:28 a.m. UTC 
From: Manjunath Hadli <manjunath.hadli@ti.com>

revert commit bd65d006a6088bcb857e079447d7549e2cd7054d as the
disabling of cache need not be done explicitly. Subsequent
patches to new cache management framework has fixed it.
EMAC issue with cache coherency still exists when cahces are
enabled.

Signed-off-by: Manjunath Hadli <manjunath.hadli@ti.com>
---
 include/configs/da850_l138evm.h |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

Comments

Laurence Withers Oct. 8, 2011, 12:56 p.m. UTC | #1 
On Sat, Oct 08, 2011 at 02:58:36PM +0530, manjunath.hadli@ti.com wrote:
> revert commit bd65d006a6088bcb857e079447d7549e2cd7054d as the
> disabling of cache need not be done explicitly. Subsequent
> patches to new cache management framework has fixed it.
> EMAC issue with cache coherency still exists when cahces are
> enabled.

Hi Manjunath,

A small thing, but I'd recommend you drop the sentence "Subsequent patches to
new cache management framework has fixed it.", as it implies things were
broken (true) and are now fixed (still not true).

In fact, would it be better to simply drop this patch from the patch series
altogether, leaving the caches explicitly disabled, until such a time as the
EMAC driver is fixed (I guess we are mainly waiting to see if anyone wants to
tackle cache ops for the ARM926EJS) and the code has been verified with
caches enabled?

Bye for now,
Hadli, Manjunath Oct. 11, 2011, 6:46 a.m. UTC | #2 
Laurence,
On Sat, Oct 08, 2011 at 18:26:39, Laurence Withers wrote:
> On Sat, Oct 08, 2011 at 02:58:36PM +0530, manjunath.hadli@ti.com wrote:
> > revert commit bd65d006a6088bcb857e079447d7549e2cd7054d as the 
> > disabling of cache need not be done explicitly. Subsequent patches to 
> > new cache management framework has fixed it.
> > EMAC issue with cache coherency still exists when cahces are enabled.
> 
> Hi Manjunath,
> 
> A small thing, but I'd recommend you drop the sentence "Subsequent patches to new cache management framework has fixed it.", as it implies things were broken (true) and are now fixed (still not true).

> 
> In fact, would it be better to simply drop this patch from the patch series altogether, leaving the caches explicitly disabled, until such a time as the EMAC driver is fixed (I guess we are mainly waiting to see if anyone wants to tackle cache ops for the ARM926EJS) and the code has been verified with caches enabled?
Sure. I am dropping this patch for now. We will tackle (or may be Yonuk) it 
Again soon.

> 
> Bye for now,
> -- 
> Laurence Withers, <lwithers@guralp.com>                http://www.guralp.com/
> Direct tel:+447753988197 or tel:+443333408643               Software Engineer
> General support queries: <support@guralp.com>         CMG-DCM CMG-EAM CMG-NAM
>
diff mbox

Patch

diff --git a/include/configs/da850_l138evm.h b/include/configs/da850_l138evm.h
index 347893c..0bd630f 100644
--- a/include/configs/da850_l138evm.h
+++ b/include/configs/da850_l138evm.h
@@ -43,9 +43,6 @@ 
 #define CONFIG_SYS_HZ			1000
 #define CONFIG_SKIP_LOWLEVEL_INIT
 #define CONFIG_SYS_TEXT_BASE		0xc1080000
-#define CONFIG_SYS_ICACHE_OFF
-#define CONFIG_SYS_DCACHE_OFF
-#define CONFIG_SYS_L2CACHE_OFF
 
 /*
  * Memory Info