diff mbox

[U-Boot,5/8] PPC: Fix pd67290.c by removing ifdef around "buf"

Message ID 1317603450-7527-6-git-send-email-marek.vasut@gmail.com
State Rejected
Headers show

Commit Message

Marek Vasut Oct. 3, 2011, 12:57 a.m. UTC 
From: Marek Vasut <marex@pollux.denx.de>

As the "buf" is cleared at runtime, this might introduce a slight overhead.

Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
---
 board/cpc45/pd67290.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

Comments

Wolfgang Denk Oct. 3, 2011, 2:32 p.m. UTC | #1 
Dear Marek Vasut,

In message <1317603450-7527-6-git-send-email-marek.vasut@gmail.com> you wrote:
> From: Marek Vasut <marex@pollux.denx.de>

Fix...

> As the "buf" is cleared at runtime, this might introduce a slight overhead.
> 
> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> ---
>  board/cpc45/pd67290.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/board/cpc45/pd67290.c b/board/cpc45/pd67290.c
> index 0d8ef23..96d7289 100644
> --- a/board/cpc45/pd67290.c
> +++ b/board/cpc45/pd67290.c
> @@ -225,11 +225,9 @@ static u_int cirrus_set_opts (socket_info_t * s)
>  {
>  	cirrus_state_t *p = &s->c_state;
>  	u_int mask = 0xffff;
> -#if DEBUG
>  	char buf[200];
>  
>  	memset (buf, 0, 200);
> -#endif

NAK due to code size increase.

Best regards,

Wolfgang Denk
diff mbox

Patch

diff --git a/board/cpc45/pd67290.c b/board/cpc45/pd67290.c
index 0d8ef23..96d7289 100644
--- a/board/cpc45/pd67290.c
+++ b/board/cpc45/pd67290.c
@@ -225,11 +225,9 @@  static u_int cirrus_set_opts (socket_info_t * s)
 {
 	cirrus_state_t *p = &s->c_state;
 	u_int mask = 0xffff;
-#if DEBUG
 	char buf[200];
 
 	memset (buf, 0, 200);
-#endif
 
 	if (has_ring == -1)
 		has_ring = 1;