| Message ID | 1316278139-28635-18-git-send-email-sjg@chromium.org |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Saturday, September 17, 2011 12:48:56 Simon Glass wrote: > --- /dev/null > +++ b/include/configs/sandbox.h missing #ifdef multiple include protection > +#define CONFIG_NR_DRAM_BANKS 1 > +#define CONFIG_SYS_SDRAM_BASE 0 > +#define CONFIG_DRAM_SIZE (128 << 20) do you need any of this ? > +#define CONFIG_SYS_PROMPT "=>" /* Command Prompt */ this file has a bunch of "#define<tab>" where it should be "#define<space>" > +#define CONFIG_LMB i dont think you need this either ? -mike
Hi Mike, On Sat, Sep 17, 2011 at 5:22 PM, Mike Frysinger <vapier@gentoo.org> wrote: > On Saturday, September 17, 2011 12:48:56 Simon Glass wrote: >> --- /dev/null >> +++ b/include/configs/sandbox.h > > missing #ifdef multiple include protection > >> +#define CONFIG_NR_DRAM_BANKS 1 >> +#define CONFIG_SYS_SDRAM_BASE 0 I don't need this ^^ >> +#define CONFIG_DRAM_SIZE (128 << 20) > > do you need any of this ? I want to have simulated DRAM, so yes. But I will make it start always at 0 which removes one item. > >> +#define CONFIG_SYS_PROMPT "=>" /* Command Prompt */ > > this file has a bunch of "#define<tab>" where it should be "#define<space>" OK, fixed. > >> +#define CONFIG_LMB > > i dont think you need this either ? No, removed. Regards, Simon > -mike >
On Friday, September 23, 2011 12:00:15 Simon Glass wrote: > On Sat, Sep 17, 2011 at 5:22 PM, Mike Frysinger wrote: > > On Saturday, September 17, 2011 12:48:56 Simon Glass wrote: > >> +#define CONFIG_DRAM_SIZE (128 << 20) > > > > do you need any of this ? > > I want to have simulated DRAM, so yes. But I will make it start always > at 0 which removes one item. which is fine, but i guess the notion of "how much ram do i have" is not standardized anywhere. you're copying the arm tree as the basis of the sandbox arch, so it's including the DRAM conventions that arm uses. -mike
Hi Mike, On Sun, Sep 25, 2011 at 9:52 PM, Mike Frysinger <vapier@gentoo.org> wrote: > On Friday, September 23, 2011 12:00:15 Simon Glass wrote: >> On Sat, Sep 17, 2011 at 5:22 PM, Mike Frysinger wrote: >> > On Saturday, September 17, 2011 12:48:56 Simon Glass wrote: >> >> +#define CONFIG_DRAM_SIZE (128 << 20) >> > >> > do you need any of this ? >> >> I want to have simulated DRAM, so yes. But I will make it start always >> at 0 which removes one item. > > which is fine, but i guess the notion of "how much ram do i have" is not > standardized anywhere. you're copying the arm tree as the basis of the > sandbox arch, so it's including the DRAM conventions that arm uses. > -mike > No, not yet. I suppose it will be in a config file somewhere and defined by the test controller. TBD. Regards, Simon
diff --git a/include/configs/sandbox.h b/include/configs/sandbox.h new file mode 100644 index 0000000..43c7172 --- /dev/null +++ b/include/configs/sandbox.h @@ -0,0 +1,80 @@ +/* + * Copyright (c) 2011 The Chromium OS Authors. + * See file CREDITS for list of people who contributed to this + * project. + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; either version 2 of + * the License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, + * MA 02111-1307 USA + */ + +#define CONFIG_NR_DRAM_BANKS 1 +#define CONFIG_SYS_SDRAM_BASE 0 +#define CONFIG_DRAM_SIZE (128 << 20) + +/* Number of bits in a C 'long' on this architecture */ +#define CONFIG_SANDBOX_BITS_PER_LONG 64 + +/* + * Size of malloc() pool, although we don't actually use this yet. + */ +#define CONFIG_SYS_MALLOC_LEN (4 << 20) /* 4MB */ + +#define CONFIG_SYS_PROMPT "=>" /* Command Prompt */ +#define CONFIG_SYS_HUSH_PARSER +#define CONFIG_SYS_PROMPT_HUSH_PS2 "> " +#define CONFIG_SYS_LONGHELP /* #undef to save memory */ +#define CONFIG_SYS_CBSIZE 1024 /* Console I/O Buffer Size */ + +/* Print Buffer Size */ +#define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + sizeof(CONFIG_SYS_PROMPT) + 16) +#define CONFIG_SYS_MAXARGS 16 + +/* turn on command-line edit/c/auto */ +#define CONFIG_CMDLINE_EDITING +#define CONFIG_COMMAND_HISTORY +#define CONFIG_AUTOCOMPLETE + +#define CONFIG_ENV_SIZE 8192 +#define CONFIG_ENV_IS_NOWHERE + +#define CONFIG_SYS_HZ 1000 + +/* Memory things - we don't really want a memory test */ +#define CONFIG_SYS_LOAD_ADDR 0x10000000 +#define CONFIG_SYS_MEMTEST_START 0x10000000 +#define CONFIG_SYS_MEMTEST_END (CONFIG_SYS_MEMTEST_START + 0x1000) +#define CONFIG_PHYS_64BIT + +#define CONFIG_BAUDRATE 115200 +#define CONFIG_SYS_BAUDRATE_TABLE {4800, 9600, 19200, 38400, 57600,\ + 115200} +#define CONFIG_SANDBOX_SERIAL + +#define CONFIG_SYS_NO_FLASH + +#define CONFIG_LMB + +/* include default commands */ +#include <config_cmd_default.h> + +/* We don't have networking support yet */ +#undef CONFIG_CMD_NET +#undef CONFIG_CMD_NFS + +#define CONFIG_BOOTARGS "" + +#define CONFIG_EXTRA_ENV_SETTINGS "stdin=serial\0" \ + "stdout=serial,lcd\0" \ + "stderr=serial,lcd\0"
This includes just a few basic features to illustrate the concept. Signed-off-by: Simon Glass <sjg@chromium.org> --- include/configs/sandbox.h | 80 +++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 80 insertions(+), 0 deletions(-) create mode 100644 include/configs/sandbox.h