| Message ID | 1310717371-1677-5-git-send-email-michael.jones@matrix-vision.de |
|---|---|
| State | Accepted |
| Commit | 191c0b87b19e5bbb9caf25cd7e2e80ab5cc8cb86 |
| Headers | show |
Michael Jones <michael.jones@matrix-vision.de> writes: > In the only implementation of 'mac read', it doesn't display the > contents of the eeprom as the help indicated unless compiled with > DEBUG. It only re-reads the contents of the EEPROM into memory. > Displaying the contents of the EEPROM is done by passing no > arguments to 'mac'. > > Signed-off-by: Michael Jones <michael.jones@matrix-vision.de> Acked-by: Detlev Zundel <dzu@denx.de>
Hi Detlev, On 07/15/2011 05:17 PM, Detlev Zundel wrote: > > Michael Jones <michael.jones@matrix-vision.de> writes: > >> In the only implementation of 'mac read', it doesn't display the >> contents of the eeprom as the help indicated unless compiled with >> DEBUG. It only re-reads the contents of the EEPROM into memory. >> Displaying the contents of the EEPROM is done by passing no >> arguments to 'mac'. >> >> Signed-off-by: Michael Jones <michael.jones@matrix-vision.de> > > Acked-by: Detlev Zundel <dzu@denx.de> > Thanks for the ack. Do you know when I can expect these to get merged in? MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler Registergericht: Amtsgericht Stuttgart, HRB 271090 Geschaeftsfuehrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner, Erhard Meier
Hi Michael, > Hi Detlev, > > On 07/15/2011 05:17 PM, Detlev Zundel wrote: >> >> Michael Jones <michael.jones@matrix-vision.de> writes: >> >>> In the only implementation of 'mac read', it doesn't display the >>> contents of the eeprom as the help indicated unless compiled with >>> DEBUG. It only re-reads the contents of the EEPROM into memory. >>> Displaying the contents of the EEPROM is done by passing no >>> arguments to 'mac'. >>> >>> Signed-off-by: Michael Jones <michael.jones@matrix-vision.de> >> >> Acked-by: Detlev Zundel <dzu@denx.de> >> > > Thanks for the ack. Do you know when I can expect these to get merged in? As we currently lack a network maintainer, these patches fall into the "and all the rest category" picked up sequentially by Wolfgang. I expect that to happen Real Soon (tm) now. On the other hand, please do not forget that we _intentionally_ allow for some time to pass before the patches are merged in order to allow for review on the mailing list and to prevent potentially merge/revert/change/merge cycles. Cheers Detlev
Hi Detlev, Thanks for the reply. On 07/27/2011 03:54 PM, Detlev Zundel wrote: > > Hi Michael, > >> Hi Detlev, >> >> On 07/15/2011 05:17 PM, Detlev Zundel wrote: >>> >>> Michael Jones <michael.jones@matrix-vision.de> writes: >>> >>>> In the only implementation of 'mac read', it doesn't display the >>>> contents of the eeprom as the help indicated unless compiled with >>>> DEBUG. It only re-reads the contents of the EEPROM into memory. >>>> Displaying the contents of the EEPROM is done by passing no >>>> arguments to 'mac'. >>>> >>>> Signed-off-by: Michael Jones <michael.jones@matrix-vision.de> >>> >>> Acked-by: Detlev Zundel <dzu@denx.de> >>> >> >> Thanks for the ack. Do you know when I can expect these to get merged in? > > As we currently lack a network maintainer, these patches fall into the > "and all the rest category" picked up sequentially by Wolfgang. I > expect that to happen Real Soon (tm) now. That's exactly what I wanted to know- it seemed there wasn't a custodian whom I needed to cc:, and I didn't know who would end up merging them. > > On the other hand, please do not forget that we _intentionally_ allow > for some time to pass before the patches are merged in order to allow > for review on the mailing list and to prevent potentially > merge/revert/change/merge cycles. Sure, and that makes sense. I just wanted to get a feel for what kind of time scale that was in general. Obviously these are not important patches. > > Cheers > Detlev > thanks, Michael MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler Registergericht: Amtsgericht Stuttgart, HRB 271090 Geschaeftsfuehrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner, Erhard Meier
Dear Michael Jones, In message <1310717371-1677-5-git-send-email-michael.jones@matrix-vision.de> you wrote: > In the only implementation of 'mac read', it doesn't display the > contents of the eeprom as the help indicated unless compiled with > DEBUG. It only re-reads the contents of the EEPROM into memory. > Displaying the contents of the EEPROM is done by passing no > arguments to 'mac'. > > Signed-off-by: Michael Jones <michael.jones@matrix-vision.de> > --- > common/cmd_mac.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Applied, thanks. Best regards, Wolfgang Denk
diff --git a/common/cmd_mac.c b/common/cmd_mac.c index 0f924b7..fcc2867 100644 --- a/common/cmd_mac.c +++ b/common/cmd_mac.c @@ -31,7 +31,7 @@ U_BOOT_CMD( "display and program the system ID and MAC addresses in EEPROM", "[read|save|id|num|errata|date|ports|0|1|2|3|4|5|6|7]\n" "mac read\n" - " - show content of EEPROM\n" + " - read EEPROM content into memory\n" "mac save\n" " - save to the EEPROM\n" "mac id\n"
In the only implementation of 'mac read', it doesn't display the contents of the eeprom as the help indicated unless compiled with DEBUG. It only re-reads the contents of the EEPROM into memory. Displaying the contents of the EEPROM is done by passing no arguments to 'mac'. Signed-off-by: Michael Jones <michael.jones@matrix-vision.de> --- common/cmd_mac.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)