| Message ID | 1309315854-10359-1-git-send-email-vapier@gentoo.org |
|---|---|
| State | Rejected |
| Delegated to: | Wolfgang Denk |
| Headers | show |
Dear Mike Frysinger, In message <1309315854-10359-1-git-send-email-vapier@gentoo.org> you wrote: > The following changes since commit b1af6f532e0d348b153d5c148369229d24af361a: > > Prepare v2011.06 (2011-06-27 22:22:42 +0200) > > are available in the git repository at: > git://www.denx.de/git/u-boot-blackfin.git master NAK, as before. Best regards, Wolfgang Denk
On Wed, Jun 29, 2011 at 17:23, Wolfgang Denk wrote: > Mike Frysinger wrote: >> The following changes since commit b1af6f532e0d348b153d5c148369229d24af361a: >> >> Prepare v2011.06 (2011-06-27 22:22:42 +0200) >> >> are available in the git repository at: >> git://www.denx.de/git/u-boot-blackfin.git master > > NAK, as before. i sent out the pull request immediately for this tree because your latency tends to be high (and if there was any problems with the patches, i'd get them fixed and updated the request), and this is how i'm used to doing things with linux. the trees are ready before the merge window opens, not during. seems u-boot is more of a "do the development/review during the merge window, and then merge during/after". i did not realize that. -mike
Dear Mike Frysinger, In message <BANLkTimLUUBsrYg3jTgStP55UFQN-O4DyQ@mail.gmail.com> you wrote: > > i sent out the pull request immediately for this tree because your > latency tends to be high (and if there was any problems with the > patches, i'd get them fixed and updated the request), and this is how > i'm used to doing things with linux. the trees are ready before the > merge window opens, not during. seems u-boot is more of a "do the > development/review during the merge window, and then merge > during/after". i did not realize that. Review is supposed to happen between the time the patches get posted on the mailing list, and the time they get accepted and applied by a custodian. Posting a ptach and a pull request for a branch which includes it at the same time leaves no time for review. Don't repeat that you posted unchanged stuff. We cannot know this - there was no indication in the patches what was changed to their earlier versions, there was not even an indication like proper In-reply-to: or References: headers pointing to the earlier posts. This reposting of unchanged stuff is stupid and counter-productive. Don't do it. I will NAK any such reposts, and any pull requests that include them. Thanks. Wolfgang Denk
The following changes since commit b1af6f532e0d348b153d5c148369229d24af361a: Prepare v2011.06 (2011-06-27 22:22:42 +0200) are available in the git repository at: git://www.denx.de/git/u-boot-blackfin.git master Harald Krapfenbauer (2): Blackfin: cm-bf537e/cm-bf537u/tcm-bf537: update network settings Blackfin: cm-bf537e/cm-bf537u/tcm-bf537: enable mmc_spi support Mike Frysinger (16): Blackfin: uart: move debug buffers into local bss Blackfin: uart: add multiple serial support Blackfin: adi boards: enable multi serial support by default Blackfin: dont reset SWRST on newer bf526 parts Blackfin: add init.elf helper code Blackfin: uart: fix printf warning Blackfin: post: setup default CONFIG_SYS_POST_WORD_ADDR Blackfin: gpio: optimize free path a little Blackfin: sync MMR read/write helpers with Linux Blackfin: portmux: allow header to be included in assembly files Blackfin: drop unused dma.h header from start code Blackfin: adi boards: enable pretty flash progress output Blackfin: split out async setup Blackfin: serial: convert to bfin_{read,write} helpers Blackfin: update anomaly lists to latest public info Blackfin: adi boards: also set stderr to nc with helper Makefile | 3 +- arch/blackfin/cpu/.gitignore | 3 + arch/blackfin/cpu/Makefile | 7 +- arch/blackfin/cpu/cpu.c | 16 +- arch/blackfin/cpu/gpio.c | 2 + arch/blackfin/cpu/init.S | 9 + arch/blackfin/cpu/init.lds.S | 25 +++ arch/blackfin/cpu/initcode.c | 61 ++----- arch/blackfin/cpu/initcode.h | 71 +++++++ arch/blackfin/cpu/reset.c | 4 +- arch/blackfin/cpu/serial.c | 234 ++++++++++++++++++------ arch/blackfin/cpu/serial.h | 60 ++++-- arch/blackfin/cpu/start.S | 1 - arch/blackfin/include/asm/blackfin_local.h | 88 +++++----- arch/blackfin/include/asm/config.h | 3 + arch/blackfin/include/asm/gpio.h | 3 +- arch/blackfin/include/asm/mach-bf506/anomaly.h | 25 ++- arch/blackfin/include/asm/mach-bf518/anomaly.h | 28 ++- arch/blackfin/include/asm/mach-bf527/anomaly.h | 38 +++-- arch/blackfin/include/asm/mach-bf533/anomaly.h | 23 ++- arch/blackfin/include/asm/mach-bf537/anomaly.h | 37 +++-- arch/blackfin/include/asm/mach-bf538/anomaly.h | 42 +++-- arch/blackfin/include/asm/mach-bf548/anomaly.h | 227 +++++++++++++---------- arch/blackfin/include/asm/mach-bf561/anomaly.h | 136 ++++++++------ arch/blackfin/include/asm/portmux.h | 4 + arch/blackfin/lib/board.c | 4 + board/cm-bf537e/cm-bf537e.c | 34 +++-- board/cm-bf537u/cm-bf537u.c | 39 ++-- board/tcm-bf537/tcm-bf537.c | 34 +++-- common/serial.c | 3 + include/configs/bf537-stamp.h | 1 - include/configs/bfin_adi_common.h | 12 +- include/configs/cm-bf537e.h | 20 ++- include/configs/cm-bf537u.h | 24 ++- include/configs/tcm-bf537.h | 20 ++- include/serial.h | 9 + 36 files changed, 896 insertions(+), 454 deletions(-) create mode 100644 arch/blackfin/cpu/init.S create mode 100644 arch/blackfin/cpu/init.lds.S create mode 100644 arch/blackfin/cpu/initcode.h