diff mbox

[U-Boot,1/3] omap3evm: eth: split function setup_net_chip

Message ID 1308770649-3802-2-git-send-email-premi@ti.com
State Accepted
Commit 6921b314a855b3c4856ef5ef83315fe945de98b2
Headers show

Commit Message

Sanjeev Premi June 22, 2011, 7:24 p.m. UTC 
In current implementation, the function sets up the ethernet
chip and resets it. The steps to reset depend upon the board
revision.

The patch moves the reset actions to new function reset_net_chip().

Signed-off-by: Sanjeev Premi <premi@ti.com>
---
 board/ti/evm/evm.c |   12 +++++++++++-
 board/ti/evm/evm.h |    1 +
 2 files changed, 12 insertions(+), 1 deletions(-)

Comments

Wolfgang Denk July 28, 2011, 1:29 p.m. UTC | #1 
Dear Sanjeev Premi,

In message <1308770649-3802-2-git-send-email-premi@ti.com> you wrote:
> In current implementation, the function sets up the ethernet
> chip and resets it. The steps to reset depend upon the board
> revision.
> 
> The patch moves the reset actions to new function reset_net_chip().

Your patch does not add any such new function, so it will result in
compile errors?

Best regards,

Wolfgang Denk
diff mbox

Patch

diff --git a/board/ti/evm/evm.c b/board/ti/evm/evm.c
index aaf3033..8f9f141 100644
--- a/board/ti/evm/evm.c
+++ b/board/ti/evm/evm.c
@@ -130,6 +130,9 @@  int misc_init_r(void)
 #endif
 	omap3_evm_get_revision();
 
+#if defined(CONFIG_CMD_NET)
+	reset_net_chip();
+#endif
 	dieid_num_r();
 
 	return 0;
@@ -153,7 +156,6 @@  void set_muxconf_regs(void)
  */
 static void setup_net_chip(void)
 {
-	struct gpio *gpio3_base = (struct gpio *)OMAP34XX_GPIO3_BASE;
 	struct ctrl *ctrl_base = (struct ctrl *)OMAP34XX_CTRL_BASE;
 
 	/* Configure GPMC registers */
@@ -172,6 +174,14 @@  static void setup_net_chip(void)
 	/* Enable off mode for ALE in PADCONF_GPMC_NADV_ALE register */
 	writew(readw(&ctrl_base->gpmc_nadv_ale) | 0x0E00,
 		&ctrl_base->gpmc_nadv_ale);
+}
+
+/**
+ * Reset the ethernet chip.
+ */
+static void reset_net_chip(void)
+{
+	struct gpio *gpio3_base = (struct gpio *)OMAP34XX_GPIO3_BASE;
 
 	/* Make GPIO 64 as output pin */
 	writel(readl(&gpio3_base->oe) & ~(GPIO0), &gpio3_base->oe);
diff --git a/board/ti/evm/evm.h b/board/ti/evm/evm.h
index b721ad6..623cf1b 100644
--- a/board/ti/evm/evm.h
+++ b/board/ti/evm/evm.h
@@ -49,6 +49,7 @@  u32 get_omap3_evm_rev(void);
 
 #if defined(CONFIG_CMD_NET)
 static void setup_net_chip(void);
+static void reset_net_chip(void);
 #endif
 
 /*