Message ID | 1307443544-10169-3-git-send-email-holger.brunck@keymile.com |
---|---|
State | Superseded |
Headers | show |
> -----Original Message----- > From: Holger Brunck [mailto:holger.brunck@keymile.com] > Sent: Tuesday, June 07, 2011 4:16 PM > To: u-boot@lists.denx.de > Cc: Valentin Longchamp; Holger Brunck; Prafulla Wadaskar; Heiko Schocher > Subject: [PATCH 2/6] arm/km: add support for portl2 board Can you add this board support after this patch series or last patch in this series? Regards.. Prafulla . .
Hi Prafulla, On 06/08/2011 10:35 AM, Prafulla Wadaskar wrote: >> Subject: [PATCH 2/6] arm/km: add support for portl2 board > > Can you add this board support after this patch series or last patch in this series? > hm, 3/6 and 5/6 has dependencies to the portl2 support patch, but I think I can handle this. So I will prepare an update serie 1/5 and a single patch for the portl2 support ok? But only for my curiosity, what the reason for this need? Best regards Holger Brunck
> -----Original Message----- > From: Holger Brunck [mailto:holger.brunck@keymile.com] > Sent: Wednesday, June 08, 2011 2:36 PM > To: Prafulla Wadaskar > Cc: u-boot@lists.denx.de; Valentin Longchamp; Heiko Schocher > Subject: Re: [PATCH 2/6] arm/km: add support for portl2 board > > Hi Prafulla, > > On 06/08/2011 10:35 AM, Prafulla Wadaskar wrote: > >> Subject: [PATCH 2/6] arm/km: add support for portl2 board > > > > Can you add this board support after this patch series or last patch > in this series? > > > > hm, 3/6 and 5/6 has dependencies to the portl2 support patch, but I > think I can > handle this. So I will prepare an update serie 1/5 and a single patch > for the > portl2 support ok? But only for my curiosity, what the reason for this > need? > :-) To me a patch series looks like updates/corrections to the existing code. Whereas new board support is addition, should be on the top of it. So let's keep them separate for better understanding. Regards.. Prafulla . .
Hi Prafulla, >> On 06/08/2011 10:35 AM, Prafulla Wadaskar wrote: >>>> Subject: [PATCH 2/6] arm/km: add support for portl2 board >>> >>> Can you add this board support after this patch series or last patch >> in this series? >>> >> >> hm, 3/6 and 5/6 has dependencies to the portl2 support patch, but I >> think I can >> handle this. So I will prepare an update serie 1/5 and a single patch >> for the >> portl2 support ok? But only for my curiosity, what the reason for this >> need? >> > > :-) > To me a patch series looks like updates/corrections to the existing code. > Whereas new board support is addition, should be on the top of it. > So let's keep them separate for better understanding. > yes but in this case the board support patch will not work separated from the updates. You won't be able to commit the single board support patch before comitting the updates, so logically they belong together. Therefore I think it is the best if I follow your first advice and place the board support patch at the end of the serie. Best regards Holger
> -----Original Message----- > From: Holger Brunck [mailto:holger.brunck@keymile.com] > Sent: Wednesday, June 08, 2011 4:06 PM > To: Prafulla Wadaskar > Cc: u-boot@lists.denx.de; Valentin Longchamp; Heiko Schocher > Subject: Re: [PATCH 2/6] arm/km: add support for portl2 board > > Hi Prafulla, > > >> On 06/08/2011 10:35 AM, Prafulla Wadaskar wrote: > >>>> Subject: [PATCH 2/6] arm/km: add support for portl2 board > >>> > >>> Can you add this board support after this patch series or last patch > >> in this series? > >>> > >> > >> hm, 3/6 and 5/6 has dependencies to the portl2 support patch, but I > >> think I can > >> handle this. So I will prepare an update serie 1/5 and a single patch > >> for the > >> portl2 support ok? But only for my curiosity, what the reason for > this > >> need? > >> > > > > :-) > > To me a patch series looks like updates/corrections to the existing > code. > > Whereas new board support is addition, should be on the top of it. > > So let's keep them separate for better understanding. > > > > yes but in this case the board support patch will not work separated > from the > updates. You won't be able to commit the single board support patch > before > comitting the updates, so logically they belong together. Therefore I > think it > is the best if I follow your first advice and place the board support > patch at > the end of the serie. Sure.. Regards.. Prafulla . .
diff --git a/MAINTAINERS b/MAINTAINERS index c462ae2..c93a858 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -726,6 +726,10 @@ Sergey Lapin <slapin@ossfans.org> afeb9260 ARM926EJS (AT91SAM9260 SoC) +Valentine Longchamp <valentin.longchamp@keymile.com> + + portl2 ARM926EJS (Kirkwood SoC) + Nishanth Menon <nm@ti.com> omap3_sdp3430 ARM ARMV7 (OMAP3xx SoC) diff --git a/MAKEALL b/MAKEALL index d592374..240ca35 100755 --- a/MAKEALL +++ b/MAKEALL @@ -363,6 +363,7 @@ LIST_ARM9=" \ openrd_base \ openrd_client \ openrd_ultimate \ + portl2 \ rd6281a \ sbc2410x \ scb9328 \ diff --git a/boards.cfg b/boards.cfg index d2cacc8..b21b047 100644 --- a/boards.cfg +++ b/boards.cfg @@ -109,6 +109,7 @@ davinci_sonata arm arm926ejs sonata davinci suen3 arm arm926ejs km_arm keymile kirkwood suen8 arm arm926ejs km_arm keymile kirkwood mgcoge3un arm arm926ejs km_arm keymile kirkwood +portl2 arm arm926ejs km_arm keymile kirkwood guruplug arm arm926ejs - Marvell kirkwood mv88f6281gtw_ge arm arm926ejs - Marvell kirkwood openrd_base arm arm926ejs openrd Marvell kirkwood openrd:BOARD_IS_OPENRD_BASE diff --git a/include/configs/portl2.h b/include/configs/portl2.h new file mode 100644 index 0000000..10ce7c8 --- /dev/null +++ b/include/configs/portl2.h @@ -0,0 +1,76 @@ +/* + * (C) Copyright 2009 + * Marvell Semiconductor <www.marvell.com> + * Prafulla Wadaskar <prafulla@marvell.com> + * + * (C) Copyright 2009 + * Stefan Roese, DENX Software Engineering, sr@denx.de. + * + * (C) Copyright 2010-2011 + * Holger Brunck, Keymile GmbH Hannover, holger.brunck@keymile.com. + * Valentin Longchamp, Keymile AG Bern, valentin.longchamp@keymile.com + * + * See file CREDITS for list of people who contributed to this + * project. + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; either version 2 of + * the License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, + * MA 02110-1301 USA + */ + +/* for linking errors see + * http://lists.denx.de/pipermail/u-boot/2009-July/057350.html */ + +#ifndef _CONFIG_PORTL2_H +#define _CONFIG_PORTL2_H + +/* include common defines/options for all arm based Keymile boards */ +#include "km/km_arm.h" + +/* + * Version number information + */ +#define CONFIG_IDENT_STRING "\nKeymile Port-L2" +#define CONFIG_HOSTNAME portl2 +#define CONFIG_PORTL2 + +#define KM_IVM_BUS "pca9544a:70:9" /* I2C2 (Mux-Port 1)*/ +#define KM_ENV_BUS "pca9544a:70:a" /* I2C2 (Mux-Port 2)*/ + +/* + * portl2 has a fixed link to the XMPP backplane + * with 100MB full duplex and autoneg off, for this + * reason we have to change the default settings + */ +#define PORT_SERIAL_CONTROL_VALUE ( \ + MVGBE_FORCE_LINK_PASS | \ + MVGBE_DIS_AUTO_NEG_FOR_DUPLX | \ + MVGBE_DIS_AUTO_NEG_FOR_FLOW_CTRL | \ + MVGBE_ADV_NO_FLOW_CTRL | \ + MVGBE_FORCE_FC_MODE_NO_PAUSE_DIS_TX | \ + MVGBE_FORCE_BP_MODE_NO_JAM | \ + (1 << 9) /* Reserved bit has to be 1 */ | \ + MVGBE_DO_NOT_FORCE_LINK_FAIL | \ + MVGBE_DIS_AUTO_NEG_SPEED_GMII | \ + MVGBE_DTE_ADV_0 | \ + MVGBE_MIIPHY_MAC_MODE | \ + MVGBE_AUTO_NEG_NO_CHANGE | \ + MVGBE_MAX_RX_PACKET_1552BYTE | \ + MVGBE_CLR_EXT_LOOPBACK | \ + MVGBE_SET_FULL_DUPLEX_MODE | \ + MVGBE_DIS_FLOW_CTRL_TX_RX_IN_FULL_DUPLEX |\ + MVGBE_SET_GMII_SPEED_TO_10_100 |\ + MVGBE_SET_MII_SPEED_TO_100) + +#endif /* _CONFIG_PORTL2_H */