diff mbox

[U-Boot,v2,8/8] net/net.c: cosmetic: do not use assignment in if condition

Message ID 1305122401-14967-9-git-send-email-luca.ceresoli@comelit.it
State Accepted
Headers show

Commit Message

Luca Ceresoli May 11, 2011, 2 p.m. UTC
This removes the following checkpatch issue:
 - ERROR: do not use assignment in if condition

Signed-off-by: Luca Ceresoli <luca.ceresoli@comelit.it>
Cc: Wolfgang Denk <wd@denx.de>
Cc: Ben Warren <biggerbadderben@gmail.com>
Cc: Mike Frysinger <vapier@gentoo.org>

---
Changes since v1: none.

 net/net.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

Comments

Wolfgang Denk May 12, 2011, 8:18 p.m. UTC | #1
Dear Luca Ceresoli,

In message <1305122401-14967-9-git-send-email-luca.ceresoli@comelit.it> you wrote:
> This removes the following checkpatch issue:
>  - ERROR: do not use assignment in if condition
> 
> Signed-off-by: Luca Ceresoli <luca.ceresoli@comelit.it>
> Cc: Wolfgang Denk <wd@denx.de>
> Cc: Ben Warren <biggerbadderben@gmail.com>
> Cc: Mike Frysinger <vapier@gentoo.org>
> 
> ---
> Changes since v1: none.
> 
>  net/net.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk
diff mbox

Patch

diff --git a/net/net.c b/net/net.c
index 8b4d28e..1c4c982 100644
--- a/net/net.c
+++ b/net/net.c
@@ -1614,7 +1614,8 @@  NetReceive(volatile uchar *inpkt, int len)
 		 * a fragment, and either the complete packet or NULL if
 		 * it is a fragment (if !CONFIG_IP_DEFRAG, it returns NULL)
 		 */
-		if (!(ip = NetDefragment(ip, &len)))
+		ip = NetDefragment(ip, &len);
+		if (!ip)
 			return;
 		/*
 		 * watch for ICMP host redirects