diff mbox

[U-Boot,5/6] netconsole: remove `serverip' check

Message ID 1304262244-13788-6-git-send-email-simon.guinot@sequanux.org
State Changes Requested
Headers show

Commit Message

Simon Guinot May 1, 2011, 3:04 p.m. UTC 
From: Simon Guinot <sguinot@lacie.com>

Netconsole use the environment variable `ncip' to configure the
destination IP. `serverip' don't need to be defined.

Signed-off-by: Simon Guinot <sguinot@lacie.com>
---
 net/net.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

Comments

Wolfgang Denk May 1, 2011, 3:19 p.m. UTC | #1 
Dear Simon Guinot,

In message <1304262244-13788-6-git-send-email-simon.guinot@sequanux.org> you wrote:
> From: Simon Guinot <sguinot@lacie.com>
> 
> Netconsole use the environment variable `ncip' to configure the
> destination IP. `serverip' don't need to be defined.
> 
> Signed-off-by: Simon Guinot <sguinot@lacie.com>
> ---
>  net/net.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/net/net.c b/net/net.c
> index e50bdf1..63b4201 100644
> --- a/net/net.c
> +++ b/net/net.c
> @@ -1718,7 +1718,6 @@ static int net_check_prereq (proto_t protocol)
>  #if defined(CONFIG_CMD_NFS)
>  	case NFS:
>  #endif
> -	case NETCONS:
>  	case TFTP:
>  		if (NetServerIP == 0) {
>  			puts ("*** ERROR: `serverip' not set\n");

NAK, as this change would also disable the test if NetOurIP == 0,
i. e. if our own IP address is set.

Best regards,

Wolfgang Denk
diff mbox

Patch

diff --git a/net/net.c b/net/net.c
index e50bdf1..63b4201 100644
--- a/net/net.c
+++ b/net/net.c
@@ -1718,7 +1718,6 @@  static int net_check_prereq (proto_t protocol)
 #if defined(CONFIG_CMD_NFS)
 	case NFS:
 #endif
-	case NETCONS:
 	case TFTP:
 		if (NetServerIP == 0) {
 			puts ("*** ERROR: `serverip' not set\n");