diff mbox

[U-Boot,4/6] mv-common.h: fix DRAM banks configuration

Message ID 1304262244-13788-5-git-send-email-simon.guinot@sequanux.org
State Changes Requested
Headers show

Commit Message

Simon Guinot May 1, 2011, 3:04 p.m. UTC 
From: Simon Guinot <sguinot@lacie.com>

The asm/arch/config.h header define CONFIG_NR_DRAM_BANKS_MAX, which is
needed to configure DRAM banks.

This patch move the asm/arch/config.h header inclusion above the DRAM
banks configuration.

Signed-off-by: Simon Guinot <sguinot@lacie.com>
---
 include/configs/mv-common.h |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

Comments

Eric Cooper May 1, 2011, 4:11 p.m. UTC | #1 
On Sun, May 01, 2011 at 05:04:02PM +0200, Simon Guinot wrote:
> --- a/include/configs/mv-common.h
> +++ b/include/configs/mv-common.h
> @@ -113,6 +113,9 @@
>  #define CONFIG_SYS_RESET_ADDRESS 0xffff0000	/* Rst Vector Adr */
>  #define CONFIG_SYS_MAXARGS	16	/* max number of command args */
>  
> +/* ====> Include platform Common Definations */
> +#include <asm/arch/config.h>
> +
>  /*
>   * DRAM Banks configuration, Custom config can be done in <board>.h
>   */
> @@ -124,9 +127,6 @@
>  #endif
>  #endif /* CONFIG_NR_DRAM_BANKS */
>  
> -/* ====> Include platform Common Definations */
> -#include <asm/arch/config.h>
> -
>  /* ====> Include driver Common Definations */
>  /*
>   * Common NAND configuration
> -- 
> 1.6.3.1

You didn't fix the "Definations" typos in this one.
Simon Guinot May 1, 2011, 9:38 p.m. UTC | #2 
Hi Eric,

On Sun, May 01, 2011 at 12:11:13PM -0400, Eric Cooper wrote:
> On Sun, May 01, 2011 at 05:04:02PM +0200, Simon Guinot wrote:
> > --- a/include/configs/mv-common.h
> > +++ b/include/configs/mv-common.h
> > @@ -113,6 +113,9 @@
> >  #define CONFIG_SYS_RESET_ADDRESS 0xffff0000	/* Rst Vector Adr */
> >  #define CONFIG_SYS_MAXARGS	16	/* max number of command args */
> >  
> > +/* ====> Include platform Common Definations */
> > +#include <asm/arch/config.h>
> > +
> >  /*
> >   * DRAM Banks configuration, Custom config can be done in <board>.h
> >   */
> > @@ -124,9 +127,6 @@
> >  #endif
> >  #endif /* CONFIG_NR_DRAM_BANKS */
> >  
> > -/* ====> Include platform Common Definations */
> > -#include <asm/arch/config.h>
> > -
> >  /* ====> Include driver Common Definations */
> >  /*
> >   * Common NAND configuration
> > -- 
> > 1.6.3.1
> 
> You didn't fix the "Definations" typos in this one.

Sorry, I missed your reply. I will add this fix into the v3.

Thanks,

Simon
diff mbox

Patch

diff --git a/include/configs/mv-common.h b/include/configs/mv-common.h
index a8937dd..e8f2da0 100644
--- a/include/configs/mv-common.h
+++ b/include/configs/mv-common.h
@@ -113,6 +113,9 @@ 
 #define CONFIG_SYS_RESET_ADDRESS 0xffff0000	/* Rst Vector Adr */
 #define CONFIG_SYS_MAXARGS	16	/* max number of command args */
 
+/* ====> Include platform Common Definations */
+#include <asm/arch/config.h>
+
 /*
  * DRAM Banks configuration, Custom config can be done in <board>.h
  */
@@ -124,9 +127,6 @@ 
 #endif
 #endif /* CONFIG_NR_DRAM_BANKS */
 
-/* ====> Include platform Common Definations */
-#include <asm/arch/config.h>
-
 /* ====> Include driver Common Definations */
 /*
  * Common NAND configuration