From patchwork Tue Oct 19 05:03:45 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nobuhiro Iwamatsu X-Patchwork-Id: 71879 Return-Path: X-Original-To: wd@gemini.denx.de Delivered-To: wd@gemini.denx.de Received: from diddl.denx.de (diddl.denx.de [10.0.0.6]) by gemini.denx.de (Postfix) with ESMTP id 3B64E136322 for ; Tue, 19 Oct 2010 07:03:17 +0200 (CEST) Received: from diddl.denx.de (localhost.localdomain [127.0.0.1]) by diddl.denx.de (Postfix) with ESMTP id 25D29348C9D1 for ; Tue, 19 Oct 2010 07:03:17 +0200 (CEST) Received: from pop.mnet-online.de by diddl.denx.de with POP3 (fetchmail-6.3.17) for (single-drop); Tue, 19 Oct 2010 07:03:17 +0200 (CEST) Received: from murder ([192.168.8.180]) by backend2 (Cyrus v2.2.12) with LMTPA; Tue, 19 Oct 2010 07:02:10 +0200 X-Sieve: CMU Sieve 2.2 Received: from mail.m-online.net (localhost [127.0.0.1]) by frontend1.mail.m-online.net (Cyrus v2.2.12) with LMTPA; Tue, 19 Oct 2010 07:02:10 +0200 Received: from scanner-2.m-online.net (scanner-2.mail.m-online.net [192.168.8.166]) by mail.m-online.net (Postfix) with ESMTP id 7AF021C0020B; Tue, 19 Oct 2010 07:02:10 +0200 (CEST) Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by mxin-1.m-online.net (Postfix) with ESMTP id 65FE746C0A0; Tue, 19 Oct 2010 07:02:07 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id DADCD280E2; Tue, 19 Oct 2010 07:01:04 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8nNfYM9VMdq3; Tue, 19 Oct 2010 07:01:04 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 6CC5128108; Tue, 19 Oct 2010 07:00:33 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 41BC828093 for ; Tue, 19 Oct 2010 07:00:12 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QHsYSQhSp+Nh for ; Tue, 19 Oct 2010 07:00:10 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-pz0-f44.google.com (mail-pz0-f44.google.com [209.85.210.44]) by theia.denx.de (Postfix) with ESMTP id 321992809B for ; Tue, 19 Oct 2010 07:00:06 +0200 (CEST) Received: by pzk32 with SMTP id 32so383873pzk.3 for ; Mon, 18 Oct 2010 22:00:06 -0700 (PDT) Received: by 10.142.180.4 with SMTP id c4mr4235369wff.146.1287464406221; Mon, 18 Oct 2010 22:00:06 -0700 (PDT) Received: from chimagu (49.14.32.202.bf.2iij.net [202.32.14.49]) by mx.google.com with ESMTPS id t38sm24349249wfc.9.2010.10.18.22.00.03 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 18 Oct 2010 22:00:05 -0700 (PDT) Received: from iwamatsu by chimagu with local (Exim 4.72) (envelope-from ) id 1P84Mc-0003DH-Qy; Tue, 19 Oct 2010 14:03:54 +0900 From: Nobuhiro Iwamatsu To: u-boot@lists.denx.de Date: Tue, 19 Oct 2010 14:03:45 +0900 Message-Id: <1287464627-12302-8-git-send-email-iwamatsu@nigauri.org> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1287464627-12302-1-git-send-email-iwamatsu@nigauri.org> References: <1287464627-12302-1-git-send-email-iwamatsu@nigauri.org> Cc: biggerbadderben@gmail.com Subject: [U-Boot] [PATCH 08/10 v2] net: pcnet: Add initialized eth_device structure X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.9 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de X-Virus-Scanned: by amavisd-new at m-online.net pcnet driver does not have write_hwaddr function. However, eth stuff executes write_hwaddr function because eth_device structure has not been initialized. Signed-off-by: Nobuhiro Iwamatsu CC: Ben Warren --- drivers/net/pcnet.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/net/pcnet.c b/drivers/net/pcnet.c index 99b6942..e994cb6 100644 --- a/drivers/net/pcnet.c +++ b/drivers/net/pcnet.c @@ -187,6 +187,11 @@ int pcnet_initialize (bd_t * bis) * Allocate and pre-fill the device structure. */ dev = (struct eth_device *) malloc (sizeof *dev); + if (!dev) { + printf("pcnet: Can not allocate memory\n"); + break; + } + memset(dev, 0, sizeof(*dev)); dev->priv = (void *) devbusfn; sprintf (dev->name, "pcnet#%d", dev_nr);