From patchwork Tue Oct 19 05:03:39 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nobuhiro Iwamatsu X-Patchwork-Id: 71873 Return-Path: X-Original-To: wd@gemini.denx.de Delivered-To: wd@gemini.denx.de Received: from diddl.denx.de (diddl.denx.de [10.0.0.6]) by gemini.denx.de (Postfix) with ESMTP id 10A45136322 for ; Tue, 19 Oct 2010 07:03:16 +0200 (CEST) Received: from diddl.denx.de (localhost.localdomain [127.0.0.1]) by diddl.denx.de (Postfix) with ESMTP id F091F348C9D2 for ; Tue, 19 Oct 2010 07:03:15 +0200 (CEST) Received: from pop.mnet-online.de by diddl.denx.de with POP3 (fetchmail-6.3.17) for (single-drop); Tue, 19 Oct 2010 07:03:15 +0200 (CEST) Received: from murder ([192.168.8.180]) by backend2 (Cyrus v2.2.12) with LMTPA; Tue, 19 Oct 2010 07:01:06 +0200 X-Sieve: CMU Sieve 2.2 Received: from mail.m-online.net (localhost [127.0.0.1]) by frontend1.mail.m-online.net (Cyrus v2.2.12) with LMTPA; Tue, 19 Oct 2010 07:01:06 +0200 Received: from scanner-1.m-online.net (scanner-1.mail.m-online.net [192.168.8.165]) by mail.m-online.net (Postfix) with ESMTP id 977BC1C0020B; Tue, 19 Oct 2010 07:01:06 +0200 (CEST) Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by mxin-1.m-online.net (Postfix) with ESMTP id 0226C46C0A6; Tue, 19 Oct 2010 07:01:03 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 21B5C280B6; Tue, 19 Oct 2010 07:00:40 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1b3N2TBtrodH; Tue, 19 Oct 2010 07:00:39 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 0461428093; Tue, 19 Oct 2010 07:00:14 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id E24E82807E for ; Tue, 19 Oct 2010 07:00:06 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MeBjAVbpQ2E3 for ; Tue, 19 Oct 2010 07:00:06 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-px0-f172.google.com (mail-px0-f172.google.com [209.85.212.172]) by theia.denx.de (Postfix) with ESMTP id 0488728083 for ; Tue, 19 Oct 2010 07:00:02 +0200 (CEST) Received: by pxi9 with SMTP id 9so99223pxi.3 for ; Mon, 18 Oct 2010 22:00:02 -0700 (PDT) Received: by 10.142.133.21 with SMTP id g21mr4241758wfd.163.1287464402012; Mon, 18 Oct 2010 22:00:02 -0700 (PDT) Received: from chimagu (49.14.32.202.bf.2iij.net [202.32.14.49]) by mx.google.com with ESMTPS id w22sm8776681wfd.7.2010.10.18.22.00.00 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 18 Oct 2010 22:00:01 -0700 (PDT) Received: from iwamatsu by chimagu with local (Exim 4.72) (envelope-from ) id 1P84MZ-0003Cy-4d; Tue, 19 Oct 2010 14:03:51 +0900 From: Nobuhiro Iwamatsu To: u-boot@lists.denx.de Date: Tue, 19 Oct 2010 14:03:39 +0900 Message-Id: <1287464627-12302-2-git-send-email-iwamatsu@nigauri.org> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1287464627-12302-1-git-send-email-iwamatsu@nigauri.org> References: <1287464627-12302-1-git-send-email-iwamatsu@nigauri.org> Cc: biggerbadderben@gmail.com Subject: [U-Boot] [PATCH 02/10 v2] net: rtl8139: Add initialized eth_device structure X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.9 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de X-Virus-Scanned: by amavisd-new at m-online.net rtl8139 driver does not have write_hwaddr function. However, eth stuff executes write_hwaddr function because eth_device structure has not been initialized. Signed-off-by: Nobuhiro Iwamatsu CC: Ben Warren --- drivers/net/rtl8139.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/net/rtl8139.c b/drivers/net/rtl8139.c index db8a727..c2779db 100644 --- a/drivers/net/rtl8139.c +++ b/drivers/net/rtl8139.c @@ -220,6 +220,11 @@ int rtl8139_initialize(bd_t *bis) debug ("rtl8139: REALTEK RTL8139 @0x%x\n", iobase); dev = (struct eth_device *)malloc(sizeof *dev); + if (!dev) { + printf("Can not allocate memory of rtl8139\n"); + break; + } + memset(dev, 0, sizeof(*dev)); sprintf (dev->name, "RTL8139#%d", card_number);