| Message ID | 0e236c3a6514a2a633ef3a5b71a967c46f7fbae7.1634303007.git.michal.simek@xilinx.com |
|---|---|
| State | Accepted |
| Commit | eafdcda4a854932c0319656de7bf3f017f17ae67 |
| Delegated to: | Michal Simek |
| Headers | show |
| Series | net: gem: Disable broadcast setting | expand |
On Fri, Oct 15, 2021 at 4:03 PM Michal Simek <michal.simek@xilinx.com> wrote: > > There is no need for GEM to accepts broadcast packets because they are not > handled by u-boot anyway. That's why use HW IP feature and don't waste time > on these packats which will be dropped anyway. > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > > drivers/net/zynq_gem.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/zynq_gem.c b/drivers/net/zynq_gem.c > index ff599822673c..c309c3c95499 100644 > --- a/drivers/net/zynq_gem.c > +++ b/drivers/net/zynq_gem.c > @@ -60,6 +60,7 @@ > #define ZYNQ_GEM_NWCFG_SPEED100 0x00000001 /* 100 Mbps operation */ > #define ZYNQ_GEM_NWCFG_SPEED1000 0x00000400 /* 1Gbps operation */ > #define ZYNQ_GEM_NWCFG_FDEN 0x00000002 /* Full Duplex mode */ > +#define ZYNQ_GEM_NWCFG_NO_BRDC BIT(5) /* No broadcast */ > #define ZYNQ_GEM_NWCFG_FSREM 0x00020000 /* FCS removal */ > #define ZYNQ_GEM_NWCFG_SGMII_ENBL 0x08000000 /* SGMII Enable */ > #define ZYNQ_GEM_NWCFG_PCS_SEL 0x00000800 /* PCS select */ > @@ -77,6 +78,7 @@ > > #define ZYNQ_GEM_NWCFG_INIT (ZYNQ_GEM_DBUS_WIDTH | \ > ZYNQ_GEM_NWCFG_FDEN | \ > + ZYNQ_GEM_NWCFG_NO_BRDC | \ > ZYNQ_GEM_NWCFG_FSREM | \ > ZYNQ_GEM_NWCFG_MDCCLKDIV) > > -- > 2.33.1 > Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
On 10/15/21 15:03, Michal Simek wrote: > There is no need for GEM to accepts broadcast packets because they are not > handled by u-boot anyway. That's why use HW IP feature and don't waste time > on these packats which will be dropped anyway. > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > > drivers/net/zynq_gem.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/zynq_gem.c b/drivers/net/zynq_gem.c > index ff599822673c..c309c3c95499 100644 > --- a/drivers/net/zynq_gem.c > +++ b/drivers/net/zynq_gem.c > @@ -60,6 +60,7 @@ > #define ZYNQ_GEM_NWCFG_SPEED100 0x00000001 /* 100 Mbps operation */ > #define ZYNQ_GEM_NWCFG_SPEED1000 0x00000400 /* 1Gbps operation */ > #define ZYNQ_GEM_NWCFG_FDEN 0x00000002 /* Full Duplex mode */ > +#define ZYNQ_GEM_NWCFG_NO_BRDC BIT(5) /* No broadcast */ > #define ZYNQ_GEM_NWCFG_FSREM 0x00020000 /* FCS removal */ > #define ZYNQ_GEM_NWCFG_SGMII_ENBL 0x08000000 /* SGMII Enable */ > #define ZYNQ_GEM_NWCFG_PCS_SEL 0x00000800 /* PCS select */ > @@ -77,6 +78,7 @@ > > #define ZYNQ_GEM_NWCFG_INIT (ZYNQ_GEM_DBUS_WIDTH | \ > ZYNQ_GEM_NWCFG_FDEN | \ > + ZYNQ_GEM_NWCFG_NO_BRDC | \ > ZYNQ_GEM_NWCFG_FSREM | \ > ZYNQ_GEM_NWCFG_MDCCLKDIV) > > Applied. M
diff --git a/drivers/net/zynq_gem.c b/drivers/net/zynq_gem.c index ff599822673c..c309c3c95499 100644 --- a/drivers/net/zynq_gem.c +++ b/drivers/net/zynq_gem.c @@ -60,6 +60,7 @@ #define ZYNQ_GEM_NWCFG_SPEED100 0x00000001 /* 100 Mbps operation */ #define ZYNQ_GEM_NWCFG_SPEED1000 0x00000400 /* 1Gbps operation */ #define ZYNQ_GEM_NWCFG_FDEN 0x00000002 /* Full Duplex mode */ +#define ZYNQ_GEM_NWCFG_NO_BRDC BIT(5) /* No broadcast */ #define ZYNQ_GEM_NWCFG_FSREM 0x00020000 /* FCS removal */ #define ZYNQ_GEM_NWCFG_SGMII_ENBL 0x08000000 /* SGMII Enable */ #define ZYNQ_GEM_NWCFG_PCS_SEL 0x00000800 /* PCS select */ @@ -77,6 +78,7 @@ #define ZYNQ_GEM_NWCFG_INIT (ZYNQ_GEM_DBUS_WIDTH | \ ZYNQ_GEM_NWCFG_FDEN | \ + ZYNQ_GEM_NWCFG_NO_BRDC | \ ZYNQ_GEM_NWCFG_FSREM | \ ZYNQ_GEM_NWCFG_MDCCLKDIV)
There is no need for GEM to accepts broadcast packets because they are not handled by u-boot anyway. That's why use HW IP feature and don't waste time on these packats which will be dropped anyway. Signed-off-by: Michal Simek <michal.simek@xilinx.com> --- drivers/net/zynq_gem.c | 2 ++ 1 file changed, 2 insertions(+)