| Message ID | 0b7fcc8bdac04b62ab112b47ed80396e@rwthex-w2-b.rwth-ad.de |
|---|---|
| State | Accepted |
| Commit | 3cc5bbb8e68dc67b7c3d2fdebef69408e5271469 |
| Delegated to: | Tom Rini |
| Headers | show |
Hi Stefan,
With this patch, the image create by genext2fs can be mount in
U-Boot, thanks.
On 12/27/2016 09:35 AM, Stefan Brüns wrote:
> genext2fs creates revision level 0 filesystems, which are not readable
> by u-boot due to the initialized group descriptor size field.
> f798b1dda1c5de818b806189e523d1b75db7e72d
>
> Reported-by: Kever Yang <kever.yang@rock-chips.com>
> Reported-by: FrostyBytes@protonmail.com
> Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de>
> ---
> fs/ext4/ext4_common.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/ext4/ext4_common.c b/fs/ext4/ext4_common.c
> index bfebe7e379..621c61e5c7 100644
> --- a/fs/ext4/ext4_common.c
> +++ b/fs/ext4/ext4_common.c
> @@ -2334,6 +2334,7 @@ int ext4fs_mount(unsigned part_length)
>
> if (le32_to_cpu(data->sblock.revision_level) == 0) {
> fs->inodesz = 128;
> + fs->gdsize = 32;
> } else {
> debug("EXT4 features COMPAT: %08x INCOMPAT: %08x RO_COMPAT: %08x\n",
> __le32_to_cpu(data->sblock.feature_compatibility),
Tested-by: Kever Yang <kever.yang@rock-chips.com>
Thanks,
- Kever
On Dienstag, 27. Dezember 2016 10:44:07 CET Kever Yang wrote: > Hi Stefan, > > With this patch, the image create by genext2fs can be mount in > U-Boot, thanks. Thanks for testing. @Tom: this is probably a candidate for u-boot 2017.01 ... > On 12/27/2016 09:35 AM, Stefan Brüns wrote: > > genext2fs creates revision level 0 filesystems, which are not readable > > by u-boot due to the initialized group descriptor size field. > > f798b1dda1c5de818b806189e523d1b75db7e72d > > > > Reported-by: Kever Yang <kever.yang@rock-chips.com> > > Reported-by: FrostyBytes@protonmail.com > > Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de> > > --- > > > > fs/ext4/ext4_common.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/fs/ext4/ext4_common.c b/fs/ext4/ext4_common.c > > index bfebe7e379..621c61e5c7 100644 > > --- a/fs/ext4/ext4_common.c > > +++ b/fs/ext4/ext4_common.c > > @@ -2334,6 +2334,7 @@ int ext4fs_mount(unsigned part_length) > > > > if (le32_to_cpu(data->sblock.revision_level) == 0) { > > > > fs->inodesz = 128; > > > > + fs->gdsize = 32; > > > > } else { > > > > debug("EXT4 features COMPAT: %08x INCOMPAT: %08x RO_COMPAT: %08x\n", > > > > __le32_to_cpu(data->sblock.feature_compatibility), > > Tested-by: Kever Yang <kever.yang@rock-chips.com> > > Thanks, > - Kever
On Tue, Dec 27, 2016 at 05:15:45PM +0100, Stefan Bruens wrote: > On Dienstag, 27. Dezember 2016 10:44:07 CET Kever Yang wrote: > > Hi Stefan, > > > > With this patch, the image create by genext2fs can be mount in > > U-Boot, thanks. > > Thanks for testing. > > @Tom: this is probably a candidate for u-boot 2017.01 ... Thanks, I'm putting this and some other changes through their paces now. > > > On 12/27/2016 09:35 AM, Stefan Brüns wrote: > > > genext2fs creates revision level 0 filesystems, which are not readable > > > by u-boot due to the initialized group descriptor size field. > > > f798b1dda1c5de818b806189e523d1b75db7e72d > > > > > > Reported-by: Kever Yang <kever.yang@rock-chips.com> > > > Reported-by: FrostyBytes@protonmail.com > > > Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de> > > > --- > > > > > > fs/ext4/ext4_common.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/fs/ext4/ext4_common.c b/fs/ext4/ext4_common.c > > > index bfebe7e379..621c61e5c7 100644 > > > --- a/fs/ext4/ext4_common.c > > > +++ b/fs/ext4/ext4_common.c > > > @@ -2334,6 +2334,7 @@ int ext4fs_mount(unsigned part_length) > > > > > > if (le32_to_cpu(data->sblock.revision_level) == 0) { > > > > > > fs->inodesz = 128; > > > > > > + fs->gdsize = 32; > > > > > > } else { > > > > > > debug("EXT4 features COMPAT: %08x INCOMPAT: %08x RO_COMPAT: %08x\n", > > > > > > __le32_to_cpu(data->sblock.feature_compatibility), > > > > Tested-by: Kever Yang <kever.yang@rock-chips.com> > > > > Thanks, > > - Kever > > > -- > Stefan Brüns / Bergstraße 21 / 52062 Aachen > home: +49 241 53809034 mobile: +49 151 50412019 > work: +49 2405 49936-424
On Tue, Dec 27, 2016 at 02:35:08AM +0100, Stefan Brüns wrote: > genext2fs creates revision level 0 filesystems, which are not readable > by u-boot due to the initialized group descriptor size field. > f798b1dda1c5de818b806189e523d1b75db7e72d > > Reported-by: Kever Yang <kever.yang@rock-chips.com> > Reported-by: FrostyBytes@protonmail.com > Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de> > Tested-by: Kever Yang <kever.yang@rock-chips.com> Applied to u-boot/master, thanks!
diff --git a/fs/ext4/ext4_common.c b/fs/ext4/ext4_common.c index bfebe7e379..621c61e5c7 100644 --- a/fs/ext4/ext4_common.c +++ b/fs/ext4/ext4_common.c @@ -2334,6 +2334,7 @@ int ext4fs_mount(unsigned part_length) if (le32_to_cpu(data->sblock.revision_level) == 0) { fs->inodesz = 128; + fs->gdsize = 32; } else { debug("EXT4 features COMPAT: %08x INCOMPAT: %08x RO_COMPAT: %08x\n", __le32_to_cpu(data->sblock.feature_compatibility),
genext2fs creates revision level 0 filesystems, which are not readable by u-boot due to the initialized group descriptor size field. f798b1dda1c5de818b806189e523d1b75db7e72d Reported-by: Kever Yang <kever.yang@rock-chips.com> Reported-by: FrostyBytes@protonmail.com Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de> --- fs/ext4/ext4_common.c | 1 + 1 file changed, 1 insertion(+)