diff mbox

[U-Boot,v6,3/3] odroid-c2: enable new Meson GX MMC driver in board defconfig

Message ID 000ce33d-cbc9-cfd8-d292-86a15ae62819@gmail.com
State Changes Requested
Delegated to: Jaehoon Chung
Headers show

Commit Message

Heiner Kallweit Feb. 20, 2017, 7:32 p.m. UTC
Enable new Meson GX MMC driver in Odroid C2 defconfig.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
v6:
- no changes
---
 configs/odroid-c2_defconfig | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Jaehoon Chung March 14, 2017, 1 a.m. UTC | #1
Dear Heiner,

On 02/21/2017 04:32 AM, Heiner Kallweit wrote:
> Enable new Meson GX MMC driver in Odroid C2 defconfig.

Could you resend without conflict? Then i will apply it.

Best Regards,
Jaehoon Chung

> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> v6:
> - no changes
> ---
>  configs/odroid-c2_defconfig | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/configs/odroid-c2_defconfig b/configs/odroid-c2_defconfig
> index 62b7627..6de712a 100644
> --- a/configs/odroid-c2_defconfig
> +++ b/configs/odroid-c2_defconfig
> @@ -3,7 +3,9 @@ CONFIG_ARCH_MESON=y
>  CONFIG_MESON_GXBB=y
>  CONFIG_TARGET_ODROID_C2=y
>  CONFIG_IDENT_STRING=" odroid-c2"
> -# CONFIG_MMC is not set
> +CONFIG_MMC=y
> +CONFIG_DM_MMC=y
> +CONFIG_MMC_MESON_GX=y
>  CONFIG_DEFAULT_DEVICE_TREE="meson-gxbb-odroidc2"
>  # CONFIG_DISPLAY_CPUINFO is not set
>  # CONFIG_DISPLAY_BOARDINFO is not set
> @@ -14,6 +16,7 @@ CONFIG_HUSH_PARSER=y
>  # CONFIG_CMD_LOADS is not set
>  # CONFIG_CMD_FPGA is not set
>  # CONFIG_CMD_SETEXPR is not set
> +CONFIG_CMD_MMC=y
>  CONFIG_DOS_PARTITION=y
>  CONFIG_ISO_PARTITION=y
>  CONFIG_EFI_PARTITION=y
>
Heiner Kallweit April 11, 2017, 7:41 p.m. UTC | #2
Am 20.02.2017 um 20:32 schrieb Heiner Kallweit:
> Enable new Meson GX MMC driver in Odroid C2 defconfig.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> v6:
> - no changes
> ---
>  configs/odroid-c2_defconfig | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/configs/odroid-c2_defconfig b/configs/odroid-c2_defconfig
> index 62b7627..6de712a 100644
> --- a/configs/odroid-c2_defconfig
> +++ b/configs/odroid-c2_defconfig
> @@ -3,7 +3,9 @@ CONFIG_ARCH_MESON=y
>  CONFIG_MESON_GXBB=y
>  CONFIG_TARGET_ODROID_C2=y
>  CONFIG_IDENT_STRING=" odroid-c2"
> -# CONFIG_MMC is not set
> +CONFIG_MMC=y
> +CONFIG_DM_MMC=y
> +CONFIG_MMC_MESON_GX=y
>  CONFIG_DEFAULT_DEVICE_TREE="meson-gxbb-odroidc2"
>  # CONFIG_DISPLAY_CPUINFO is not set
>  # CONFIG_DISPLAY_BOARDINFO is not set
> @@ -14,6 +16,7 @@ CONFIG_HUSH_PARSER=y
>  # CONFIG_CMD_LOADS is not set
>  # CONFIG_CMD_FPGA is not set
>  # CONFIG_CMD_SETEXPR is not set
> +CONFIG_CMD_MMC=y
>  CONFIG_DOS_PARTITION=y
>  CONFIG_ISO_PARTITION=y
>  CONFIG_EFI_PARTITION=y
> 
Since then I haven't heard back. Anything else which would need to be changed?

Rgds, Heiner
Jaehoon Chung April 12, 2017, 5:08 a.m. UTC | #3
Dear Heiner,

On 04/12/2017 04:41 AM, Heiner Kallweit wrote:
> Am 20.02.2017 um 20:32 schrieb Heiner Kallweit:
>> Enable new Meson GX MMC driver in Odroid C2 defconfig.
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>> ---
>> v6:
>> - no changes
>> ---
>>  configs/odroid-c2_defconfig | 5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/configs/odroid-c2_defconfig b/configs/odroid-c2_defconfig
>> index 62b7627..6de712a 100644
>> --- a/configs/odroid-c2_defconfig
>> +++ b/configs/odroid-c2_defconfig
>> @@ -3,7 +3,9 @@ CONFIG_ARCH_MESON=y
>>  CONFIG_MESON_GXBB=y
>>  CONFIG_TARGET_ODROID_C2=y
>>  CONFIG_IDENT_STRING=" odroid-c2"
>> -# CONFIG_MMC is not set
>> +CONFIG_MMC=y
>> +CONFIG_DM_MMC=y
>> +CONFIG_MMC_MESON_GX=y
>>  CONFIG_DEFAULT_DEVICE_TREE="meson-gxbb-odroidc2"
>>  # CONFIG_DISPLAY_CPUINFO is not set
>>  # CONFIG_DISPLAY_BOARDINFO is not set
>> @@ -14,6 +16,7 @@ CONFIG_HUSH_PARSER=y
>>  # CONFIG_CMD_LOADS is not set
>>  # CONFIG_CMD_FPGA is not set
>>  # CONFIG_CMD_SETEXPR is not set
>> +CONFIG_CMD_MMC=y
>>  CONFIG_DOS_PARTITION=y
>>  CONFIG_ISO_PARTITION=y
>>  CONFIG_EFI_PARTITION=y
>>
> Since then I haven't heard back. Anything else which would need to be changed?

Maybe, i had sent the email to you..but when you resend the patches, i will pick yours..
When i had applied the patches...it's conflict the latest u-boot..
Sorry for bothering you..if you send the patches, i will apply yours immediately.

Best Regards,
Jaehoon Chung 

> 
> Rgds, Heiner
> 
> 
> 
>
Heiner Kallweit April 12, 2017, 6:34 p.m. UTC | #4
Am 12.04.2017 um 07:08 schrieb Jaehoon Chung:
> Dear Heiner,
> 
> On 04/12/2017 04:41 AM, Heiner Kallweit wrote:
>> Am 20.02.2017 um 20:32 schrieb Heiner Kallweit:
>>> Enable new Meson GX MMC driver in Odroid C2 defconfig.
>>>
>>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>>> ---
>>> v6:
>>> - no changes
>>> ---
>>>  configs/odroid-c2_defconfig | 5 ++++-
>>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/configs/odroid-c2_defconfig b/configs/odroid-c2_defconfig
>>> index 62b7627..6de712a 100644
>>> --- a/configs/odroid-c2_defconfig
>>> +++ b/configs/odroid-c2_defconfig
>>> @@ -3,7 +3,9 @@ CONFIG_ARCH_MESON=y
>>>  CONFIG_MESON_GXBB=y
>>>  CONFIG_TARGET_ODROID_C2=y
>>>  CONFIG_IDENT_STRING=" odroid-c2"
>>> -# CONFIG_MMC is not set
>>> +CONFIG_MMC=y
>>> +CONFIG_DM_MMC=y
>>> +CONFIG_MMC_MESON_GX=y
>>>  CONFIG_DEFAULT_DEVICE_TREE="meson-gxbb-odroidc2"
>>>  # CONFIG_DISPLAY_CPUINFO is not set
>>>  # CONFIG_DISPLAY_BOARDINFO is not set
>>> @@ -14,6 +16,7 @@ CONFIG_HUSH_PARSER=y
>>>  # CONFIG_CMD_LOADS is not set
>>>  # CONFIG_CMD_FPGA is not set
>>>  # CONFIG_CMD_SETEXPR is not set
>>> +CONFIG_CMD_MMC=y
>>>  CONFIG_DOS_PARTITION=y
>>>  CONFIG_ISO_PARTITION=y
>>>  CONFIG_EFI_PARTITION=y
>>>
>> Since then I haven't heard back. Anything else which would need to be changed?
> 
> Maybe, i had sent the email to you..but when you resend the patches, i will pick yours..
> When i had applied the patches...it's conflict the latest u-boot..
> Sorry for bothering you..if you send the patches, i will apply yours immediately.
> 
Yes, due to other recent mmc changes the patch set had to be rebased.
The rebased version works fine on top of latest uboot git version.
I just submitted a rebased v7.

Thanks, Heiner

> Best Regards,
> Jaehoon Chung 
> 
>>
>> Rgds, Heiner
>>
>>
>>
>>
> 
>
diff mbox

Patch

diff --git a/configs/odroid-c2_defconfig b/configs/odroid-c2_defconfig
index 62b7627..6de712a 100644
--- a/configs/odroid-c2_defconfig
+++ b/configs/odroid-c2_defconfig
@@ -3,7 +3,9 @@  CONFIG_ARCH_MESON=y
 CONFIG_MESON_GXBB=y
 CONFIG_TARGET_ODROID_C2=y
 CONFIG_IDENT_STRING=" odroid-c2"
-# CONFIG_MMC is not set
+CONFIG_MMC=y
+CONFIG_DM_MMC=y
+CONFIG_MMC_MESON_GX=y
 CONFIG_DEFAULT_DEVICE_TREE="meson-gxbb-odroidc2"
 # CONFIG_DISPLAY_CPUINFO is not set
 # CONFIG_DISPLAY_BOARDINFO is not set
@@ -14,6 +16,7 @@  CONFIG_HUSH_PARSER=y
 # CONFIG_CMD_LOADS is not set
 # CONFIG_CMD_FPGA is not set
 # CONFIG_CMD_SETEXPR is not set
+CONFIG_CMD_MMC=y
 CONFIG_DOS_PARTITION=y
 CONFIG_ISO_PARTITION=y
 CONFIG_EFI_PARTITION=y