mbox series

[v2,0/3] arch-meson: introduce efusedump command

Message ID 20221213183129.75915-1-avromanov@sberdevices.ru
Headers show
Series arch-meson: introduce efusedump command | expand

Message

Alexey Romanov Dec. 13, 2022, 6:31 p.m. UTC 
Keeping the commands code in an arch/ is not correct. This patchset
moves the meson smc commands from arch/arm/mach-meson to cmd/meson
folder and also adds a new 'efusedump' command with which user can 
print efuse memory.

Alexey Romanov (3):
  asm/arch-meson: add missing meson_sm_write_efuse signature
  arm/mach-meson: move smc commands in cmd/meson
  cmd/arm: meson: sm: introduce efusedump command

 MAINTAINERS                          |   1 +
 arch/arm/include/asm/arch-meson/sm.h |   2 +
 arch/arm/mach-meson/sm.c             | 144 ---------------------
 cmd/Kconfig                          |   7 +
 cmd/Makefile                         |   3 +
 cmd/meson/Makefile                   |   5 +
 cmd/meson/sm.c                       | 187 +++++++++++++++++++++++++++
 7 files changed, 205 insertions(+), 144 deletions(-)
 create mode 100644 cmd/meson/Makefile
 create mode 100644 cmd/meson/sm.c

Comments

Simon Glass Dec. 14, 2022, 4:39 a.m. UTC | #1 
Hi Alexey,

On Tue, 13 Dec 2022 at 10:31, Alexey Romanov <avromanov@sberdevices.ru> wrote:
>
> Keeping the commands code in an arch/ is not correct. This patchset
> moves the meson smc commands from arch/arm/mach-meson to cmd/meson
> folder and also adds a new 'efusedump' command with which user can
> print efuse memory.
>
> Alexey Romanov (3):
>   asm/arch-meson: add missing meson_sm_write_efuse signature
>   arm/mach-meson: move smc commands in cmd/meson
>   cmd/arm: meson: sm: introduce efusedump command
>
>  MAINTAINERS                          |   1 +
>  arch/arm/include/asm/arch-meson/sm.h |   2 +
>  arch/arm/mach-meson/sm.c             | 144 ---------------------
>  cmd/Kconfig                          |   7 +
>  cmd/Makefile                         |   3 +
>  cmd/meson/Makefile                   |   5 +
>  cmd/meson/sm.c                       | 187 +++++++++++++++++++++++++++
>  7 files changed, 205 insertions(+), 144 deletions(-)
>  create mode 100644 cmd/meson/Makefile
>  create mode 100644 cmd/meson/sm.c
>
> --
> 2.25.1
>

It might be a good time to add some documentation in doc/usage/cmd/meson ?

Regards,
Simon
Alexey Romanov Dec. 14, 2022, 11:16 a.m. UTC | #2 
Hello!

On Tue, Dec 13, 2022 at 08:39:43PM -0800, Simon Glass wrote:
> Hi Alexey,
> 
> On Tue, 13 Dec 2022 at 10:31, Alexey Romanov <avromanov@sberdevices.ru> wrote:
> >
> > Keeping the commands code in an arch/ is not correct. This patchset
> > moves the meson smc commands from arch/arm/mach-meson to cmd/meson
> > folder and also adds a new 'efusedump' command with which user can
> > print efuse memory.
> >
> > Alexey Romanov (3):
> >   asm/arch-meson: add missing meson_sm_write_efuse signature
> >   arm/mach-meson: move smc commands in cmd/meson
> >   cmd/arm: meson: sm: introduce efusedump command
> >
> >  MAINTAINERS                          |   1 +
> >  arch/arm/include/asm/arch-meson/sm.h |   2 +
> >  arch/arm/mach-meson/sm.c             | 144 ---------------------
> >  cmd/Kconfig                          |   7 +
> >  cmd/Makefile                         |   3 +
> >  cmd/meson/Makefile                   |   5 +
> >  cmd/meson/sm.c                       | 187 +++++++++++++++++++++++++++
> >  7 files changed, 205 insertions(+), 144 deletions(-)
> >  create mode 100644 cmd/meson/Makefile
> >  create mode 100644 cmd/meson/sm.c
> >
> > --
> > 2.25.1
> >
> 
> It might be a good time to add some documentation in doc/usage/cmd/meson ?
> 
> Regards,
> Simon

Yeah, I'll add docs in v3 patchest.