Message ID | 20220524055650.1115899-1-chin-ting_kuo@aspeedtech.com |
---|---|
Headers | show |
Series | Add ASPEED SPI controller driver | expand |
Hi All, Are there any comments about this patch series? Thanks. Best Wishes, Chin-Ting > -----Original Message----- > From: Chin-Ting Kuo <chin-ting_kuo@aspeedtech.com> > Sent: Tuesday, May 24, 2022 1:57 PM > To: ChiaWei Wang <chiawei_wang@aspeedtech.com>; lukma@denx.de; > seanga2@gmail.com; Ryan Chen <ryan_chen@aspeedtech.com>; BMC-SW > <BMC-SW@aspeedtech.com>; jagan@amarulasolutions.com; vigneshr@ti.com; > clg@kaod.org; u-boot@lists.denx.de; p.yadav@ti.com > Subject: [v4 00/12] Add ASPEED SPI controller driver > > This patch series aims to porting ASPEED FMC/SPI memory controller driver > with spi-mem interface. spi-mem dirmap framework is also synchronized from > Linux. These patches have been verified on both > AST2600 and AST2500 EVBs. > > Changes in v2: > - Separate defconfig files from the SPI driver patch. > - Use "if (CONFIG_IS_ENABLED(SPI_DIRMAP))" to wrap > spi_dirmap related functions. > - Add Winbond w25q512jv flash ID. > > Changes in v3: > - Get AHB bus clock frequency from the function parameter. > - Fix a grammatical error in spi-mem.h. > > Changes in v4: > - Fix bug when SPI_NOR_4B_OPCODES flag is set. > > Chin-Ting Kuo (12): > clk: aspeed: Get HCLK frequency support > pinctrl: aspeed: FWSPICS1 and SPI1CS1 pin support > spi: aspeed: Add ASPEED SPI controller driver > configs: aspeed: Enable SPI flash features > MAINTAINERS: Add ASPEED SPI driver file > arm: dts: aspeed: Update SPI flash node settings > spi-mem: Add dirmap API from Linux > mtd: spi-nor: Use spi-mem dirmap API > spi: aspeed: SPI dirmap read support > configs: aspeed: Enable CONFIG_SPI_DIRMAP > mtd: spi-nor-ids: Add Winbond W25Q512JV ID > spi: aspeed: Fix bug when SPI_NOR_4B_OPCODES flag is set > > MAINTAINERS | 7 + > arch/arm/dts/ast2500-evb.dts | 33 + > arch/arm/dts/ast2500.dtsi | 23 +- > arch/arm/dts/ast2600-evb.dts | 8 - > arch/arm/dts/ast2600.dtsi | 34 +- > configs/evb-ast2500_defconfig | 14 + > configs/evb-ast2600_defconfig | 14 + > drivers/clk/aspeed/clk_ast2500.c | 23 + > drivers/mtd/spi/sf_probe.c | 76 ++ > drivers/mtd/spi/spi-nor-core.c | 55 +- > drivers/mtd/spi/spi-nor-ids.c | 5 + > drivers/pinctrl/aspeed/pinctrl_ast2500.c | 2 + > drivers/spi/Kconfig | 18 + > drivers/spi/Makefile | 1 + > drivers/spi/spi-aspeed.c | 914 > +++++++++++++++++++++++ > drivers/spi/spi-mem.c | 268 +++++++ > include/linux/mtd/spi-nor.h | 18 + > include/spi-mem.h | 79 ++ > 18 files changed, 1546 insertions(+), 46 deletions(-) create mode 100644 > drivers/spi/spi-aspeed.c > > -- > 2.25.1
On 6/26/22 06:56, Chin-Ting Kuo wrote: > Hi All, > > Are there any comments about this patch series?* Sorry, I haven't had time to take a look at the driver. I will try this week. Thanks, C. > > > Thanks. > > Best Wishes, > Chin-Ting > >> -----Original Message----- >> From: Chin-Ting Kuo <chin-ting_kuo@aspeedtech.com> >> Sent: Tuesday, May 24, 2022 1:57 PM >> To: ChiaWei Wang <chiawei_wang@aspeedtech.com>; lukma@denx.de; >> seanga2@gmail.com; Ryan Chen <ryan_chen@aspeedtech.com>; BMC-SW >> <BMC-SW@aspeedtech.com>; jagan@amarulasolutions.com; vigneshr@ti.com; >> clg@kaod.org; u-boot@lists.denx.de; p.yadav@ti.com >> Subject: [v4 00/12] Add ASPEED SPI controller driver >> >> This patch series aims to porting ASPEED FMC/SPI memory controller driver >> with spi-mem interface. spi-mem dirmap framework is also synchronized from >> Linux. These patches have been verified on both >> AST2600 and AST2500 EVBs. >> >> Changes in v2: >> - Separate defconfig files from the SPI driver patch. >> - Use "if (CONFIG_IS_ENABLED(SPI_DIRMAP))" to wrap >> spi_dirmap related functions. >> - Add Winbond w25q512jv flash ID. >> >> Changes in v3: >> - Get AHB bus clock frequency from the function parameter. >> - Fix a grammatical error in spi-mem.h. >> >> Changes in v4: >> - Fix bug when SPI_NOR_4B_OPCODES flag is set. >> >> Chin-Ting Kuo (12): >> clk: aspeed: Get HCLK frequency support >> pinctrl: aspeed: FWSPICS1 and SPI1CS1 pin support >> spi: aspeed: Add ASPEED SPI controller driver >> configs: aspeed: Enable SPI flash features >> MAINTAINERS: Add ASPEED SPI driver file >> arm: dts: aspeed: Update SPI flash node settings >> spi-mem: Add dirmap API from Linux >> mtd: spi-nor: Use spi-mem dirmap API >> spi: aspeed: SPI dirmap read support >> configs: aspeed: Enable CONFIG_SPI_DIRMAP >> mtd: spi-nor-ids: Add Winbond W25Q512JV ID >> spi: aspeed: Fix bug when SPI_NOR_4B_OPCODES flag is set >> >> MAINTAINERS | 7 + >> arch/arm/dts/ast2500-evb.dts | 33 + >> arch/arm/dts/ast2500.dtsi | 23 +- >> arch/arm/dts/ast2600-evb.dts | 8 - >> arch/arm/dts/ast2600.dtsi | 34 +- >> configs/evb-ast2500_defconfig | 14 + >> configs/evb-ast2600_defconfig | 14 + >> drivers/clk/aspeed/clk_ast2500.c | 23 + >> drivers/mtd/spi/sf_probe.c | 76 ++ >> drivers/mtd/spi/spi-nor-core.c | 55 +- >> drivers/mtd/spi/spi-nor-ids.c | 5 + >> drivers/pinctrl/aspeed/pinctrl_ast2500.c | 2 + >> drivers/spi/Kconfig | 18 + >> drivers/spi/Makefile | 1 + >> drivers/spi/spi-aspeed.c | 914 >> +++++++++++++++++++++++ >> drivers/spi/spi-mem.c | 268 +++++++ >> include/linux/mtd/spi-nor.h | 18 + >> include/spi-mem.h | 79 ++ >> 18 files changed, 1546 insertions(+), 46 deletions(-) create mode 100644 >> drivers/spi/spi-aspeed.c >> >> -- >> 2.25.1 >
Hi Cédric, > -----Original Message----- > From: Cédric Le Goater <clg@kaod.org> > Sent: Monday, June 27, 2022 12:16 AM > To: Chin-Ting Kuo <chin-ting_kuo@aspeedtech.com>; ChiaWei Wang > <chiawei_wang@aspeedtech.com>; lukma@denx.de; seanga2@gmail.com; > Ryan Chen <ryan_chen@aspeedtech.com>; BMC-SW > <BMC-SW@aspeedtech.com>; jagan@amarulasolutions.com; vigneshr@ti.com; > u-boot@lists.denx.de; p.yadav@ti.com > Cc: trini@konsulko.com > Subject: Re: [v4 00/12] Add ASPEED SPI controller driver > > On 6/26/22 06:56, Chin-Ting Kuo wrote: > > Hi All, > > > > Are there any comments about this patch series?* > > Sorry, I haven't had time to take a look at the driver. I will try this week. Okay and thanks for the reply. Chin-Ting > > Thanks, > > C. > > > > > > > Thanks. > > > > Best Wishes, > > Chin-Ting > > > >> -----Original Message----- > >> From: Chin-Ting Kuo <chin-ting_kuo@aspeedtech.com> > >> Sent: Tuesday, May 24, 2022 1:57 PM > >> To: ChiaWei Wang <chiawei_wang@aspeedtech.com>; lukma@denx.de; > >> seanga2@gmail.com; Ryan Chen <ryan_chen@aspeedtech.com>; BMC-SW > >> <BMC-SW@aspeedtech.com>; jagan@amarulasolutions.com; > vigneshr@ti.com; > >> clg@kaod.org; u-boot@lists.denx.de; p.yadav@ti.com > >> Subject: [v4 00/12] Add ASPEED SPI controller driver > >> > >> This patch series aims to porting ASPEED FMC/SPI memory controller > >> driver with spi-mem interface. spi-mem dirmap framework is also > >> synchronized from Linux. These patches have been verified on both > >> AST2600 and AST2500 EVBs. > >> > >> Changes in v2: > >> - Separate defconfig files from the SPI driver patch. > >> - Use "if (CONFIG_IS_ENABLED(SPI_DIRMAP))" to wrap > >> spi_dirmap related functions. > >> - Add Winbond w25q512jv flash ID. > >> > >> Changes in v3: > >> - Get AHB bus clock frequency from the function parameter. > >> - Fix a grammatical error in spi-mem.h. > >> > >> Changes in v4: > >> - Fix bug when SPI_NOR_4B_OPCODES flag is set. > >> > >> Chin-Ting Kuo (12): > >> clk: aspeed: Get HCLK frequency support > >> pinctrl: aspeed: FWSPICS1 and SPI1CS1 pin support > >> spi: aspeed: Add ASPEED SPI controller driver > >> configs: aspeed: Enable SPI flash features > >> MAINTAINERS: Add ASPEED SPI driver file > >> arm: dts: aspeed: Update SPI flash node settings > >> spi-mem: Add dirmap API from Linux > >> mtd: spi-nor: Use spi-mem dirmap API > >> spi: aspeed: SPI dirmap read support > >> configs: aspeed: Enable CONFIG_SPI_DIRMAP > >> mtd: spi-nor-ids: Add Winbond W25Q512JV ID > >> spi: aspeed: Fix bug when SPI_NOR_4B_OPCODES flag is set > >> > >> MAINTAINERS | 7 + > >> arch/arm/dts/ast2500-evb.dts | 33 + > >> arch/arm/dts/ast2500.dtsi | 23 +- > >> arch/arm/dts/ast2600-evb.dts | 8 - > >> arch/arm/dts/ast2600.dtsi | 34 +- > >> configs/evb-ast2500_defconfig | 14 + > >> configs/evb-ast2600_defconfig | 14 + > >> drivers/clk/aspeed/clk_ast2500.c | 23 + > >> drivers/mtd/spi/sf_probe.c | 76 ++ > >> drivers/mtd/spi/spi-nor-core.c | 55 +- > >> drivers/mtd/spi/spi-nor-ids.c | 5 + > >> drivers/pinctrl/aspeed/pinctrl_ast2500.c | 2 + > >> drivers/spi/Kconfig | 18 + > >> drivers/spi/Makefile | 1 + > >> drivers/spi/spi-aspeed.c | 914 > >> +++++++++++++++++++++++ > >> drivers/spi/spi-mem.c | 268 +++++++ > >> include/linux/mtd/spi-nor.h | 18 + > >> include/spi-mem.h | 79 ++ > >> 18 files changed, 1546 insertions(+), 46 deletions(-) create mode > >> 100644 drivers/spi/spi-aspeed.c > >> > >> -- > >> 2.25.1 > >
On Tue, May 24, 2022 at 11:27 AM Chin-Ting Kuo <chin-ting_kuo@aspeedtech.com> wrote: > > This patch series aims to porting ASPEED FMC/SPI memory controller > driver with spi-mem interface. spi-mem dirmap framework is also > synchronized from Linux. These patches have been verified on both > AST2600 and AST2500 EVBs. > > Changes in v2: > - Separate defconfig files from the SPI driver patch. > - Use "if (CONFIG_IS_ENABLED(SPI_DIRMAP))" to wrap > spi_dirmap related functions. > - Add Winbond w25q512jv flash ID. > > Changes in v3: > - Get AHB bus clock frequency from the function parameter. > - Fix a grammatical error in spi-mem.h. > > Changes in v4: > - Fix bug when SPI_NOR_4B_OPCODES flag is set. > > Chin-Ting Kuo (12): > clk: aspeed: Get HCLK frequency support > pinctrl: aspeed: FWSPICS1 and SPI1CS1 pin support > spi: aspeed: Add ASPEED SPI controller driver > configs: aspeed: Enable SPI flash features > MAINTAINERS: Add ASPEED SPI driver file > arm: dts: aspeed: Update SPI flash node settings > spi-mem: Add dirmap API from Linux > mtd: spi-nor: Use spi-mem dirmap API > spi: aspeed: SPI dirmap read support > configs: aspeed: Enable CONFIG_SPI_DIRMAP > mtd: spi-nor-ids: Add Winbond W25Q512JV ID > spi: aspeed: Fix bug when SPI_NOR_4B_OPCODES flag is set Sperate series for spi changes would really make it easier for review. please send it. Jagan.
Hi Jagan, > -----Original Message----- > From: Jagan Teki <jagan@amarulasolutions.com> > Sent: Friday, July 1, 2022 7:57 PM > To: Chin-Ting Kuo <chin-ting_kuo@aspeedtech.com> > Subject: Re: [v4 00/12] Add ASPEED SPI controller driver > > On Tue, May 24, 2022 at 11:27 AM Chin-Ting Kuo > <chin-ting_kuo@aspeedtech.com> wrote: > > > > This patch series aims to porting ASPEED FMC/SPI memory controller > > driver with spi-mem interface. spi-mem dirmap framework is also > > synchronized from Linux. These patches have been verified on both > > AST2600 and AST2500 EVBs. > > > > Changes in v2: > > - Separate defconfig files from the SPI driver patch. > > - Use "if (CONFIG_IS_ENABLED(SPI_DIRMAP))" to wrap > > spi_dirmap related functions. > > - Add Winbond w25q512jv flash ID. > > > > Changes in v3: > > - Get AHB bus clock frequency from the function parameter. > > - Fix a grammatical error in spi-mem.h. > > > > Changes in v4: > > - Fix bug when SPI_NOR_4B_OPCODES flag is set. > > > > Chin-Ting Kuo (12): > > clk: aspeed: Get HCLK frequency support > > pinctrl: aspeed: FWSPICS1 and SPI1CS1 pin support > > spi: aspeed: Add ASPEED SPI controller driver > > configs: aspeed: Enable SPI flash features > > MAINTAINERS: Add ASPEED SPI driver file > > arm: dts: aspeed: Update SPI flash node settings > > spi-mem: Add dirmap API from Linux > > mtd: spi-nor: Use spi-mem dirmap API > > spi: aspeed: SPI dirmap read support > > configs: aspeed: Enable CONFIG_SPI_DIRMAP > > mtd: spi-nor-ids: Add Winbond W25Q512JV ID > > spi: aspeed: Fix bug when SPI_NOR_4B_OPCODES flag is set > > Sperate series for spi changes would really make it easier for review. > please send it. > The patches in this series depend on each other. Patch with higher number relies on the one with lower number. Thus, I think they cannot be separated into different series. Chin-Ting > Jagan.