mbox series

[v3,0/2] log: Allow multiple lines and conversion to printf()

Message ID 20210508153043.1728019-1-sjg@chromium.org
Headers show
Series log: Allow multiple lines and conversion to printf() | expand

Message

Simon Glass May 8, 2021, 3:30 p.m. UTC 
At present when logging is not enabled, all log() calls become nops. This
does not seem right, since if the log level is high enough then there
should be some sort of message. So in that case, this series updates it to
print the message if the log level is above LOGL_INFO.

This mimics the behaviour for the log_...() macros like log_debug() and
log_info(), so we can drop the special case for these.

Also the current implementation does not support multiple log calls on the
same line nicely. The tags are repeated so the line is very hard to read.
This series adds that as a new feature.

Changes in v3:
- Rebase on hexdump series
  http://patchwork.ozlabs.org/project/uboot/list/?series=242818

Changes in v2:
- Update commit message and cover letter to mention log_...() macros
- Add a test for !CONFIG_LOG
- Update log() to (effectively) call debug() for log_level == LOGL_DEBUG

Simon Glass (2):
  sandbox: log: Avoid build error with !CONFIG_LOG
  log: Convert log values to printf() if not enabled

 configs/sandbox_defconfig |  1 +
 doc/develop/logging.rst   |  6 ++++--
 include/log.h             | 34 +++++++++++++++-------------------
 test/log/Makefile         |  2 ++
 test/log/nolog_ndebug.c   | 38 ++++++++++++++++++++++++++++++++++++++
 test/log/nolog_test.c     |  3 +++
 6 files changed, 63 insertions(+), 21 deletions(-)
 create mode 100644 test/log/nolog_ndebug.c