mbox series

[v2,0/4] mkimage usability fixes

Message ID 20201208041216.888902-1-joel@jms.id.au
Headers show
Series mkimage usability fixes | expand

Message

Joel Stanley Dec. 8, 2020, 4:12 a.m. UTC
v2: Move -B and -E out from FIT_SIGNATURE check, and other fixes from
Philippe's review.

Original cover letter:

I was learning about signed FIT today and was unable to convince mkimage
to produce a signature node in my control device tree. It turns out that
Debian's packaged mkimage doesn't enable FIT_SIGNATURE, so the options I
was passing were silently ignored.

There's an existing Debian bug for that[1] but in the mean time this
changes mkimage's behaviour to fail loudly when FIT_SIGNATURE is
disabled.

The first two patches fix some issues I found when testing the third
patch under sandbox_defconfig with FIT_SIGNATURE=n.

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=972513

Joel Stanley (4):
  tools/Makefile: FIT_CIPHER requires libssl
  image-fit: Fix FIT_CIPHER linking
  mkimage: Move padding commands outside of FIT_SIGNATURE
  mkimge: Reject signing-related flags without FIT_SIGNATURE

 common/image-fit-sig.c | 14 --------------
 common/image-fit.c     | 15 +++++++++++++++
 tools/Makefile         |  2 +-
 tools/mkimage.c        | 18 +++++++++++-------
 4 files changed, 27 insertions(+), 22 deletions(-)