From patchwork Tue Jan 28 12:04:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rasmus Villemoes X-Patchwork-Id: 1230304 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=prevas.dk Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=prevas.dk header.i=@prevas.dk header.a=rsa-sha256 header.s=selector1 header.b=TaEyzd8d; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 486QK73207z9sNF for ; Tue, 28 Jan 2020 23:04:43 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 49A1781AE0; Tue, 28 Jan 2020 13:04:40 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=prevas.dk Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=prevas.dk header.i=@prevas.dk header.b="TaEyzd8d"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4CA8B814F5; Tue, 28 Jan 2020 13:04:39 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: * X-Spam-Status: No, score=1.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU, FORGED_SPF_HELO, SPF_HELO_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03on0713.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe08::713]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B7A0A814F5 for ; Tue, 28 Jan 2020 13:04:35 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=prevas.dk Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rasmus.villemoes@prevas.dk ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Kedb6Ft/qJ5mvYrw6sVGKuCwZJ90tocRC5NQ6bo/YI1cOZCW/PfrfHeTCJ/K1l9AH5CX+gAfHkO+wlGREWGCzobAhJ/KNfjl+qq1p+EX53SrqroYnW0mBAE6rUf9t3w7CstbiViR1yWc1a/SeuhcLl5q3RZWP4Upuv8YJMXSFOwiAPDt+V6U4AmzqAUbruBypkNo+J7Hp7yL8KXV33wGGLQeIqdDk4Io7/4rVa4gtNMDVpK+CGmhZV6rmQIaYQgNkuiBuHQhWG8tiW+XX9Ys2TvHgLZwie7SOTixjrbfzXmQNOl2YLxbN1shfJJL+RJ02EAghAMBeycj6TfoNaL9Iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UR0XR75EznoCycyXLVxvl/rsTY4YhI90TvaGTlIlwog=; b=QCUAKA37nJohUG+w8ubJEe/Vq3Pj/1yuqK974BrwU2nyTYjarKpTXTvB0CQdzyozKBF0rPjE4BFTpGTEOwrq+GT8/X/ZIcSd4ZnVW4f7E5SysU14E6wRehEvA5XLibun5FEpixGf6UhSQEzSXrGtnw7tkpWJYRLQaZk2Sruy9Soq373dRzPcomBiJfQ0+wsWanQV2WM7uHaiGZMyNft6FoPRxsqDJ97WkquidE++fpeuFDcH2lhYghDteieUTXGU+SgQn6hREIFi74puN68xx2zEZcldeu1mzYdWyZus2YK0OanYK4gi3jNWZzSsflDsnfJAgLGfRB6MwMkccFY3Bw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=prevas.dk; dmarc=pass action=none header.from=prevas.dk; dkim=pass header.d=prevas.dk; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=prevas.dk; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UR0XR75EznoCycyXLVxvl/rsTY4YhI90TvaGTlIlwog=; b=TaEyzd8dyjtrrILtfkSel6/4alXstGHdWbBRiYI7dLLVQDUNNrR6iIHLK/dJXz8QAs1dmIco6Mck8uUCMI0C12jA3K+KvEu68qnjdyiEyt/bm5MIsURm609yROYVBNdZNxOQ5b5P+r8f3wlILoopvivQHAhU7E0NyecFXIoDp10= Received: from VI1PR10MB2765.EURPRD10.PROD.OUTLOOK.COM (20.178.126.85) by VI1PR10MB3295.EURPRD10.PROD.OUTLOOK.COM (52.133.247.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2665.23; Tue, 28 Jan 2020 12:04:32 +0000 Received: from VI1PR10MB2765.EURPRD10.PROD.OUTLOOK.COM ([fe80::8175:5aa2:2870:766d]) by VI1PR10MB2765.EURPRD10.PROD.OUTLOOK.COM ([fe80::8175:5aa2:2870:766d%6]) with mapi id 15.20.2665.026; Tue, 28 Jan 2020 12:04:32 +0000 Received: from prevas-ravi.prevas.se (81.216.59.226) by HE1PR0202CA0024.eurprd02.prod.outlook.com (2603:10a6:3:8c::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2665.21 via Frontend Transport; Tue, 28 Jan 2020 12:04:31 +0000 From: Rasmus Villemoes To: "u-boot@lists.denx.de" Subject: [PATCH resend 0/2] gpio: mpc8xxx: honour shadow register when writing gpdat Thread-Topic: [PATCH resend 0/2] gpio: mpc8xxx: honour shadow register when writing gpdat Thread-Index: AQHV1dMZo79TNYJKwkylLE4fu6x1UQ== Date: Tue, 28 Jan 2020 12:04:32 +0000 Message-ID: <20200128120423.16667-1-rasmus.villemoes@prevas.dk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HE1PR0202CA0024.eurprd02.prod.outlook.com (2603:10a6:3:8c::34) To VI1PR10MB2765.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:803:e1::21) x-mailer: git-send-email 2.23.0 authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasmus.villemoes@prevas.dk; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [81.216.59.226] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: deea2b62-aba0-48f8-4025-08d7a3ea3c3d x-ms-traffictypediagnostic: VI1PR10MB3295: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 029651C7A1 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(366004)(199004)(189003)(8676002)(16526019)(66556008)(8976002)(81166006)(5660300002)(4744005)(36756003)(26005)(6512007)(66946007)(186003)(66476007)(8936002)(1076003)(498600001)(66446008)(86362001)(64756008)(107886003)(956004)(52116002)(6916009)(2616005)(44832011)(81156014)(71200400001)(54906003)(6506007)(2906002)(4326008)(6486002)(32563001); DIR:OUT; SFP:1102; SCL:1; SRVR:VI1PR10MB3295; H:VI1PR10MB2765.EURPRD10.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: prevas.dk does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: RBIe8HCnU3QUjMhO/NrGFNrVq+ILdV7r8D9R4HqdBKwW4xN48/tlkBKkWpcvhAWw7BUi6iy0QLVRBoVA06RwX1eSJloMsqcz5FCc5qkcblIxrpNW3BtCmmN9EjjdLwJUjku1HqAYpB23mtylU4+63HHQLgPHTq+Kx0zIhEJ9DE7PtM+tJVXNtcd91jwKTxo7igNOTD3QuBz6wNETHNoluy0GxqHSQG9NB1l+rawpcjZyubKfuMXEfQb2by4oFfamfBiK3GBqsLjiyLH4EvoZuP/2ALzP9h1hQOouA67JV1qPyursoJFnyX1QBm1MvbVCa6r4l5ihROJYytz2RNFmZ4uq0qh1L9c79dLjZ0vL57Tq2oI7UoNqQIh4GQc7VlxMyDS+8OM9Kw+K7FAqLqCWyrbHiy9eE6q4wjcj3NVyed/l9oPwRXUeddDfGB9hSGyhpLAg2ACSVEMVv4BWgWdFpIQjlwL6pbyA+yfHCNluO7w= x-ms-exchange-antispam-messagedata: cioTXelHii0pDk9rqB5wUW+hxmlZjDpsGXf+9fE2UOvV0qV4biblJLTdx/yHhZA+vRqMuvuGuSdCF7GyeB1WXySEHxCX1W/m1AuPEIlNbOHox2jm7r4MDV0dNlDUFyfdcITtPgKHmTwJh7+GUTifkA== MIME-Version: 1.0 X-OriginatorOrg: prevas.dk X-MS-Exchange-CrossTenant-Network-Message-Id: deea2b62-aba0-48f8-4025-08d7a3ea3c3d X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jan 2020 12:04:32.6924 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d350cf71-778d-4780-88f5-071a4cb1ed61 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 96K4O9dFCJujK3oZ9bnxw8iW+VGANksak7EsFVJ3seqEClR815nrTtkBEeFU8BS4VGeNd2FyClCQRvBlWzngm1HxDBJaner2BatsDN/nFs8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR10MB3295 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.26 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.101.4 at phobos.denx.de X-Virus-Status: Clean [resending with Mario's correct address, sorry for the double post] The driver correctly uses the shadow register when asked for the current value of an output gpio. Unfortunately, it does RMW on the gpdat register both when setting a gpio as input and output. These two patches fix that. Aside: Apparently, the mpc8309 also partially suffers from the errata preventing outputs from being read back - the bits corresponding to gpios 0-7 are always read as 0, while at least the value of gpio10 is correctly reflected when reading gpdat. Which is how I noticed these bugs - I couldn't understand why turning one LED on would turn off another. Rasmus Villemoes (2): gpio: mpc8xxx: don't modify gpdat when setting gpio as input gpio: mpc8xxx: don't do RMW on gpdat register when setting value drivers/gpio/mpc8xxx_gpio.c | 41 ++++++++++++++----------------------- 1 file changed, 15 insertions(+), 26 deletions(-)