mbox series

[U-Boot,0/6] driver: net: fsl-mc: Add support of multiple phys for dpmac

Message ID 20180713144036.17606-1-pankaj.bansal@nxp.com
Headers show
Series driver: net: fsl-mc: Add support of multiple phys for dpmac | expand

Message

Pankaj Bansal July 13, 2018, 2:40 p.m. UTC 
This patch set adds support of multiple phys for one dpmac

Till now we have had cases where we had one phy device per dpmac.
Now, with the upcoming products (LX2160AQDS), we have cases, where there
are sometimes two phy devices for one dpmac. One phy for TX lanes and one
phy for RX lanes. To handle such cases, add the support for multiple phys
in ethernet driver. The ethernet link is up if all the phy devices
connected to one dpmac report link up.
also the link capabilities are limited by the weakest phy device.

i.e. say if there are two phys for one dpmac. one operates at 10G without
autoneg and other operate at 1G with autoneg. Then the ethernet interface
will operate at 1G without autoneg.

Pankaj Bansal (6):
  driver: net: fsl-mc: modify the label name
  driver: net: fsl-mc: remove unused strcture elements
  driver: net: fsl-mc: fix error handing in init_phy
  driver: net: fsl-mc: Modify the dpmac link detection method
  driver: net: fsl-mc: initialize dpmac irrespective of phy
  driver: net: fsl-mc: Add support of multiple phys for dpmac

 board/freescale/ls1088a/eth_ls1088aqds.c   |  18 +--
 board/freescale/ls1088a/eth_ls1088ardb.c   |  21 +--
 board/freescale/ls2080aqds/eth.c           |  26 +--
 board/freescale/ls2080ardb/eth_ls2080rdb.c |  24 +--
 drivers/net/fsl-mc/mc.c                    |   6 +-
 drivers/net/ldpaa_eth/ldpaa_eth.c          | 180 +++++++++++++--------
 drivers/net/ldpaa_eth/ldpaa_eth.h          |   1 -
 drivers/net/ldpaa_eth/ldpaa_wriop.c        |  49 ++++--
 include/fsl-mc/ldpaa_wriop.h               |  22 +--
 9 files changed, 209 insertions(+), 138 deletions(-)

Comments

Prabhakar Kushwaha July 19, 2018, 3:35 a.m. UTC | #1 
> -----Original Message-----
> From: Pankaj Bansal
> Sent: Friday, July 13, 2018 8:11 PM
> To: u-boot@lists.denx.de
> Cc: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>; Priyanka Jain
> <priyanka.jain@nxp.com>; Varun Sethi <V.Sethi@nxp.com>; York Sun
> <york.sun@nxp.com>; joe.hershberger@ni.com; Pankaj Bansal
> <pankaj.bansal@nxp.com>
> Subject: [PATCH 0/6] driver: net: fsl-mc: Add support of multiple phys for
> dpmac
> 
> This patch set adds support of multiple phys for one dpmac
> 
> Till now we have had cases where we had one phy device per dpmac.
> Now, with the upcoming products (LX2160AQDS), we have cases, where
> there are sometimes two phy devices for one dpmac. One phy for TX lanes
> and one phy for RX lanes. To handle such cases, add the support for multiple
> phys in ethernet driver. The ethernet link is up if all the phy devices
> connected to one dpmac report link up.
> also the link capabilities are limited by the weakest phy device.
> 
> i.e. say if there are two phys for one dpmac. one operates at 10G without
> autoneg and other operate at 1G with autoneg. Then the ethernet interface
> will operate at 1G without autoneg.
> 
> Pankaj Bansal (6):
>   driver: net: fsl-mc: modify the label name
>   driver: net: fsl-mc: remove unused strcture elements
>   driver: net: fsl-mc: fix error handing in init_phy
>   driver: net: fsl-mc: Modify the dpmac link detection method
>   driver: net: fsl-mc: initialize dpmac irrespective of phy
>   driver: net: fsl-mc: Add support of multiple phys for dpmac
> 
>  board/freescale/ls1088a/eth_ls1088aqds.c   |  18 +--
>  board/freescale/ls1088a/eth_ls1088ardb.c   |  21 +--
>  board/freescale/ls2080aqds/eth.c           |  26 +--
>  board/freescale/ls2080ardb/eth_ls2080rdb.c |  24 +--
>  drivers/net/fsl-mc/mc.c                    |   6 +-
>  drivers/net/ldpaa_eth/ldpaa_eth.c          | 180 +++++++++++++--------
>  drivers/net/ldpaa_eth/ldpaa_eth.h          |   1 -
>  drivers/net/ldpaa_eth/ldpaa_wriop.c        |  49 ++++--
>  include/fsl-mc/ldpaa_wriop.h               |  22 +--
>  9 files changed, 209 insertions(+), 138 deletions(-)

Patch set looks good. 

Reviewed-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
Pankaj Bansal July 25, 2018, 3:03 a.m. UTC | #2 
Hi Joe,

Can you please review these changes ?

Regards,
Pankaj Bansal

> -----Original Message-----
> From: Prabhakar Kushwaha
> Sent: Thursday, July 19, 2018 9:06 AM
> To: Pankaj Bansal <pankaj.bansal@nxp.com>; u-boot@lists.denx.de
> Cc: Priyanka Jain <priyanka.jain@nxp.com>; Varun Sethi
> <V.Sethi@nxp.com>; York Sun <york.sun@nxp.com>;
> joe.hershberger@ni.com
> Subject: RE: [PATCH 0/6] driver: net: fsl-mc: Add support of multiple phys
> for dpmac
> 
> 
> > -----Original Message-----
> > From: Pankaj Bansal
> > Sent: Friday, July 13, 2018 8:11 PM
> > To: u-boot@lists.denx.de
> > Cc: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>; Priyanka Jain
> > <priyanka.jain@nxp.com>; Varun Sethi <V.Sethi@nxp.com>; York Sun
> > <york.sun@nxp.com>; joe.hershberger@ni.com; Pankaj Bansal
> > <pankaj.bansal@nxp.com>
> > Subject: [PATCH 0/6] driver: net: fsl-mc: Add support of multiple phys
> > for dpmac
> >
> > This patch set adds support of multiple phys for one dpmac
> >
> > Till now we have had cases where we had one phy device per dpmac.
> > Now, with the upcoming products (LX2160AQDS), we have cases, where
> > there are sometimes two phy devices for one dpmac. One phy for TX
> > lanes and one phy for RX lanes. To handle such cases, add the support
> > for multiple phys in ethernet driver. The ethernet link is up if all
> > the phy devices connected to one dpmac report link up.
> > also the link capabilities are limited by the weakest phy device.
> >
> > i.e. say if there are two phys for one dpmac. one operates at 10G
> > without autoneg and other operate at 1G with autoneg. Then the
> > ethernet interface will operate at 1G without autoneg.
> >
> > Pankaj Bansal (6):
> >   driver: net: fsl-mc: modify the label name
> >   driver: net: fsl-mc: remove unused strcture elements
> >   driver: net: fsl-mc: fix error handing in init_phy
> >   driver: net: fsl-mc: Modify the dpmac link detection method
> >   driver: net: fsl-mc: initialize dpmac irrespective of phy
> >   driver: net: fsl-mc: Add support of multiple phys for dpmac
> >
> >  board/freescale/ls1088a/eth_ls1088aqds.c   |  18 +--
> >  board/freescale/ls1088a/eth_ls1088ardb.c   |  21 +--
> >  board/freescale/ls2080aqds/eth.c           |  26 +--
> >  board/freescale/ls2080ardb/eth_ls2080rdb.c |  24 +--
> >  drivers/net/fsl-mc/mc.c                    |   6 +-
> >  drivers/net/ldpaa_eth/ldpaa_eth.c          | 180 +++++++++++++--------
> >  drivers/net/ldpaa_eth/ldpaa_eth.h          |   1 -
> >  drivers/net/ldpaa_eth/ldpaa_wriop.c        |  49 ++++--
> >  include/fsl-mc/ldpaa_wriop.h               |  22 +--
> >  9 files changed, 209 insertions(+), 138 deletions(-)
> 
> Patch set looks good.
> 
> Reviewed-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> 
>