From patchwork Fri Apr 27 15:08:39 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 905785 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=nexus-software.ie Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=nexus-software-ie.20150623.gappssmtp.com header.i=@nexus-software-ie.20150623.gappssmtp.com header.b="E5ie37Fn"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 40Xclk2JDlz9s1P for ; Sat, 28 Apr 2018 01:09:04 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 3E543C221BA; Fri, 27 Apr 2018 15:08:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 477E4C21E85; Fri, 27 Apr 2018 15:08:53 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 808E7C21E85; Fri, 27 Apr 2018 15:08:51 +0000 (UTC) Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by lists.denx.de (Postfix) with ESMTPS id 2BF7AC21E79 for ; Fri, 27 Apr 2018 15:08:51 +0000 (UTC) Received: by mail-wm0-f67.google.com with SMTP id o78so3534389wmg.0 for ; Fri, 27 Apr 2018 08:08:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nexus-software-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=5fteNV6gHVcBl7OYY0v1jFhIDqymSPpf1Myl4PJ98Cg=; b=E5ie37Fnc6LRfyAeccy1Do8Oqw8CAoGdseHLQSD+ePknuUYzr0k1Zcemk/vH1L5KUi DZnLOUTa4sjq9mE0gNfrkyloJHBavKC7Q2D8/6YVEt+mq4rjaLyfWMUTRsJRKV6imGsr tTZM20ftvYUqDlSW5ExSn+Sw0gev3oyD4npaDgDmMISO6jx1YImx7W8l1v+ASw/2W5aq C78/nqCn13EV9DLL4uZgffAW7wl3Rl+Jiyh8S+2fkw+4j6U8tSS3Xh5Xh8OaWnTQwa9s ucD2tViVW8BwJlL79RnmObl0awPlXnfnjTq7eZrlURsXZ5+UPG9JDRlz2WHtQ337TiNr zCPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=5fteNV6gHVcBl7OYY0v1jFhIDqymSPpf1Myl4PJ98Cg=; b=g2KT9D2mz3e9wBds5i7YYc24sJoz0eDw9dkPH4VZf1OxoPeL+s3+8g/9e/9V73ypsD pXLHtsgUnQoyNsHzsM4rR7+CwLv1UZ6yLoG1aRo6jy7obgybc9sALgl+6P5xFSsmzkZW qflF6MKCpDLla1ovDXzgaImdQdO7o5umfcCUXQdho6Z7ElwnUFruzVvzLym1phMRBWi1 /EA/3+MI1aS/EF/Kgo8L4RCM4gRK96+lPkXglO0MT+Q6xAxHBqDqf34Uggl+XF1xTl/I XJirprUZyTrVz/xeviSyDfGQnApQdkVygxhceJ7Y42fmcz0+zAtjmm7wsZ4vMuqdvGmF C0aQ== X-Gm-Message-State: ALQs6tCvwpZV/NAqlO12R6y5SsdHadKBp+AJcfQWwAKBrJr2tpLT9K+R vIVyOpeUEuEdL1lernH03pjzFHzy X-Google-Smtp-Source: AB8JxZpT5OZ/iseZOY7Sojw2UPymHZ7LLvO5C+UVl6yisXGmiNYnAwgaD9Mblo/1lIHATwt5KZY14w== X-Received: by 2002:a50:b0a2:: with SMTP id j31-v6mr3837318edd.215.1524841730521; Fri, 27 Apr 2018 08:08:50 -0700 (PDT) Received: from event-horizon.net ([109.255.42.2]) by smtp.gmail.com with ESMTPSA id d17-v6sm1041063ede.65.2018.04.27.08.08.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Apr 2018 08:08:49 -0700 (PDT) From: Bryan O'Donoghue To: u-boot@lists.denx.de Date: Fri, 27 Apr 2018 16:08:39 +0100 Message-Id: <20180427150848.12075-1-pure.logic@nexus-software.ie> X-Mailer: git-send-email 2.17.0 Subject: [U-Boot] [PATCH 0/9] Fixup set_bit/clear_bit definition and usage X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Following on from a discussion with Marek and Lukasz re: a namespace collision with set_bit and clear_bit in f_mass_storage, I noticed some inconsistencies in the definition and usage of PLATFORM__SET_BIT and PLATFORM__CLEAR_BIT as well as a similar use of __set_bit in the composite USB gadget driver. __set_bit is lock-prefixed on x86 whereas set_bit is not and the analog driver in upstream Linux does set_bit() not __set_bit(). This series addresses all of those inconsistencies. There are some usages of __set_bit() but those are in SoC specific GPIO code-paths and therefore don't really need to change IMO. Bryan O'Donoghue (9): x86: Define PLATFORM__SET_BIT for generic_set_bit() riscv: Define PLATFORM__SET_BIT for generic_set_bit() riscv: : Define PLATFORM__CLEAR_BIT for generic_clear_bit() nios2: Define PLATFORM__SET_BIT for generic_set_bit() nios2: : Define PLATFORM__CLEAR_BIT for generic_clear_bit() nds32: Define PLATFORM__SET_BIT for generic_set_bit() nds2: : Define PLATFORM__CLEAR_BIT for generic_clear_bit() usb: f_mass_storage: Fix set_bit and clear_bit usage usb: composite convert __set_bit to generic_set_bit arch/nds32/include/asm/bitops.h | 4 ++++ arch/nios2/include/asm/bitops/non-atomic.h | 4 ++++ arch/riscv/include/asm/bitops.h | 4 ++++ arch/x86/include/asm/bitops.h | 2 ++ drivers/usb/gadget/composite.c | 2 +- drivers/usb/gadget/f_mass_storage.c | 25 +++------------------- 6 files changed, 18 insertions(+), 23 deletions(-)