| Message ID | 1580758773-5287-1-git-send-email-stefan_b@posteo.net |
|---|---|
| Headers | show |
| Series | arm: add support for SoC S5P4418 | expand |
On Mon, Feb 03, 2020 at 08:39:22PM +0100, Stefan Bosch wrote: > This patch adds support for SAMSUNG's/NEXELL's ARM Cortex-A9 based > S5P4418 SoC, especially FriendlyARM's NanoPi2 and NanoPC-T2 boards. > It is based on the following FriendlyARM's U-Boot version: > https://github.com/friendlyarm/u-boot/tree/nanopi2-v2016.01. > > The added mach-nexell also supports the S5P6818 SoC which is a > follow-up of the S5P4418. > > Main changes in relation to nanopi2-v2016.01: > - Cosmetic changes due to patman warnings/errors. > - MMC and Video drivers changed to DM. > - Configs reworked (e.g. "CONFIG_..." moved from s5p4418_nanopi2.h > to s5p4418_nanopi2_defconfig) > - SPL related files are not included. > - MACH_TYPE_S5P4418 is not defined/used anymore. > - arch/arm/mach-nexell/include/mach/boot0.h added to generate the NSIH > (Nexell System Information Header), substitudes tools/nexell. > - board/s5p4418/ renamed to board/friendlyarm/ > - Only the NanoPi2 and NanoPC-T2 boards are supported yet because I > do only have the NanoPC-T2 board to test the code (this board uses > the NanoPi2 code). > > > Stefan Bosch (10): > arm: add mach-nexell (header files) > arm: add mach-nexell (all files except header files) > i2c: mmc: add nexell driver (gpio, i2c, mmc, pwm) > video: add nexell video driver (soc: displaytop) > video: add nexell video driver (soc: mlc, mipi) > video: add nexell video driver (soc: lvds, hdmi) > video: add nexell video driver (soc: dpc, makefile) > video: add nexell video driver (display/video driver) > arm: add support for SoC s5p4418 (cpu) / nanopi2 board > arm: add (default) config for nanopi2 board In general: - Make sure everything is checkpatch clean (or when not, explainable). - Don't include unused (by the end of the series at least) code. - Don't include both SPDX tags and then the whole license boilerplate. - Do make sure that there's nothing in the config.h file that should be in a _defconfig file at this point. Thanks!
Hi, On Tue, Feb 4, 2020 at 1:12 AM Stefan Bosch <stefan_b@posteo.net> wrote: > > > This patch adds support for SAMSUNG's/NEXELL's ARM Cortex-A9 based > S5P4418 SoC, especially FriendlyARM's NanoPi2 and NanoPC-T2 boards. > It is based on the following FriendlyARM's U-Boot version: > https://github.com/friendlyarm/u-boot/tree/nanopi2-v2016.01. > I don't think this is the right approach, i.e. to take everything from BSP source as it is and put it into mainline U-BOOT. AFAIR, Some of the peripherals present on these NEXELL SoC's are compatible with SAMSUNG IP (for instance the UART). So, are we sure that some of the already existing code in U-BOOT can't be re-used to drive those compatible peripherals at-least ? Thanks -Amit
Hi Amit, Am 22.02.20 um 14:06 schrieb Amit Tomer: > Hi, > > On Tue, Feb 4, 2020 at 1:12 AM Stefan Bosch <stefan_b@posteo.net> wrote: >> >> >> This patch adds support for SAMSUNG's/NEXELL's ARM Cortex-A9 based >> S5P4418 SoC, especially FriendlyARM's NanoPi2 and NanoPC-T2 boards. >> It is based on the following FriendlyARM's U-Boot version: >> https://github.com/friendlyarm/u-boot/tree/nanopi2-v2016.01. >> > I don't think this is the right approach, i.e. to take everything from > BSP source as it is and put > it into mainline U-BOOT. AFAIR, Some of the peripherals present on > these NEXELL SoC's are > compatible with SAMSUNG IP (for instance the UART). > So, are we sure that some of the already existing code in U-BOOT can't > be re-used to drive those > compatible peripherals at-least ? > > Thanks > -Amit > You are right, already existing code in U-BOOT should be used where possible. So I have reviewed the code (and will review it further). Up to now, I have the following proposals for the peripherials indicated: UART: Actually the UARTs of the S5P4418 are Amba PrimeCell PL011 compatible, therefore the appropriate code is used. S5P6818 does have different UARTs which apparently arch/arm/mach-nexell/serial.c is for. Since S5P6818 is not supported (yet) I will remove this file. TIMER: Currently arch/arm/mach-nexell/timer.c is used. I will try to use arch/arm/cpu/armv7/s5p-common/timer.c instead. The timer-registers used seem to be the same, but the functions in timer.c are not which is a possible pitfall. PWM: Currently drivers/pwm/pwm-nexell.c is used. This is a extended version of arch/arm/cpu/armv7/s5p-common/pwm.c. I.e. pwm.c is adapted with "#if defined(CONFIG_ARCH_NEXELL) ... #else" at some places. So my proposal is to change s5p-common/pwm.c appropriately to get rid of pwm-nexell.c. Regards Stefan