| Message ID | 20160108020441.GA12462@lkp-nex06 |
|---|---|
| State | New |
| Headers | show |
--- a/drivers/char/tpm/tpm_crb.c +++ b/drivers/char/tpm/tpm_crb.c @@ -294,9 +294,7 @@ static int crb_map_io(struct acpi_device memcpy_fromio(&pa, &priv->cca->rsp_pa, 8); pa = le64_to_cpu(pa); priv->rsp = crb_access(dev, priv, pa, ioread32(&priv->cca->rsp_size)); - if (IS_ERR(priv->rsp)) - return PTR_ERR(priv->rsp); - return 0; + return PTR_ERR_OR_ZERO(priv->rsp); } static int crb_acpi_add(struct acpi_device *device)
drivers/char/tpm/tpm_crb.c:297:1-3: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci CC: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> --- tpm_crb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) ------------------------------------------------------------------------------