From patchwork Fri Dec 22 13:42:20 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: richard_allen@keysight.com X-Patchwork-Id: 852371 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=googlegroups.com (client-ip=2607:f8b0:4001:c06::23b; helo=mail-io0-x23b.google.com; envelope-from=swupdate+bncbcokrcfxqapbbp4x6tiqkgqec7z75aq@googlegroups.com; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.b="bs1bMygw"; dkim-atps=neutral Received: from mail-io0-x23b.google.com (mail-io0-x23b.google.com [IPv6:2607:f8b0:4001:c06::23b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3z38nt5f42z9rxm for ; Sat, 23 Dec 2017 00:42:25 +1100 (AEDT) Received: by mail-io0-x23b.google.com with SMTP id s23sf7347947ioa.16 for ; Fri, 22 Dec 2017 05:42:25 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1513950143; cv=pass; d=google.com; s=arc-20160816; b=nku2a36yQe6h5JrLYW6XVfJ1xuBKj1JsYAkx/8m0bmonK7C49EsuI2wZWrmC5D2wTt 2SqtcTejkJIuGLHTXRnG9kCArzrD05viflCxHXKKUC8eoP2UyBBxsK6cdra4iI3WYo1o uJDhlRSR+/4HlhvcpvyErcPeCPMwF4q78GyBgK4KJQ+ge9YHQbhcJCdsTtILQltox1c7 2zI9gOqA6p3uaYWCNRsyMCp24diyes8nG3In6b2vxK/eLlHUyJZHX9NZFeitNpkNSgVT fU/P+awColH7ybgHG4ui965iM1eFqOwzRBJNXgzCGpotd/TVKua9s3vxCJiRgRI2eMou eV2Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:spamdiagnosticmetadata :spamdiagnosticoutput:content-language:accept-language:in-reply-to :references:message-id:date:thread-index:thread-topic:subject:to :from:arc-authentication-results:arc-message-signature:sender :dkim-signature:arc-authentication-results; bh=uZJZ10TrQTLl8V7ea4Ria65I6XWf5/XEvOUPGMwBsI4=; b=MHFpVIeoTOzg00S2zL2f7FWM4y1q1fet0R1GmOCV92pS3dq024UyNy76D7nSrx3d3i AOqtfEI3JyijDq9AWMxPcFJy8bguai8LiLrlD6YQW+uhbMcPtw1RPK7LC68u+BQpjpfP RZ0UqgnC8wAI22ERUge9pm1r3eUOMTAC+UmpXcGHlqAOpMm5N8ewcrjme7W1IvJqNU9M b3AtqmftSOZ3dHlGJPqbLijj4AYpiNwZRfjybMAj0Q5N7x9V3jRdbUW/HIwJSZpb3EKL pvAIsRivBfP6cmp7AVGGwFRn4h35JHRM/Y1N5P5b3QbUgfEvp7B+cqaDtbAD1WKWPcRr 763g== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@keysighttech.onmicrosoft.com header.s=selector1-keysight-com header.b=shPFHNo+; spf=pass (google.com: domain of richard_allen@keysight.com designates 104.47.32.120 as permitted sender) smtp.mailfrom=richard_allen@keysight.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20161025; h=sender:from:to:subject:thread-topic:thread-index:date:message-id :references:in-reply-to:accept-language:content-language :spamdiagnosticoutput:spamdiagnosticmetadata:mime-version :x-original-sender:x-original-authentication-results:precedence :mailing-list:list-id:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=uZJZ10TrQTLl8V7ea4Ria65I6XWf5/XEvOUPGMwBsI4=; b=bs1bMygwGrycIGJGTmtjGVewz1C9SGiR1CRu4zbiOhGxNm+71eHS+61yyR/vUk6lZH WS4WAnTuCCDEb9geg5ZaF7+RFQzzgKz8SUdnwRRVyUq9PGJpu77sJtyyeJDvwHlsPQ1o hks7YCtgjkwOELHQd7urLITQ5YDgkRAYFxRnwvVPjr5ySsxmLKxPJg1McFGf8VZUQPS5 RBoT+5bxez0gU9XkBw9oWIRapNSOFS95x9OT2P652ju5Rc3Yt/Q93pxrOpA/O03mMzqz psieor97CIpByzcZsC+dvoifEhcVztII+sZThniPOw54zLcTO9mBWuLww62GMN2+sZrB udeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=sender:x-gm-message-state:from:to:subject:thread-topic:thread-index :date:message-id:references:in-reply-to:accept-language :content-language:spamdiagnosticoutput:spamdiagnosticmetadata :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:x-spam-checked-in-group:list-post :list-help:list-archive:list-subscribe:list-unsubscribe; bh=uZJZ10TrQTLl8V7ea4Ria65I6XWf5/XEvOUPGMwBsI4=; b=krg7eCTdR+BLyn7QsYw9ybNWgwigJ5nImvFtwsETBNR4h2jMJZStpCTJ34RtURMUCD gL8abCdSBi/8XquaytrVAPbS7w6i27D0VKNtR+UwcpV81BX4hQX7PC/fAicPi7Csmg2m GaiZvY6gEu/1HZ6ZpWEfDQl5s51GZfr56lOLB9tDcuV+v+nSa50qbZQA0ymTtF3FSPo1 fHUSjpdxPsElXwvdYp6DbYRuGfw/3U629mFrPMtWSMUef4LO3WFjDI3FaJzLSN12/az0 PPxiR7X7GPonIGPkZKx+FYNVYkX8ABr5Wgnh0qnAjD10NbyhdboS20l/RCLmSsT8zT2O dOPw== Sender: swupdate@googlegroups.com X-Gm-Message-State: AKGB3mJKBWye5kUq8LWZOMtODLG5piqdpLjsro/Tw2WMCWeSZnE0muAd 7bVW3VGdhk4XX/JAXRXL9ZU= X-Google-Smtp-Source: ACJfBosq8U7fXVBFcLVgo79uF4vgQAIgWm1MH3Wa4CKGVXhfesI6yRvjrWnPmQ3W7bwKG++Y4wmONA== X-Received: by 10.36.5.1 with SMTP id 1mr179644itl.7.1513950143311; Fri, 22 Dec 2017 05:42:23 -0800 (PST) X-BeenThere: swupdate@googlegroups.com Received: by 10.107.140.1 with SMTP id o1ls641262iod.0.gmail; Fri, 22 Dec 2017 05:42:22 -0800 (PST) X-Received: by 10.36.51.9 with SMTP id k9mr8971615itk.50.1513950142785; Fri, 22 Dec 2017 05:42:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1513950142; cv=none; d=google.com; s=arc-20160816; b=Xmyz49LTy8tGv08DnSEsiODqtwMAnvlqBKbxCb7JwqDaSQ06Kl6xrMmlUrvtVTaSGi o2TLJGT9/7OP/r2K4P+cpbmpMcHOtAPgmAc5iHa+ML81/B+tkRS3Ryylbc4yzKRUGs0X NDE1JlFhJQF21q9NHZkwFkp4bL65CzzWRy254R2hMJczGEdL2795Vb1mhsFlsiybCO/G dm4RC1xns9mNxKP+5YYqOgIhChXQJawGPWr4Eca6NStVuFHM35nD0lzVdBxNlGD7qoq4 LAW7lcN4tNHGn0+2MQ8waekJwkvBpneRALD6PMK31h1yQ439vYH0NwjUAM0kfMmZcgad dfNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:spamdiagnosticmetadata :spamdiagnosticoutput:content-language:accept-language:in-reply-to :references:message-id:date:thread-index:thread-topic:subject:to :from:dkim-signature:arc-authentication-results; bh=MyWI1GuviOWel5CV6jLxFr2Dp2dSOx+wcp9Nfb1mMm8=; b=sKwdA3Jr6jENMhEGk1v4I5u8vJLjHt0VXg2Zktf6mwomFexnPMopcknC4ZpQfvr6BW 4OeDgMOuoDettnj3J2Wdc8tCz0Tc49RAZZyiT24COO+zO/JGlsL/bTA8dAQEURz4ONsN gCF4neVymOvdWrCKtAh4dRJAO+/7IF7mjBrE2uKmO2BD+cfTUtkSrIQTlaOyZ2a6VdAK abSlsE5CuhnFtDs9OwWeR0aRJGtjeQw8ullpXGG5N7iJFLdAG+RdYqM/2ypHduuqbxJT oeikaCEIE3TjcRs673UN6v1xgK3ae+OPwY6YKKv38HkunOti2Yv9hyBpvXWvnn7mds2e RX+g== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@keysighttech.onmicrosoft.com header.s=selector1-keysight-com header.b=shPFHNo+; spf=pass (google.com: domain of richard_allen@keysight.com designates 104.47.32.120 as permitted sender) smtp.mailfrom=richard_allen@keysight.com Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0120.outbound.protection.outlook.com. [104.47.32.120]) by gmr-mx.google.com with ESMTPS id f203si465915itd.1.2017.12.22.05.42.22 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 22 Dec 2017 05:42:22 -0800 (PST) Received-SPF: pass (google.com: domain of richard_allen@keysight.com designates 104.47.32.120 as permitted sender) client-ip=104.47.32.120; Received: from BY1PR17MB0120.namprd17.prod.outlook.com (10.161.97.144) by BY1PR17MB0117.namprd17.prod.outlook.com (10.161.97.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.323.15; Fri, 22 Dec 2017 13:42:20 +0000 Received: from BY1PR17MB0120.namprd17.prod.outlook.com ([fe80::446e:de57:2257:4409]) by BY1PR17MB0120.namprd17.prod.outlook.com ([fe80::446e:de57:2257:4409%18]) with mapi id 15.20.0345.013; Fri, 22 Dec 2017 13:42:20 +0000 From: To: , Subject: [swupdate] RE: [PATCH 2/2] Drop filename length limit in CPIO extraction Thread-Topic: [PATCH 2/2] Drop filename length limit in CPIO extraction Thread-Index: AQHTewkBU8X02qfF006dIy/RFR9TiKNPXyeA Date: Fri, 22 Dec 2017 13:42:20 +0000 Message-ID: References: <1513935659-8075-1-git-send-email-sbabic@denx.de> <1513935659-8075-2-git-send-email-sbabic@denx.de> In-Reply-To: <1513935659-8075-2-git-send-email-sbabic@denx.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [206.49.107.132] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; BY1PR17MB0117; 6:QBmfxApjjqdThIOGV69eo0f7hPfjKFnoRzv9qMGXBCjX/0bppTpuK3vsMUPhcyjoMy6+rFC8kvm6I7X2U0mCtOXFhlMKuWxP5SvBc1bxqHfC+iykOW+nmbKxOf1uKfEeHab351h16nb22807x+Ou66FfbJ0zFCJbWig6DbE7Dm2wEe2B2x9ifTFQ9Q2J0hcaDIokrkaxyeIah+deSjKigFp3r0svgB12sc+a73vQz+LSHBAA9Mt0V2ct/zng7Y0MeYGs5+5Ojiyy3htwTf54JQnHiaO6bKlNIngEdHbIAwt+Z4EDsfgvYdEv51RMgR+IkgOQM39hMTY6xRp29JSlTjT32tCRFB2PpdYF/lRL2Yc=; 5:FrRCoHK51R6+/+w+TRDRQUz/FB0QL/MbIsDD7adG63Kd5+e2TY9ekLkWiaPm+/wX55mJjy3FDXF8uheFchMRUByVs5g9gWvveCaO3QASfwFdLY/RsQTQeHOq24dbP9xq1zdm6AENuupoWnXfEttEp9gtvIYJLR48IrHxGaa7hbs=; 24:RtkW4llS+NUEMtVXQWHMX3i1HqxGwwmGNk5oDxkwjCgaAI4CGUoQELzfr9xO7Ti+Lj/JBcl2o+DgobUWSgxbzl3ZQGOpTfA0hO30DTZoJYo=; 7:cTj/ZmiwWYBlqMms2B0+N/yqPwskL/YM4Vb0h1ZFnBPlX8tlhv/eoa7FY7lGFXh+yyno9Me1FSqvxtokTnUdAY1LGv7DVa1KZRfSV7nseV+N6oZiW4OIYPbWy99IKrW430puRiNsJx6JGA3ReOlWaAVzdNEYxb86++o/DGvitXPF2ElyMQkPXou9GjYcKHe+0ib6KtFzGLFOG4xcmO5RI3Ip34avmfZfVa2ZMFqOQk2JT766v/F8ubJLXy9EsowB x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 9baa3336-c4c5-4727-ac98-08d54941d2e5 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(5600026)(4604075)(3008031)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603307)(7153060); SRVR:BY1PR17MB0117; x-ms-traffictypediagnostic: BY1PR17MB0117: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(215639381216008); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(5005006)(8121501046)(3002001)(3231023)(944501043)(10201501046)(93006095)(93001095)(6041268)(20161123560045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(6072148)(201708071742011); SRVR:BY1PR17MB0117; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:BY1PR17MB0117; x-forefront-prvs: 05299D545B x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(39380400002)(396003)(346002)(39860400002)(376002)(366004)(189003)(199004)(13464003)(8676002)(105586002)(2906002)(2900100001)(3660700001)(8936002)(81166006)(5660300001)(6116002)(68736007)(3846002)(5250100002)(3280700002)(478600001)(81156014)(106356001)(2501003)(110136005)(316002)(97736004)(59450400001)(6506007)(6246003)(7696005)(53936002)(53546011)(14454004)(33656002)(76176011)(6436002)(25786009)(99286004)(66066001)(55016002)(2950100002)(9686003)(229853002)(305945005)(86362001)(74316002)(102836004)(7736002); DIR:OUT; SFP:1102; SCL:1; SRVR:BY1PR17MB0117; H:BY1PR17MB0120.namprd17.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: keysight.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: keysight.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9baa3336-c4c5-4727-ac98-08d54941d2e5 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Dec 2017 13:42:20.0731 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 63545f27-3232-4d74-a44d-cdd457063402 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR17MB0117 X-Original-Sender: richard_allen@keysight.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@keysighttech.onmicrosoft.com header.s=selector1-keysight-com header.b=shPFHNo+; spf=pass (google.com: domain of richard_allen@keysight.com designates 104.47.32.120 as permitted sender) smtp.mailfrom=richard_allen@keysight.com Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , Thanks! I appreciate this, should fix our issue. Dick -----Original Message----- From: Stefano Babic [mailto:sbabic@denx.de] Sent: Friday, December 22, 2017 1:41 AM To: swupdate@googlegroups.com Cc: ALLEN,RICHARD (K-SantaClara,ex1) ; Stefano Babic Subject: [PATCH 2/2] Drop filename length limit in CPIO extraction Signed-off-by: Stefano Babic Reported-by: Richard Alled --- corelib/installer.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) continue; if (!fromfile) { - if (snprintf(filename, sizeof(filename), "%s%s", - TMPDIR, img->fname) >= (int)sizeof(filename)) { + if (asprintf(&filename, "%s%s", TMPDIR, img->fname) == + ENOMEM_ASPRINTF) { ERROR("Path too long: %s%s", TMPDIR, img->fname); return -1; } @@ -304,11 +304,13 @@ int install_images(struct swupdate_cfg *sw, int fdsw, int fromfile) ret = stat(filename, &buf); if (ret) { TRACE("%s not found or wrong", filename); + free(filename); return -1; } img->size = buf.st_size; img->fdin = open(filename, O_RDONLY); + free(filename); if (img->fdin < 0) { ERROR("Image %s cannot be opened", img->fname); -- 2.7.4 diff --git a/corelib/installer.c b/corelib/installer.c index c63de49..4890e83 100644 --- a/corelib/installer.c +++ b/corelib/installer.c @@ -252,7 +252,7 @@ int install_images(struct swupdate_cfg *sw, int fdsw, int fromfile) { int ret; struct img_type *img; - char filename[64]; + char *filename; struct filehdr fdh; struct stat buf; const char* TMPDIR = get_tmpdir(); @@ -295,8 +295,8 @@ int install_images(struct swupdate_cfg *sw, int fdsw, int fromfile)