diff mbox series

kconfig: fix selects

Message ID 20240212182026.79702-1-daniel@braunwarth.dev
State Accepted
Headers show
Series kconfig: fix selects | expand

Commit Message

Daniel Braunwarth Feb. 12, 2024, 6:20 p.m. UTC
CMS_IGNORE_CERTIFICATE_PURPOSE and CMS_SKIP_UNKNOWN_SIGNERS should only
be selected if SIGALG_CMS is selected, too.

This fixes the following two warnings:
warning: (SSL_IMPL_WOLFSSL) selects CMS_IGNORE_CERTIFICATE_PURPOSE which has unmet direct dependencies (SIGALG_CMS)
warning: (SSL_IMPL_WOLFSSL) selects CMS_SKIP_UNKNOWN_SIGNERS which has unmet direct dependencies (SIGALG_CMS)

Signed-off-by: Daniel Braunwarth <daniel@braunwarth.dev>
---
 Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Stefano Babic Feb. 12, 2024, 9:09 p.m. UTC | #1
Hi Daniel,

On 12.02.24 19:20, Daniel Braunwarth wrote:
> CMS_IGNORE_CERTIFICATE_PURPOSE and CMS_SKIP_UNKNOWN_SIGNERS should only
> be selected if SIGALG_CMS is selected, too.
>
> This fixes the following two warnings:
> warning: (SSL_IMPL_WOLFSSL) selects CMS_IGNORE_CERTIFICATE_PURPOSE which has unmet direct dependencies (SIGALG_CMS)
> warning: (SSL_IMPL_WOLFSSL) selects CMS_SKIP_UNKNOWN_SIGNERS which has unmet direct dependencies (SIGALG_CMS)
>
> Signed-off-by: Daniel Braunwarth <daniel@braunwarth.dev>
> ---
>   Kconfig | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Kconfig b/Kconfig
> index 341f062..7139617 100644
> --- a/Kconfig
> +++ b/Kconfig
> @@ -412,8 +412,8 @@ choice
>   	config SSL_IMPL_WOLFSSL
>   		bool "wolfSSL (with OpenSSL compatibility layer)"
>   		depends on HAVE_WOLFSSL
> -		select CMS_IGNORE_CERTIFICATE_PURPOSE
> -		select CMS_SKIP_UNKNOWN_SIGNERS
> +		select CMS_IGNORE_CERTIFICATE_PURPOSE if SIGALG_CMS
> +		select CMS_SKIP_UNKNOWN_SIGNERS if SIGALG_CMS
>
>   	config SSL_IMPL_MBEDTLS
>   		bool "mbedTLS"


Reviewed-by: Stefano Babic <stefano.babic@swupdate.org>
diff mbox series

Patch

diff --git a/Kconfig b/Kconfig
index 341f062..7139617 100644
--- a/Kconfig
+++ b/Kconfig
@@ -412,8 +412,8 @@  choice
 	config SSL_IMPL_WOLFSSL
 		bool "wolfSSL (with OpenSSL compatibility layer)"
 		depends on HAVE_WOLFSSL
-		select CMS_IGNORE_CERTIFICATE_PURPOSE
-		select CMS_SKIP_UNKNOWN_SIGNERS
+		select CMS_IGNORE_CERTIFICATE_PURPOSE if SIGALG_CMS
+		select CMS_SKIP_UNKNOWN_SIGNERS if SIGALG_CMS
 
 	config SSL_IMPL_MBEDTLS
 		bool "mbedTLS"