From patchwork Mon Jan 29 08:40:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Stefano Babic X-Patchwork-Id: 1892119 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.a=rsa-sha256 header.s=20230601 header.b=q2sJrxxH; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=googlegroups.com (client-ip=2a00:1450:4864:20::437; helo=mail-wr1-x437.google.com; envelope-from=swupdate+bncbaabbgwj3wwqmgqe3y4zzhi@googlegroups.com; receiver=patchwork.ozlabs.org) Received: from mail-wr1-x437.google.com (mail-wr1-x437.google.com [IPv6:2a00:1450:4864:20::437]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TNhbQ3gFtz23fD for ; Mon, 29 Jan 2024 19:41:05 +1100 (AEDT) Received: by mail-wr1-x437.google.com with SMTP id ffacd0b85a97d-33ae385775fsf711270f8f.1 for ; Mon, 29 Jan 2024 00:41:04 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706517659; cv=pass; d=google.com; s=arc-20160816; b=cty+NJw4tekxrHOCXKk/APGQssl9W9KKDSt7hM8AGTRDTheo2fvGPdRT531k5XP0Rz yv5JKbMOmsyYBCdQEL27yhBq5HDeTrXvHIgV2PLuIClGCN9IcbEOJr5aF7YTfvQ3O6HJ sawGSwXqv5HIQLzW/0UnvPLR5XGxJjelFCZ6+DWT9cQBbbU3DmG0SHlApSXTVr17OLPG WFulRvJqLOhiDYJfdPf/U2tb11zceTCGLEeXU4WDX2wuVKnPddhhV1KmmV1D9AjaAryy GkUpOT8CVGDg371RyqhMIpT+q/RhvY1oA9sJsP/cPwyLxpXSo0JaIupRbQgbtooK7EzR LCyg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:ui-outboundreport :content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:dkim-signature; bh=JwoXrCBJdRL/n2BDttu3RMxG6qeTX4uHwgJy0qCHKBI=; fh=TiEWcqMcKpHk5s7uErzpntoONrNfOXwKpI5P8bIlggk=; b=AdbADS0KU280w4eRbr41uadN8Asst+a6bXQMYzjascJUnrBj6mFDkBuAO+pw+KQRwO Uc0/f/UMRzCw2rntsdQro2+P0oGiStzg6jETJcpb7Ug4R8Rdtk4YJSLEvkd0ZHbsv1sF y0+FYmWiZqmKBeOm5sfCbwUCY0C3P5g6Wn/VZQ4Tqe7jMN4IX+QySGLE7NLEoo4rrvDE th+qcuP41yQ7C0OOlpFhs0p6NhdrFvs+XC3ojZe2X2fPiKD1dvJfmW7FZzOZY+VyMc5q qKUFIHSPPxq18vBYw+uWiz5DppkgPQQqlZRAsAPLX8GbkQ63ML48en7s0LIiPatnqHZb wTHw== ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=pass (google.com: domain of stefano.babic@swupdate.org designates 212.227.126.187 as permitted sender) smtp.mailfrom=stefano.babic@swupdate.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1706517659; x=1707122459; darn=patchwork.ozlabs.org; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:ui-outboundreport:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:sender:from:to:cc :subject:date:message-id:reply-to; bh=JwoXrCBJdRL/n2BDttu3RMxG6qeTX4uHwgJy0qCHKBI=; b=q2sJrxxHyvf3wXsBP5cLO4QqAtrfXU4HqkBq4JzpFP7mGh5QmeHYfhoafqcqQL3eRz 6RFMhKXBSC58JEM7NuKU9gprP2UTJ0kHUyOjDCpzRqZOAnCeEDRmHQzGrVYOpROEd7qX /CVWg0qe76vCwVRYZEv4UZXxPo5iLE8cZe4zmaOh2fftkVQYzgDqlDdL+txddV+QBL7f 2A7bNAtvbRtrYVz0UHi2WTwqlhKriUgiNckWAxERIOusZC2KJqryPjxWnjlMoqnDLX6d zEofR/7CR8MT+FwkiPvsFieH4xiNtvRxOkQ5qM6ImkjH437Nrj5eIgTs5UqEl1zAlpcX cEJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706517659; x=1707122459; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender :ui-outboundreport:content-transfer-encoding:mime-version:message-id :date:subject:cc:to:from:x-beenthere:x-gm-message-state:sender:from :to:cc:subject:date:message-id:reply-to; bh=JwoXrCBJdRL/n2BDttu3RMxG6qeTX4uHwgJy0qCHKBI=; b=ITl0Z3lwKWC+eOD5Aej/2X2JQX3uJJuaCX/W85GVROMFc4FFC0rHjn8rrb1sJadbb7 /pf8Cv9sQZMPUKemVATFylkWH2yCfXVJrCyEfIJd4Cz6RiiODeuWdlU4mvX6yCzrPjIv ujJvzFa6jAH/HBS+2lYuVYp43v36Pf8Eb3oZ84VDNWrlRB9S/OKlnnvFVA4saYuWH4wO GDRVDbS+uy2BD4QA7xu7bF0VDikyEg/3+8PmEJXFQiwZc5TRJXguDbq84RtvVRR+pXIW qxXde9HKa7j/EzkOr6qI159UXemha/JoK2IHqt+NgbPwHoob1PhJlO1K5hZkrcdDYFUT k/8w== Sender: swupdate@googlegroups.com X-Gm-Message-State: AOJu0YweKGHvVcsjSwjY0/FIIcnePWXG2PaG29Sl6ocYF7JkjReT25bL 0oK3pz76ovcb0LJFGKK1xNG5Uta/FriMt08z5loesTbFFeaEnWei X-Google-Smtp-Source: AGHT+IGNQUkjsUgdrcFDOrJFs7nkhXvwnI48eCT66fjfQcCpiOQCd7CD+BoKqpkpcotSntSfC5ADHw== X-Received: by 2002:a5d:428c:0:b0:33a:e74e:8b04 with SMTP id k12-20020a5d428c000000b0033ae74e8b04mr2873441wrq.62.1706517659306; Mon, 29 Jan 2024 00:40:59 -0800 (PST) X-BeenThere: swupdate@googlegroups.com Received: by 2002:a05:6000:124e:b0:33a:e9f0:9365 with SMTP id j14-20020a056000124e00b0033ae9f09365ls305932wrx.0.-pod-prod-09-eu; Mon, 29 Jan 2024 00:40:57 -0800 (PST) X-Received: by 2002:a5d:428c:0:b0:33a:e74e:8b04 with SMTP id k12-20020a5d428c000000b0033ae74e8b04mr2873399wrq.62.1706517657483; Mon, 29 Jan 2024 00:40:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1706517657; cv=none; d=google.com; s=arc-20160816; b=HJ0UR+GhU7UnEgBNX61uGVtCxPA7tGB5jW/OnurRXx6u/R0po+B31IeNLhkxLTwuVs cQxFBUolj/qxoSeNqihw0mtekCgIwefY63Bfcbo3gTMxRxlKrCJULBs7AUHTi6gkZF7v iH1L/BARKtMYzRzSwlXT310asOsGHWo3zfqmpLNwQhYqU+tXJF1BfS/pM+Qnz8j79w9a FSP+m/+SC0lW9cmW5SifX6Hv5bCgy+bslE4B2UPHTb0TfShs6IEBhVmacrW3xQnPp8rN pqs+ltrPKJpGzoNNR0/gVyP3kfGjZJk0GCPJ+u0xetRnTLMPgDHlDy+3anogYdNB1yhF vZTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=ui-outboundreport:content-transfer-encoding:mime-version:message-id :date:subject:cc:to:from; bh=6mp8T73tYXMd76U2+9phaAtg7Z1UvKRpo0cjehE8zu0=; fh=TiEWcqMcKpHk5s7uErzpntoONrNfOXwKpI5P8bIlggk=; b=M0k9q27g8Ve2qkMDCO27hkNk3+jSnEqu6CBcw2fO7MNzbkVLPRqoAowousFy/pjKwQ sENfGI3tujFqKhrqRsQ6wwzIFopwa/kC9hcEBjHQjQkbfiY0OQqW37ASRq9C3KWNRuxI L9NFVb9zSg3t5wRQn7dvAamSGKZXMQsSqCXINl+TSTaoPNR7/8D1C/11Fw3SfBXVnk7Z gXGUeIajYgXmNnPCVufqrTC+uN2P8mdqFUjCFDZsKQZJLiAFrR09ChyRnyhwT5cdbxok cZHQBZDkghOgz9p/6s3nubPjc3/kriaors3E5zUrwcZ9IlCZraKQVxU6d3OuGCVP4cxN ASYQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of stefano.babic@swupdate.org designates 212.227.126.187 as permitted sender) smtp.mailfrom=stefano.babic@swupdate.org Received: from mout.kundenserver.de (mout.kundenserver.de. [212.227.126.187]) by gmr-mx.google.com with ESMTPS id s9-20020adff809000000b0033aec4c32f9si94980wrp.5.2024.01.29.00.40.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jan 2024 00:40:57 -0800 (PST) Received-SPF: pass (google.com: domain of stefano.babic@swupdate.org designates 212.227.126.187 as permitted sender) client-ip=212.227.126.187; Received: from paperino.fritz.box ([88.217.136.221]) by mrelayeu.kundenserver.de (mreue009 [213.165.67.97]) with ESMTPSA (Nemesis) id 1MQMm9-1rhFNZ3aef-00MMpN; Mon, 29 Jan 2024 09:40:56 +0100 From: Stefano Babic To: swupdate@googlegroups.com Cc: Stefano Babic Subject: [swupdate] [PATCH] Fix warning in raw_handler Date: Mon, 29 Jan 2024 09:40:55 +0100 Message-Id: <20240129084055.13014-1-stefano.babic@swupdate.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Provags-ID: V03:K1:I5Icw6O323xk/eBqqH3Lr5OlwSdtcMgNVxgIDSQNw8qmUFH938C LmfJmEPz3cc7s+sXuLAerQ2KEQtCxj22i0RVsVrh7OezbqpaxeuRaTbTz5JEgF42VERovfY JhCwoF1vQwf4pL7WBQkRdrV6NyRx1vgqTob9F034LLaLzxm07u6ZqCUvFo3vHef5MB4e08I PMqb2O8LQGWFiLYtjrUHw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:L95uuZ16w/E=;cgIcXnHBIGsXXodIPG0LZb5Uex2 2nuJ7JpfOJHr8hFFXpD5TJhaTUpylgtyEhwWpDVyG9uZ/rcS+aNlkACzflkLaLXY+AU/VDWF0 sYHKromXoi4VSRH0Dd1qtGkbi/OBlkv5qjmLOOMg/0GyuLBZZOUm080XQafIkIKI3T+5D0/X7 tStGkvcu5raF33dYYq2P2gK1XBMokHgEazTKECLa29SDj/n9Pk8aybHI3QyEGqV8R0HFiXUbg LU3QjdJcemYv3DVo1j0iKzCODTC5drtCJQJ40Jyct22WRYqM5jrzXzBb5BX5GHxo20xKL+n8R 6o6Ahz1a3+WrFw1HtCKp7sqJgrFRBygWxLjTKSjth0j+4ua03EYquSEYa44Gurt1FtboMdj1S gZzTPYMIsWFK5V2XIO4jDoVUlXmhuIvS+clBI8s2KnwOrxPTDxjFAFIf3lEyUmkSc8u/6jX2Y Ew8ir1ZACqDhJzsIy/BqZrvRIjCr71ADIEPqWufvugPTM/ulzrI0SHpxY0hIESrMS8nXEETlx B+eO29FS4l+DPHwMja2Gj+bbe9ViGoxYt2GylZrZZXeTaodeYqEK7yEFQrPhAeAQ/dWOOh+2t exgaTHiE4czTBcMqvAv7V5q2H82TXOmitP+0suBZsCYt3KgxhZob0g4uzBOmDhcvjKZVHCgiG V5NoyEskOz4gOIsLm4kUdTHW3z3/CHh4PEPZfUIei6fR28hGmfcAYwdNQm7JvpXJOFbf7Fs1K 51kZ0D+WhzUeOYfJU1FKGeP7VjcbJcYAlQmFTrSVDtvzGHK0Mn04zP2PcQHMS4CxoXOOSM/TB 3p5B3Onc2f29sPJ+FwDQRmz2PUxfI3yYdCs0WKyh8yC9NUwgqPPKlG7QoYwrnXJ/MVQdhvalM LNCRw/pSbjttQeloQl0Zanarn+oIpCOkpSz0= X-Original-Sender: stefano.babic@swupdate.org X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of stefano.babic@swupdate.org designates 212.227.126.187 as permitted sender) smtp.mailfrom=stefano.babic@swupdate.org Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , handlers/raw_handler.c:253:27: warning: ‘cleanup_ret’ may be used uninitialized in this function [-Wmaybe-uninitialized] 253 | return (ret ? ret : cleanup_ret); Signed-off-by: Stefano Babic --- handlers/raw_handler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/handlers/raw_handler.c b/handlers/raw_handler.c index 4e9b3a43..00297622 100644 --- a/handlers/raw_handler.c +++ b/handlers/raw_handler.c @@ -153,7 +153,7 @@ static int install_raw_file(struct img_type *img, char tmp_path[255]; int fdout = -1; int ret = -1; - int cleanup_ret; + int cleanup_ret = 0; int use_mount = (strlen(img->device) && strlen(img->filesystem)) ? 1 : 0; char* DATADST_DIR = alloca(strlen(get_tmpdir())+strlen(DATADST_DIR_SUFFIX)+1); sprintf(DATADST_DIR, "%s%s", get_tmpdir(), DATADST_DIR_SUFFIX);