diff mbox series

[V3,02/10] util: BUG: __swupdate_copy accepts invalid ivt

Message ID 20231215142251.52393-3-Michael.Glembotzki@iris-sensing.com
State Changes Requested
Headers show
Series Add support for asymmetric decryption | expand

Commit Message

Michael Glembotzki Dec. 15, 2023, 2:19 p.m. UTC 
Signed-off-by: Michael Glembotzki <Michael.Glembotzki@iris-sensing.com>
---
 core/cpio_utils.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff mbox series

Patch

diff --git a/core/cpio_utils.c b/core/cpio_utils.c
index f2bfdb5..5b99904 100644
--- a/core/cpio_utils.c
+++ b/core/cpio_utils.c
@@ -514,9 +514,9 @@  static int __swupdate_copy(int fdin, unsigned char *inbuf, void *out, size_t nby
 
 	if (encrypted) {
 		aes_key = get_aes_key();
-		if (imgivt && strlen(imgivt)) {
-			if(ascii_to_bin(ivtbuf, sizeof(ivtbuf), imgivt)) {
-				ERROR("invalid image ivt length");
+		if (imgivt) {
+			if (!strlen(imgivt) || !is_hex_str(imgivt) || ascii_to_bin(ivtbuf, sizeof(ivtbuf), imgivt)) {
+				ERROR("Invalid image ivt");
 				return -EINVAL;
 			}
 			ivt = ivtbuf;