diff mbox series

Fix coverity CID 355687: Error handling issues

Message ID 20220807092613.450929-1-sbabic@denx.de
State Accepted
Headers show
Series Fix coverity CID 355687: Error handling issues | expand

Commit Message

Stefano Babic Aug. 7, 2022, 9:26 a.m. UTC
(CHECKED_RETURN): Calling "get_hw_revision" without checkin
return value (as is done elsewhere 5 out of 6 times).

Signed-off-by: Stefano Babic <sbabic@denx.de>
---
 parser/parser.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/parser/parser.c b/parser/parser.c
index 64710e4..cf2b324 100644
--- a/parser/parser.c
+++ b/parser/parser.c
@@ -925,7 +925,9 @@  static int parser(parsertype p, void *cfg, struct swupdate_cfg *swcfg)
 			return -1;
 		}
 	}
-	get_hw_revision(&swcfg->hw);
+	if (get_hw_revision(&swcfg->hw) < 0) {
+		TRACE("Hardware compatibiliy not found");
+	}
 
 	/* Now parse the single elements */
 	ret = parse_hw_compatibility(p, cfg, swcfg) ||