Message ID | 20220807092613.450929-1-sbabic@denx.de |
---|---|
State | Accepted |
Headers | show
Return-Path: <swupdate+bncBCXPLOXJ6IKRBPUKX2LQMGQET5WCWXA@googlegroups.com> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.a=rsa-sha256 header.s=20210112 header.b=ltY056LL; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=googlegroups.com (client-ip=2a00:1450:4864:20::43a; helo=mail-wr1-x43a.google.com; envelope-from=swupdate+bncbcxploxj6ikrbpukx2lqmgqet5wcwxa@googlegroups.com; receiver=<UNKNOWN>) Received: from mail-wr1-x43a.google.com (mail-wr1-x43a.google.com [IPv6:2a00:1450:4864:20::43a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4M0v8z72rxz9s5W for <incoming@patchwork.ozlabs.org>; Sun, 7 Aug 2022 19:26:26 +1000 (AEST) Received: by mail-wr1-x43a.google.com with SMTP id u17-20020adfa191000000b0021ed2209fccsf1017663wru.16 for <incoming@patchwork.ozlabs.org>; Sun, 07 Aug 2022 02:26:25 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1659864383; cv=pass; d=google.com; s=arc-20160816; b=Eclj2QduYxo5cSa1KZD6SnQViqF6m90r3szt8pK7DDhPCbnv63913hsgEjuMQMD8dL dz4lEU2iV6nC4xvz5dqtR3fWqc27WUY7Muh0Vo0yJRRynIJZEQpyafAarx7FV46wqz0R Ir5b9qACydDDEVbGKStm0OAWIfHlwMpqfQF8jD3iM6MhUNRVcsVED87ySPE/VZ8yeQo+ EJSwFA7trwI90SyMZRGlpqL/qTjDUKIMw2uePNtrCIE2PLLfzw+/sLaf4HKbNtquJ6Jp oDsrPu7XU20aMI2QYIFTC2dguWu3g+7qFEG1bPAyT8gnsYvDczsDGfsdtebtGqirbPsB 1NLQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:message-id:date :subject:cc:to:from:sender:dkim-signature; bh=s8BG9QKGuuEr3Ds5hVfkC8Judd2p/QjzyEgS1lwDHB0=; b=HzHkozNAUP57G/wdQvBg6lw/cMHjyVHVcpifcLUIHKCetDJDeg6PZAVqmg5tmasq60 R8ScLMsv70TS3OSVq5eQCuYgoXDVRocZVPKFXz0bt7BhnmfnP63am4D9SYeDjsIkGF3i 1pUvOtsw6KeEjNSNJPyGMA4am6ons6uwHiOLO9+8MvTioNWW1n6IqbDaGY/3IB2yRISG BfE2zQ1rf7Dwbp0RiRbPuTscukajHkZRsDDW2qyp9T5DnerBocIaH75CeQEvzWJPOrXD wHQ906vgvLboRJKZvEOy+5iFTKyrIbDmFlH2VMAvn+ZLBWGGV5EwBTnpjUS5wMy9Yph4 pneQ== ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=neutral (google.com: 212.18.0.10 is neither permitted nor denied by domain of sbabic@denx.de) smtp.mailfrom=sbabic@denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20210112; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:message-id:date:subject:cc:to:from :sender:from:to:cc; bh=s8BG9QKGuuEr3Ds5hVfkC8Judd2p/QjzyEgS1lwDHB0=; b=ltY056LLQWKcu0chUsuTZ4SiBTZLe0OqnAm22sOTKkQdaZLvdHfKCoeYBFyGXGHwHk sZKJxWX6L3V0iM86pHYdwL4tqsrXnFkuKQdYxODIbx+GQj4h0cAcrWN7CYTQVQUj0oCl TLRLbjrzTY3DZ24gL88TYcZN+P2HJuRdK0yvgJdknJ3pNQnUqsapY/Psy5itY2YG63QG qgh+R1nxUWEdZZn5hoKTYMUIH0n2tLrVKNxlaPWkLy9F4/EJrDIa8s0GcbFO+QTjAfhg DE+Dl1XiTpj1EwxFAQ7KAeco3FlRGMQdF7DoV/Nesxzg2Nvr400qIdOQWcGf2nBK4WfJ QP/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :message-id:date:subject:cc:to:from:x-gm-message-state:sender:from :to:cc; bh=s8BG9QKGuuEr3Ds5hVfkC8Judd2p/QjzyEgS1lwDHB0=; b=zhtGv7fJpvBsFWQrEmGDOMVq9OxTLbpDbTkQ2ruYOPJwU9r5esN27yUq/M0G9PCD04 dq9KSsXMsKt48DCxl5FgBmPPSPlaMeBtq/vtNwG8eRzWRbQ9fiyz6USPvcXjaE2MxfLm KHiGqjwoF3dqTA6g08+DA8+wFBH3z47yd9slxZJ90UodQzOS9oZicwhTgg4/RxB0TQ+A RpAY45C8bKcNDaz/Y9mBHnRmaQUykQqmR2XaZl4kY11kLbQ3+vj/5CLxj7iDo8hU0d/b yLnCTo4ihGnKcePbDpAecc1nY7QkEYbI+JLyup+y+N9aHHx792a5zjf3Gug1cJWLVNyj qO2w== Sender: swupdate@googlegroups.com X-Gm-Message-State: ACgBeo1VVkwIEPo/6hyYwge7EpIrnSD2VDRQOET5bZrxHb+Nr65aNoEC SvffM/K4qWKq7VkoOXbOLD8= X-Google-Smtp-Source: AA6agR4BYah5sT/9dXuT6zr2mHtSN4+86Bd0pJYmQ364QpLj+WKsQaT1Xc9R3pM6BfJF5RGiK4WwDQ== X-Received: by 2002:a05:600c:3c8a:b0:3a0:4ad8:d3c4 with SMTP id bg10-20020a05600c3c8a00b003a04ad8d3c4mr14575422wmb.43.1659864383357; Sun, 07 Aug 2022 02:26:23 -0700 (PDT) X-BeenThere: swupdate@googlegroups.com Received: by 2002:a5d:5a90:0:b0:220:80cc:8add with SMTP id bp16-20020a5d5a90000000b0022080cc8addls4186672wrb.2.-pod-prod-gmail; Sun, 07 Aug 2022 02:26:22 -0700 (PDT) X-Received: by 2002:a05:6000:186f:b0:222:c091:9c59 with SMTP id d15-20020a056000186f00b00222c0919c59mr3145302wri.78.1659864382102; Sun, 07 Aug 2022 02:26:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659864382; cv=none; d=google.com; s=arc-20160816; b=ebqGu/AseDidyszPrQim3X/4WIlL9XEYLIFnKIGyNDAMIrHbFF/+uZiBRbuDd3Htfi OMMvd/QpJmQE4JTRU7pY/4sgx5SFY293I2dC+I6SpYdDL1IdSE4vlMhdHQEPS94bxbBZ jFaEPfPAP5jXUGhqWU0vrUAKybrTmzloDqEkihOYYFP17HC4lplpfjMwz9EaQ6VgV8ko n2Dek5qRPS7DWs7YX/aov4g83wY7gh6kYDI+kIG0vYMnWddQKO/G1fJ4uhVh7IIbVdi1 yosCBkChBfLq1DUJr9Iz6VO1u4NkOUcXpRi05h6I4bPLfid4JL86FJdej11pJkB6dMBd FsOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from; bh=sErMbLnD9RGV8IONnm6hKK0AM+AAuNLel6UMzE00Qm8=; b=LV5FCKvLTPfxX4fPZZ3AXKzdP8Uv73Q75pghPDCutkDrGdb50S2nWKR0+QmJcyC70V fX3l2oH+p2gCzhXIkYpBpijAW6ecXX6wuSyLpAInJqb42SXlkZxdbxM/AdB+xqBLtezr fjAznFRgo2Jtt+cBLRC4Uu2nT9OTTL5PLGsypWZPieJkg8AlPaZYkiiPnFNdq2Bd6uhz vqg+w4HDB5eaggBzcoMFsuusj4vq/fUF9ZpdSHowmNBAQ4wbxrWY7ztAIS4Y0pIOur8K opAbJrhYXmuQ6+2W8LFmHdWrAnm2Il0mDOyajROrgsC6rl2oCXZQM+GCSQlHmYLPhZ66 ReqA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 212.18.0.10 is neither permitted nor denied by domain of sbabic@denx.de) smtp.mailfrom=sbabic@denx.de Received: from mail-out.m-online.net (mail-out.m-online.net. [212.18.0.10]) by gmr-mx.google.com with ESMTPS id h10-20020a05600016ca00b0021d91e1ca87si204245wrf.1.2022.08.07.02.26.22 for <swupdate@googlegroups.com> (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 07 Aug 2022 02:26:22 -0700 (PDT) Received-SPF: neutral (google.com: 212.18.0.10 is neither permitted nor denied by domain of sbabic@denx.de) client-ip=212.18.0.10; Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4M0v8s6Xvrz1s89D; Sun, 7 Aug 2022 11:26:21 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4M0v8s0YGdz1qqkD; Sun, 7 Aug 2022 11:26:21 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id XhVc-C_JYWmK; Sun, 7 Aug 2022 11:26:20 +0200 (CEST) Received: from babic.homelinux.org (host-88-217-136-221.customer.m-online.net [88.217.136.221]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS; Sun, 7 Aug 2022 11:26:19 +0200 (CEST) Received: from localhost (mail.babic.homelinux.org [127.0.0.1]) by babic.homelinux.org (Postfix) with ESMTP id E620045412EA; Sun, 7 Aug 2022 11:26:17 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at babic.homelinux.org Received: from babic.homelinux.org ([127.0.0.1]) by localhost (mail.babic.homelinux.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UhWGirX4qPEC; Sun, 7 Aug 2022 11:26:14 +0200 (CEST) Received: from paperino.fritz.box (paperino.fritz.box [192.168.178.48]) by babic.homelinux.org (Postfix) with ESMTP id B4A7145412C6; Sun, 7 Aug 2022 11:26:14 +0200 (CEST) From: Stefano Babic <sbabic@denx.de> To: swupdate@googlegroups.com Cc: Stefano Babic <sbabic@denx.de> Subject: [swupdate] [PATCH] Fix coverity CID 355687: Error handling issues Date: Sun, 7 Aug 2022 11:26:13 +0200 Message-Id: <20220807092613.450929-1-sbabic@denx.de> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Original-Sender: sbabic@denx.de X-Original-Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 212.18.0.10 is neither permitted nor denied by domain of sbabic@denx.de) smtp.mailfrom=sbabic@denx.de Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: <swupdate.googlegroups.com> X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: <https://groups.google.com/group/swupdate/post>, <mailto:swupdate@googlegroups.com> List-Help: <https://groups.google.com/support/>, <mailto:swupdate+help@googlegroups.com> List-Archive: <https://groups.google.com/group/swupdate List-Subscribe: <https://groups.google.com/group/swupdate/subscribe>, <mailto:swupdate+subscribe@googlegroups.com> List-Unsubscribe: <mailto:googlegroups-manage+605343134186+unsubscribe@googlegroups.com>, <https://groups.google.com/group/swupdate/subscribe> |
Series |
Fix coverity CID 355687: Error handling issues
|
expand
|
diff --git a/parser/parser.c b/parser/parser.c index 64710e4..cf2b324 100644 --- a/parser/parser.c +++ b/parser/parser.c @@ -925,7 +925,9 @@ static int parser(parsertype p, void *cfg, struct swupdate_cfg *swcfg) return -1; } } - get_hw_revision(&swcfg->hw); + if (get_hw_revision(&swcfg->hw) < 0) { + TRACE("Hardware compatibiliy not found"); + } /* Now parse the single elements */ ret = parse_hw_compatibility(p, cfg, swcfg) ||
(CHECKED_RETURN): Calling "get_hw_revision" without checkin return value (as is done elsewhere 5 out of 6 times). Signed-off-by: Stefano Babic <sbabic@denx.de> --- parser/parser.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)