From patchwork Tue Mar 8 08:53:50 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gary Bisson X-Patchwork-Id: 1602825 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.a=rsa-sha256 header.s=20210112 header.b=GKvLUd90; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=googlegroups.com (client-ip=2607:f8b0:4864:20::e38; helo=mail-vs1-xe38.google.com; envelope-from=swupdate+bncbcl5ryhm6ecrbu5ttsiqmgqezwz737y@googlegroups.com; receiver=) Received: from mail-vs1-xe38.google.com (mail-vs1-xe38.google.com [IPv6:2607:f8b0:4864:20::e38]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4KCTfZ4tfLz9sGF for ; Tue, 8 Mar 2022 19:54:46 +1100 (AEDT) Received: by mail-vs1-xe38.google.com with SMTP id w185-20020a6762c2000000b0031e8c62b987sf1949356vsb.10 for ; Tue, 08 Mar 2022 00:54:46 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1646729684; cv=pass; d=google.com; s=arc-20160816; b=HxTYXbW9iK3F+XrD/kSoW8bqCPvipuJ8pFDfz5Z7oxALIUzq4dc0Ds9ZeETzOrEJTT ywkq4umxHQOCYQI0zAtyDIFC3LSlGIbb601R+c4ukqRM9BraR71+5ybPL7T5oUKWYBmJ /Xg+w6bnqPanwrwHZg3nkgyXqDTpAwFl2X2Wdv/xDHnmfK6jyi7P5gR/bgwGp4iJAqVi 2J8JoCaIAAQRaN9PQSUZJeh3yzeEQOqUtCAIXZUhKwBo+fQ4g86XLJI4J2qmmWyeTUWk LqefIR+cEAebdbNCcLDj3SoiF1qI0JvIX3tyCKS4PgYPqy7n6iFkyzSfybvMH11eS1D4 39iw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:dkim-signature; bh=oGt3y9dFdrVmX3xPxyVtuxEaFE6TvdluLvsVxMGJ3T0=; b=F2r3tSnoiQp1/snxUPiBCmvf4y3NS2G55uXtgkIrep8hSMjQy4ybk2mMoiBG5evtWL kgVW8ijgyk2qeZzOGKBUAE6mkrE3tS/ao5kXw414QKePlGy+1tyZDdfsUS41X8Z1l9cm 8O617cmqf6eCKSBZYr3Ygbum98F0dOONeF9kYZlFHipQphyMYEGb8bUpnAzMolnEH+CR a0UZIDCpU7arHuypTyme54i2DeVOFXYmZj07H2Sn/YRAR5rxnzvZEOsBIO0vWTTQiDCl tmRI/CPjOanBzjq/m+ZiM2zbTOSkQQ7QgIp4APuNYkDRDVA+ZC4xNZfqUke0cAJXtiRi 0k+w== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@boundarydevices.com header.s=google header.b=a+NwtZ7k; spf=pass (google.com: domain of gary.bisson@boundarydevices.com designates 2607:f8b0:4864:20::102f as permitted sender) smtp.mailfrom=gary.bisson@boundarydevices.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=boundarydevices.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=oGt3y9dFdrVmX3xPxyVtuxEaFE6TvdluLvsVxMGJ3T0=; b=GKvLUd90jpXZIZVPvAyOVfWumPNmkV1s2eoENxLrew3SvAnT+FozlnsY5nYYGy0v5i /JoLzBV41iMVoBmIvmwZK29mV8SpI6FSp1AmTDFeRkwmQkErvPwYn+Xtsoh3P5kFYzNX Rh7RyXfLtcnkZBMWE6gcf2JyJG+A4cr2Smf4IfWmxtoNKON08BSxISEnXIV0yGFYXbFV vqwI+EFkx+8PUXjWl/Nu9PwLZui01nmc31oFI6VkztSmqVDUKP590AhfBQm/0C71wWRt i/Rk5Wsx3GGTHb8hZugq5dB26Nn33J3d6Gbil9n4bUcaFKW1LmapfdaucCmZZzV/9UXS TZgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=sender:x-gm-message-state:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-spam-checked-in-group:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=oGt3y9dFdrVmX3xPxyVtuxEaFE6TvdluLvsVxMGJ3T0=; b=o6sZI1f6UiBFnrpcfeKbCAQeaxjEak/AlsuCfioahthfa+Ba+83NsYxYMUHoAiX3tX kLSW6UnPPdSsQZl5DWoeIxZ+udFxItFZtuCSiKa2tnV3AI0/pEpXPOd6CIweYgLTfOzZ 3XxGtBl66umv4vqohhTvUeNdXxyWqE++RCs8rBjEkH2w957ycJotbTbP+SCI23M+y7mi FQIEFM5qXBP6UzKOMGELHr8oaPoCsCxyYI0+2B+p++qqFxHNDE6rp8VA9zp2CxNMOMZN fSZeZdCzNIrKLxB2PmBGCJI+3K4N5YxbElqL5okPECRVnqTgk5AqjcMM81Gu18ltIEDo CRXA== Sender: swupdate@googlegroups.com X-Gm-Message-State: AOAM531cWfuCKWKK3OMjc5EVredt9YyIsBZaRYPGwR8WEfHlq9e++x2X HEDmXuen6tGpd+IO13bwczE= X-Google-Smtp-Source: ABdhPJypuRpf2R3mS0BnwJ4KPdvfIaw5ONuRCVa33D/1Sh1ipWTiLh648qBkvkc9tw4i5vhKh5CruQ== X-Received: by 2002:a05:6102:3f4f:b0:320:7f38:381c with SMTP id l15-20020a0561023f4f00b003207f38381cmr6388674vsv.53.1646729683933; Tue, 08 Mar 2022 00:54:43 -0800 (PST) X-BeenThere: swupdate@googlegroups.com Received: by 2002:ab0:36d8:0:b0:346:3872:d9d7 with SMTP id v24-20020ab036d8000000b003463872d9d7ls1060589uau.1.gmail; Tue, 08 Mar 2022 00:54:43 -0800 (PST) X-Received: by 2002:ab0:2b15:0:b0:346:afa1:d58d with SMTP id e21-20020ab02b15000000b00346afa1d58dmr5178504uar.101.1646729683435; Tue, 08 Mar 2022 00:54:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646729683; cv=none; d=google.com; s=arc-20160816; b=BHmbqrSQq4G8/X3tvYDo8ucbWuNHMynOVqXJ1ogFePA5WvpcHHxljZZ8330LalRt7z LDG0FTrIbxiWsNN+aKK94KcLKRZ4RdwN+1KLLfeQj5jqSIake6rDYN6nGM9NaYjaGoeO dNgM7x8nDeAKyzLYOnGEk9fAHCsLK8bA6UwsO+6onbBGi1iTDOxelqMBGUjaE2NlKCaE R8BBAtRHoJmG/bHmPUmiwpVjRKQ1y5WoSLH/4D7/AukUn89BVRFkTrS0vxcN8fLsxZ2w TY/7Slay72Y6xA31FE+bEwyobbTOsn8b1aJenfG91l9XSnZH8q9a/4BLjTc5zddw42Of 3pdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=2dZy9rgnmbR4DloCC/uhx/oDx90n+0sLJs0bJiiq6/M=; b=zmdcDdpKmIh72ym2KhtxBYFvNvZKhcwfUhQuft5GboYUHiQi5RjODzxXRRucy0Ir/u Q/5xQP6Le+ERV6F+vrlFTE3KwPeFSIVilpqCp9Vg0FZ+IMabktJBF4Lw77kxK/nwkpwE UIw4XD7ZNNixXJ1pj9+H0tuDLV4lbeTVhlwISxGrdZD6RZ5GNQOYgyXhzE7MQKB05NDK xup5yQzryqI8ME9VPBuIenzuxFyB9m+RIinVqPezT09NHSclvE/ZJsgoNZanrnqzFUUq H76113vhs8OPxeqE4+6TRSU4qA5iZtge6TAzMvHNcR/TYdhAX+t0nVp4Agn1lxyt68CR PnwA== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@boundarydevices.com header.s=google header.b=a+NwtZ7k; spf=pass (google.com: domain of gary.bisson@boundarydevices.com designates 2607:f8b0:4864:20::102f as permitted sender) smtp.mailfrom=gary.bisson@boundarydevices.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=boundarydevices.com Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com. [2607:f8b0:4864:20::102f]) by gmr-mx.google.com with ESMTPS id p8-20020a67f308000000b0032279ac014bsi31761vsf.0.2022.03.08.00.54.43 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Mar 2022 00:54:43 -0800 (PST) Received-SPF: pass (google.com: domain of gary.bisson@boundarydevices.com designates 2607:f8b0:4864:20::102f as permitted sender) client-ip=2607:f8b0:4864:20::102f; Received: by mail-pj1-x102f.google.com with SMTP id 15-20020a17090a098f00b001bef0376d5cso1769340pjo.5 for ; Tue, 08 Mar 2022 00:54:43 -0800 (PST) X-Received: by 2002:a17:902:7595:b0:151:7b0b:11c4 with SMTP id j21-20020a170902759500b001517b0b11c4mr16841607pll.126.1646729682090; Tue, 08 Mar 2022 00:54:42 -0800 (PST) Received: from localhost.localdomain (2a01cb0007fc20008a20f9fbd85df515.ipv6.abo.wanadoo.fr. [2a01:cb00:7fc:2000:8a20:f9fb:d85d:f515]) by smtp.gmail.com with ESMTPSA id mp10-20020a17090b190a00b001bf8453aea8sm1888132pjb.42.2022.03.08.00.54.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Mar 2022 00:54:41 -0800 (PST) From: Gary Bisson To: swupdate@googlegroups.com Cc: Gary Bisson Subject: [swupdate] [PATCH v2 4/6] uboot_env: remove unused parameters Date: Tue, 8 Mar 2022 09:53:50 +0100 Message-Id: <20220308085352.183941-5-gary.bisson@boundarydevices.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220308085352.183941-1-gary.bisson@boundarydevices.com> References: <20220306132635.220607-1-gary.bisson@boundarydevices.com> <20220308085352.183941-1-gary.bisson@boundarydevices.com> MIME-Version: 1.0 X-Original-Sender: gary.bisson@boundarydevices.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@boundarydevices.com header.s=google header.b=a+NwtZ7k; spf=pass (google.com: domain of gary.bisson@boundarydevices.com designates 2607:f8b0:4864:20::102f as permitted sender) smtp.mailfrom=gary.bisson@boundarydevices.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=boundarydevices.com Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , Signed-off-by: Gary Bisson --- Changelog v1->v2: - None --- src/uboot_env.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/uboot_env.c b/src/uboot_env.c index 9993142..d83ca96 100644 --- a/src/uboot_env.c +++ b/src/uboot_env.c @@ -134,7 +134,7 @@ static struct var_entry *__libuboot_get_env(struct vars *envs, const char *varna return NULL; } -static void free_var_entry(struct vars *envs, struct var_entry *entry) +static void free_var_entry(struct var_entry *entry) { if (entry) { LIST_REMOVE(entry, next); @@ -150,7 +150,7 @@ static void remove_var(struct vars *envs, const char *varname) entry = __libuboot_get_env(envs, varname); - free_var_entry(envs, entry); + free_var_entry(entry); } static enum device_type get_device_type(char *device) @@ -347,7 +347,7 @@ static int normalize_device_path(char *path, struct uboot_flash_env *dev) return 0; } -static int check_env_device(struct uboot_ctx *ctx, struct uboot_flash_env *dev) +static int check_env_device(struct uboot_flash_env *dev) { int fd, ret; struct stat st; @@ -1254,7 +1254,7 @@ int libuboot_read_config(struct uboot_ctx *ctx, const char *config) free(tmp); } - if (check_env_device(ctx, dev) < 0) { + if (check_env_device(dev) < 0) { retval = -EINVAL; break; } @@ -1350,7 +1350,7 @@ int libuboot_set_env(struct uboot_ctx *ctx, const char *varname, const char *val if (entry) { if (libuboot_validate_flags(entry, value)) { if (!value) { - free_var_entry(envs, entry); + free_var_entry(entry); } else { free(entry->value); entry->value = strdup(value); @@ -1449,7 +1449,7 @@ int libuboot_configure(struct uboot_ctx *ctx, if (!ctx->size) ctx->size = dev->envsize; - if (check_env_device(ctx, dev) < 0) + if (check_env_device(dev) < 0) return -EINVAL; if (i > 0) {