diff mbox series

CI: add missing dependency libpci-dev

Message ID 20211006061017.273752-1-michael.adler@siemens.com
State Accepted
Headers show
Series CI: add missing dependency libpci-dev | expand

Commit Message

Michael Adler Oct. 6, 2021, 6:10 a.m. UTC 
libpci-dev is a dependency of efibootguard

Signed-off-by: Christian Storm <christian.storm@siemens.com>
Signed-off-by: Michael Adler <michael.adler@siemens.com>
---
 ci/setup.sh | 1 +
 1 file changed, 1 insertion(+)

Comments

Stefano Babic Oct. 6, 2021, 9:52 a.m. UTC | #1 
Hallo Michael,

On 06.10.21 08:10, Michael Adler wrote:
> libpci-dev is a dependency of efibootguard
> 
> Signed-off-by: Christian Storm <christian.storm@siemens.com>
> Signed-off-by: Michael Adler <michael.adler@siemens.com>
> ---
>   ci/setup.sh | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/ci/setup.sh b/ci/setup.sh
> index af522d0..559cbf7 100755
> --- a/ci/setup.sh
> +++ b/ci/setup.sh
> @@ -52,6 +52,7 @@ $_SUDO apt-get install -y \
>       libwebsockets-dev \
>       libgpiod-dev \
>       libcurl4-openssl-dev \
> +    libpci-dev \
>       gawk \
>       cpio \
>       wget
> 

Thanks, I merge into master.

Reviewed-by: Stefano Babic <sbabic@denx.de>

Best regards,
Stefano
Stefano Babic Oct. 6, 2021, 10:23 p.m. UTC | #2 
Hi Michael,

On 06.10.21 08:10, Michael Adler wrote:
> libpci-dev is a dependency of efibootguard
> 
> Signed-off-by: Christian Storm <christian.storm@siemens.com>
> Signed-off-by: Michael Adler <michael.adler@siemens.com>
> ---
>   ci/setup.sh | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/ci/setup.sh b/ci/setup.sh
> index af522d0..559cbf7 100755
> --- a/ci/setup.sh
> +++ b/ci/setup.sh
> @@ -52,6 +52,7 @@ $_SUDO apt-get install -y \
>       libwebsockets-dev \
>       libgpiod-dev \
>       libcurl4-openssl-dev \
> +    libpci-dev \
>       gawk \
>       cpio \
>       wget
> 

I merged, but this breaks build, see:

https://source.denx.de/swupdate/swupdate/-/jobs/332320

Regards,
Stefano
Michael Adler Oct. 7, 2021, 6:39 a.m. UTC | #3 
Hi Stefano,

> I merged, but this breaks build, see:

this is exactly the error which my commit fixes :) In fact, the reason why this particular pipeline has failed is simple:
my commit is *not* coverity_scan branch but only on master - and the pipeline for master was successful.

Kind regards,
Michael
Stefano Babic Oct. 7, 2021, 7:15 a.m. UTC | #4 
Hi Michael,

On 07.10.21 08:39, Michael Adler wrote:
> Hi Stefano,
> 
>> I merged, but this breaks build, see:
> 
> this is exactly the error which my commit fixes :) In fact, the reason why this particular pipeline has failed is simple:
> my commit is *not* coverity_scan branch but only on master - and the pipeline for master was successful.
> 

My mistake. I forgot to rebase, sorry for noise.

Best regards,
Stefano
diff mbox series

Patch

diff --git a/ci/setup.sh b/ci/setup.sh
index af522d0..559cbf7 100755
--- a/ci/setup.sh
+++ b/ci/setup.sh
@@ -52,6 +52,7 @@  $_SUDO apt-get install -y \
     libwebsockets-dev \
     libgpiod-dev \
     libcurl4-openssl-dev \
+    libpci-dev \
     gawk \
     cpio \
     wget