| Message ID | 20210830192140.27000-1-o.mandel@menlosystems.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [meta-swupdate] swupdate-image: rm image-artifact-names in releases | expand |
Hi Olaf, On 30.08.21 21:21, Olaf Mandel wrote: > The swupdate-image class in the dunfell and hardknott branches inherited > an image-artifact-names class from oe-core/meta master, which does *not* > exist in the oe-core branches for dunfell / hardknott. Are you sure ? It was introduced after dunfell was release, and it is present in gatesgarth and hardknott. Why should this applied to hardknott ? > As the inherit is > not even needed, remove it. > > Note: this does not change master, only dunfell / hardknott. > > Signed-off-by: Olaf Mandel <o.mandel@menlosystems.com> > --- > classes/swupdate-image.bbclass | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/classes/swupdate-image.bbclass b/classes/swupdate-image.bbclass > index 54d121f..618b438 100644 > --- a/classes/swupdate-image.bbclass > +++ b/classes/swupdate-image.bbclass > @@ -9,7 +9,6 @@ > # swupdate. > > inherit swupdate-common.bbclass > -inherit image-artifact-names > > S = "${WORKDIR}/${PN}" > > Regards, Stefano
Hello Stefano, Am 30.08.2021 um 23:24 schrieb Stefano Babic: > On 30.08.21 21:21, Olaf Mandel wrote: >> The swupdate-image class in the dunfell and hardknott branches inherited >> an image-artifact-names class from oe-core/meta master, which does *not* >> exist in the oe-core branches for dunfell / hardknott. > > Are you sure ? It was introduced after dunfell was release, and it is > present in gatesgarth and hardknott. Why should this applied to hardknott ? > my mistake: I checked the files existence with "git checkout hardknott -- meta/classes/image-artifact-names.bbclass" while I should have been saying "git checkout origin/hardknott -- ...". Will post a corrected patch. Best regards, Olaf
diff --git a/classes/swupdate-image.bbclass b/classes/swupdate-image.bbclass index 54d121f..618b438 100644 --- a/classes/swupdate-image.bbclass +++ b/classes/swupdate-image.bbclass @@ -9,7 +9,6 @@ # swupdate. inherit swupdate-common.bbclass -inherit image-artifact-names S = "${WORKDIR}/${PN}"
The swupdate-image class in the dunfell and hardknott branches inherited an image-artifact-names class from oe-core/meta master, which does *not* exist in the oe-core branches for dunfell / hardknott. As the inherit is not even needed, remove it. Note: this does not change master, only dunfell / hardknott. Signed-off-by: Olaf Mandel <o.mandel@menlosystems.com> --- classes/swupdate-image.bbclass | 1 - 1 file changed, 1 deletion(-)