From patchwork Mon Jul 5 11:53:16 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefano Babic X-Patchwork-Id: 1500698 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=googlegroups.com (client-ip=2a00:1450:4864:20::43f; helo=mail-wr1-x43f.google.com; envelope-from=swupdate+bncbd2zdgn6sekrbnhfrodqmgqereoqima@googlegroups.com; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.a=rsa-sha256 header.s=20161025 header.b=AOaZu3qt; dkim-atps=neutral Received: from mail-wr1-x43f.google.com (mail-wr1-x43f.google.com [IPv6:2a00:1450:4864:20::43f]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4GJPGP46r8z9sXN for ; Mon, 5 Jul 2021 21:53:32 +1000 (AEST) Received: by mail-wr1-x43f.google.com with SMTP id x8-20020a5d54c80000b029012583535285sf6117159wrv.8 for ; Mon, 05 Jul 2021 04:53:32 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1625486005; cv=pass; d=google.com; s=arc-20160816; b=FjXL5+7aUp8yG+g6DTjPzMC1sQ2ZEhA/rHfkEUpjV7Pkga4TMv+vhy/qo8qEf5B8mh mXUF4OT/GzaxBzBcDhMarcq8PLW5oJuFb8SOVUWsSW85GiDLlXCoN1CHczHHIu4ZpIy4 xLbRJ3p+q8fRhqxP7BamolQCqD5GVPUaM5tJeSCnWU/Uj4BxpZft0VeDUzTxz5kv/f76 TSOHIJjbIjmGNepG/DVLwGlkoPD33nnuQpI8en6WW9B7er8eEPX+pdk6MXWDncjvw98I UykNX3NsKKd6AHRh07ANZnLNP6/iqctIfGoILuYdrs4TuRnkcWTh9fF75Zfy5S6Nf7LY p/MA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:message-id:date :subject:cc:to:from:sender:dkim-signature; bh=STHPLluvw/ng3bAWOwuc3auFh//GaxQBvqKe3eNCjU0=; b=pS3DALcnMH95DsNI4IUu2llFCVPn4XnNmIe9gUejxt2cyOJ4zmZpkhm8Ytom3az0OW ZtUX8BFZYFuTMdO2CoPWMf2I+UGsZ291vMwQl4JjuCGOnBelFq+3UwOpUsflR5wG2bxc DIQVxmPcbBVsOsHdQfzc1DYYtxFegEGAgBegcmWJuc/8Gft9G/5wIPk2YztWmQgNZ1as zCgzkWaRiAlBhErrhWdsghxVqtRtqgSmB9nM/jpr6aCy6i7BD9fxFNr/SyqlfH4MGhFj Ab7t3oNSCPylvb6U1dP9k/RlvR0veKvgE+PtIFa+xqt9rE17wDW5ApvPJij5rLNLc8QW vOSg== ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted nor denied by best guess record for domain of stefano.babic@babic.homelinux.org) smtp.mailfrom=stefano.babic@babic.homelinux.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :x-original-sender:x-original-authentication-results:precedence :mailing-list:list-id:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=STHPLluvw/ng3bAWOwuc3auFh//GaxQBvqKe3eNCjU0=; b=AOaZu3qt7FtsCSYjLUZ5xKT3ypbvnqlIFAtPp1iPOmvnWC2kDI++E3S9wLeCAVIg74 GWFE43ejjZqkncMT0yBnC134aVRfxPeLgsUSSoayGjjNOe40+OVfMiaK8rcxqpLFheIH Wfj/5W6MQWFrjqEN0IEEqZSREjt4qfd2C6KgFKeeqP3K3VTOrJDiCUu2MZbBHSk4aYn6 dMJ9+hmJzoyrZSy9Pcv3CqYrM+rH1FZbJmEpP8FDsKZKLQI1uruIjGDey2jjpxNyPzS3 X6Ho0jhKsi3Zt8sif4cSoT7XfrW1QEuP353NKFFmPWex7gdNuvp+uGylurVqjIoiM/vu Lk6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=sender:x-gm-message-state:from:to:cc:subject:date:message-id :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:x-spam-checked-in-group:list-post :list-help:list-archive:list-subscribe:list-unsubscribe; bh=STHPLluvw/ng3bAWOwuc3auFh//GaxQBvqKe3eNCjU0=; b=lHUGbquMF1JxCBCJVl/nrk0ZySzJ1r1d6N1wocZJG7/g/EDwXwcuJ6JEsRDwo83Zmh P1z1UsnCb4XWmTifDLpdnydBp868oteonSHcF6z+3MEHI2PsotwfB5UovYpmVPhsjgFc X+5AQ75KVySZphI7HrNFxw6GMvumJH9vLrtwNAICsVsOhz2aMhLl/c9E2jYMnv1V9grk gUDSFhPWlM3E5zMdOPaHUiY3nJjmbLjskiQyQaZi5zelVRgdwm9m+5RV+l2OqHGCPwpK 1zjn83A7l9H1Wzwjij8UDFskLW0FGPsCGpqvCMEcAbGnQoN452ZzjLZpV7l8HaUgZRWu ib1Q== Sender: swupdate@googlegroups.com X-Gm-Message-State: AOAM533zh1bB1FsZmuDpUppybw1d21McOwd6m6FzGwKa/KnBO2hnZQ8V sfW69240vyXV+e13IO2O/sY= X-Google-Smtp-Source: ABdhPJwz622aPcmoLURv265sGwqw/5nNhOdj8Ylfw+M42etnVYl/MMpF6TGuOh587hTk5MoQumkWRQ== X-Received: by 2002:a05:600c:358d:: with SMTP id p13mr3338756wmq.12.1625486004814; Mon, 05 Jul 2021 04:53:24 -0700 (PDT) X-BeenThere: swupdate@googlegroups.com Received: by 2002:a7b:cb9a:: with SMTP id m26ls9324422wmi.3.canary-gmail; Mon, 05 Jul 2021 04:53:24 -0700 (PDT) X-Received: by 2002:a7b:c18d:: with SMTP id y13mr12329526wmi.88.1625486004081; Mon, 05 Jul 2021 04:53:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625486004; cv=none; d=google.com; s=arc-20160816; b=QUcT4JnB3nkRaFyVL6t7rlfL9MGEx88gQIpvcyG2xbf5G1tU1SxHMxx6RaY3lCl9Ju TjXYC3cb/H6KD3M7uySath89y1nxFkzSoRg4WGLuYP3OOjO6zH9W0FFHQGR2FNO918z8 WN1n0rzwobC9FC6e9QQRC8+IKYo+M0nA2caZcKZdmZI5piUO9qBVGYQzUPzYeexZihE7 Rufm3kGYM1AjHjl3pM50hspSFJkaWJbr9l7GP6xIBIgu5rcipJV5GUoDr0Eonu+u3A+S aePmnGEJSREzIRkCFeoXtG+/RpEsJyRQ9Av/s1W+wy9zcRKlTxuhxyzYSRuZwPbcISmZ G02g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from; bh=5Q9iax3J8vy/a6wognPtLIJLWF89f3kkvJxL3QqTmJQ=; b=fM87m68gsnAGASaQW1wu0wlyP3ax7qBrB00JE9EZ4i3s3BVBK4iJPmxwmbq84RqqxN 5wA2f8QHgwGxUjuPUtkSVIO/tiFz6pifsgWgSMYadxBbWxdG8cZqv8PtpGyjdEiTkXud OtgIvNfezSk626+b1LJ0EmNaL0FqrNT3oAmBCFjgvRRjIXZyyRoDm9D9s/J4UsNXidsT elN8jeoZ816kkaUGWz3L4e9hhf4+mW6CM3jloAhUa347tf+B+wLLx7HwytrsUVKYwuCn fzUPjBES1rDvx4KXHmP6Q4a/7QRplxmncKUHFYcgFXHIthsbxEoDUOFwa63vV486T0Qn tBGQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted nor denied by best guess record for domain of stefano.babic@babic.homelinux.org) smtp.mailfrom=stefano.babic@babic.homelinux.org Received: from mail-out.m-online.net (mail-out.m-online.net. [2001:a60:0:28:0:1:25:1]) by gmr-mx.google.com with ESMTPS id 192si678660wma.3.2021.07.05.04.53.24 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Jul 2021 04:53:24 -0700 (PDT) Received-SPF: neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted nor denied by best guess record for domain of stefano.babic@babic.homelinux.org) client-ip=2001:a60:0:28:0:1:25:1; Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4GJPGC68Sxz1s1WP; Mon, 5 Jul 2021 13:53:23 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4GJPGC5NFHz1qr3g; Mon, 5 Jul 2021 13:53:23 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id 97ZI2pdR63Nk; Mon, 5 Jul 2021 13:53:23 +0200 (CEST) Received: from babic.homelinux.org (host-88-217-136-221.customer.m-online.net [88.217.136.221]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS; Mon, 5 Jul 2021 13:53:23 +0200 (CEST) Received: from localhost (mail.babic.homelinux.org [127.0.0.1]) by babic.homelinux.org (Postfix) with ESMTP id 32CCA45414C5; Mon, 5 Jul 2021 13:53:22 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at babic.homelinux.org Received: from babic.homelinux.org ([IPv6:::1]) by localhost (mail.babic.homelinux.org [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id mqo8niStzysU; Mon, 5 Jul 2021 13:53:18 +0200 (CEST) Received: from paperino.fritz.box (paperino.fritz.box [192.168.178.48]) by babic.homelinux.org (Postfix) with ESMTP id B1A90454074F; Mon, 5 Jul 2021 13:53:18 +0200 (CEST) From: stefano.babic@babic.homelinux.org To: swupdate@googlegroups.com Cc: Stefano Babic Subject: [swupdate] [PATCH 1/2] Fix coverity #292113 Date: Mon, 5 Jul 2021 13:53:16 +0200 Message-Id: <20210705115317.127426-1-stefano.babic@babic.homelinux.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Original-Sender: stefano.babic@babic.homelinux.org X-Original-Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted nor denied by best guess record for domain of stefano.babic@babic.homelinux.org) smtp.mailfrom=stefano.babic@babic.homelinux.org Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , From: Stefano Babic Signed-off-by: Stefano Babic --- core/stream_interface.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/core/stream_interface.c b/core/stream_interface.c index e87fc71..efa9cbd 100644 --- a/core/stream_interface.c +++ b/core/stream_interface.c @@ -570,6 +570,10 @@ void *network_initializer(void *data) if (!(inst.fd < 0)) close(inst.fd); inst.fd = open(software->output, O_RDONLY, S_IRUSR); + if (inst.fd < 0) { + ERROR("%s cannot be opened", software->output); + ret = -ENODEV; + } } if (!ret) {