diff mbox series

[RFC,3/3] main: Remove duplicated code about '=' in variable name.

Message ID 20210630144632.41130-4-francis.laniel@amarulasolutions.com
State Changes Requested
Headers show
Series [RFC,1/3] main: Check libuboot_set_env() result. | expand

Commit Message

Francis Laniel June 30, 2021, 2:46 p.m. UTC 
libuboot_set_env() already tests if '=' is in variable name and returns -EINVAL
in this case.

Signed-off-by: Francis Laniel <francis.laniel@amarulasolutions.com>
---
 src/fw_printenv.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

Stefano Babic July 1, 2021, 10:03 a.m. UTC | #1 
On 30.06.21 16:46, Francis Laniel wrote:
> libuboot_set_env() already tests if '=' is in variable name and returns -EINVAL
> in this case.
> 
> Signed-off-by: Francis Laniel <francis.laniel@amarulasolutions.com>
> ---
>   src/fw_printenv.c | 5 -----
>   1 file changed, 5 deletions(-)
> 
> diff --git a/src/fw_printenv.c b/src/fw_printenv.c
> index 5d82d2f..f476538 100644
> --- a/src/fw_printenv.c
> +++ b/src/fw_printenv.c
> @@ -159,11 +159,6 @@ int main (int argc, char **argv) {
>   			need_store = true;
>   		} else {
>   			for (i = 0; i < argc; i += 2) {
> -				if (strchr(argv[i], '=')) {
> -					fprintf(stderr, "Error: illegal character '=' in variable name \"%s\"\n", argv[i]);
> -					exit(1);
> -				}
> -
>   				value = libuboot_get_env(ctx, argv[i]);
>   				if (i + 1 == argc) {
>   					if (value != NULL) {
> 


Acked-by: Stefano Babic <sbabic@denx.de>

Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/src/fw_printenv.c b/src/fw_printenv.c
index 5d82d2f..f476538 100644
--- a/src/fw_printenv.c
+++ b/src/fw_printenv.c
@@ -159,11 +159,6 @@  int main (int argc, char **argv) {
 			need_store = true;
 		} else {
 			for (i = 0; i < argc; i += 2) {
-				if (strchr(argv[i], '=')) {
-					fprintf(stderr, "Error: illegal character '=' in variable name \"%s\"\n", argv[i]);
-					exit(1);
-				}
-
 				value = libuboot_get_env(ctx, argv[i]);
 				if (i + 1 == argc) {
 					if (value != NULL) {