| Message ID | 20210405110920.115275-1-sbabic@denx.de |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [meta-swupdate] swupdate: bump to revision fa7f5a1 | expand |
Hi Stefano, On Mon, Apr 5, 2021 at 1:09 PM Stefano Babic <sbabic@denx.de> wrote: > > This adjust checksum for licenses because the licenses directory is > renamed to LICENSES as specified by REUSE 3.0. > > This includes the following changes > > fa7f5a1 bsdqueue: Make REUSE compliant > e870ac9 mongoose: Make REUSE compliant > 4ef88a9 LICENSES: Rename LGPL-2.1 to match SPDX ĺist 3.0 > af2cc98 LICENSES: Remove GPL-2.0, add GPL-2.0-only text > 2f513d1 LICENSES: Rename Exception to obey SPDX naming > 141380f doc: Add BSD 1-Clause to license list > c1bad02 Rename Licenses to LICENSES for REUSE compliance > 77863d7 Fix SPDX inside the project > 550ac19 README: drop erroneous statement about license > 5c048cf (github/coverity_scan) core/stream_interface: add free space checks before writing file copies > 06e19d3 utils: fix get_output_size segfault if properties not set > 1474ac1 utils: move get_output_size from ubivol handler > 43952cc all_handlers_defconfig: add FAT formatter > 79b42c0 doc: handlers: add filesystem creation with diskpart handler description > fb50fad handlers: diskpart: add filesystem creation support > 498fd2a fatfs: add wrapper for FatFs > e419b06 Licenses: add BSD 1 clause license text > c35590c fatfs: add FatFs library R0.14a by ChaN > 0404ce4 utils: add read_lines_notify helper > 3db1d94 grubenv: fix buffer overflow on strtok function > > Signed-off-by: Stefano Babic <sbabic@denx.de> > --- > recipes-support/swupdate/swupdate_git.bb | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/recipes-support/swupdate/swupdate_git.bb b/recipes-support/swupdate/swupdate_git.bb > index 836ba2b..123dc43 100644 > --- a/recipes-support/swupdate/swupdate_git.bb > +++ b/recipes-support/swupdate/swupdate_git.bb > @@ -2,5 +2,10 @@ require swupdate.inc > > DEFAULT_PREFERENCE = "-1" > > -SRCREV ?= "9b2155e3ef526cf0735483b2887c16eb97037a79" > +SRCREV ?= "fa7f5a19cab6e475ce4f51c02f74bd5be55cb5ba" > PV = "2020.11+git${SRCPV}" > + > +LIC_FILES_CHKSUM = "file://LICENSES/GPL-2.0-only.txt;md5=4ee23c52855c222cba72583d301d2338 \ > + file://LICENSES/LGPL-2.1-or-later.txt;md5=4fbd65380cdd255951079008b364516c \ > + file://LICENSES/MIT.txt;md5=838c366f69b72c5df05c96dff79b35f2 \ > + file://LICENSES/LicenseRef-OpenSSL-Exception.txt;md5=5f205fe7a7f2b056b4fa42603fe2d63a" Why are BSD-?-Clause.txt and ISC.txt are not part of the list? Definitely BSD2-Clause.txt and and BSD-3-Clause.txt should be listed here. These licenses explicitly require redistribution of the license text together with the binary. In practice this is achieved by shipping the build/tmp/deploy/licenses directory of the YP build. From a YP perspective all license files should be listed so the build system can make sure that the text is still as the recipe author thought it was. Cheers, Mark
Hi Mark, On 05.04.21 20:00, Mark Jonas wrote: > Hi Stefano, > > On Mon, Apr 5, 2021 at 1:09 PM Stefano Babic <sbabic@denx.de> wrote: >> >> This adjust checksum for licenses because the licenses directory is >> renamed to LICENSES as specified by REUSE 3.0. >> >> This includes the following changes >> >> fa7f5a1 bsdqueue: Make REUSE compliant >> e870ac9 mongoose: Make REUSE compliant >> 4ef88a9 LICENSES: Rename LGPL-2.1 to match SPDX ĺist 3.0 >> af2cc98 LICENSES: Remove GPL-2.0, add GPL-2.0-only text >> 2f513d1 LICENSES: Rename Exception to obey SPDX naming >> 141380f doc: Add BSD 1-Clause to license list >> c1bad02 Rename Licenses to LICENSES for REUSE compliance >> 77863d7 Fix SPDX inside the project >> 550ac19 README: drop erroneous statement about license >> 5c048cf (github/coverity_scan) core/stream_interface: add free space checks before writing file copies >> 06e19d3 utils: fix get_output_size segfault if properties not set >> 1474ac1 utils: move get_output_size from ubivol handler >> 43952cc all_handlers_defconfig: add FAT formatter >> 79b42c0 doc: handlers: add filesystem creation with diskpart handler description >> fb50fad handlers: diskpart: add filesystem creation support >> 498fd2a fatfs: add wrapper for FatFs >> e419b06 Licenses: add BSD 1 clause license text >> c35590c fatfs: add FatFs library R0.14a by ChaN >> 0404ce4 utils: add read_lines_notify helper >> 3db1d94 grubenv: fix buffer overflow on strtok function >> >> Signed-off-by: Stefano Babic <sbabic@denx.de> >> --- >> recipes-support/swupdate/swupdate_git.bb | 7 ++++++- >> 1 file changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/recipes-support/swupdate/swupdate_git.bb b/recipes-support/swupdate/swupdate_git.bb >> index 836ba2b..123dc43 100644 >> --- a/recipes-support/swupdate/swupdate_git.bb >> +++ b/recipes-support/swupdate/swupdate_git.bb >> @@ -2,5 +2,10 @@ require swupdate.inc >> >> DEFAULT_PREFERENCE = "-1" >> >> -SRCREV ?= "9b2155e3ef526cf0735483b2887c16eb97037a79" >> +SRCREV ?= "fa7f5a19cab6e475ce4f51c02f74bd5be55cb5ba" >> PV = "2020.11+git${SRCPV}" >> + >> +LIC_FILES_CHKSUM = "file://LICENSES/GPL-2.0-only.txt;md5=4ee23c52855c222cba72583d301d2338 \ >> + file://LICENSES/LGPL-2.1-or-later.txt;md5=4fbd65380cdd255951079008b364516c \ >> + file://LICENSES/MIT.txt;md5=838c366f69b72c5df05c96dff79b35f2 \ >> + file://LICENSES/LicenseRef-OpenSSL-Exception.txt;md5=5f205fe7a7f2b056b4fa42603fe2d63a" > > Why are BSD-?-Clause.txt and ISC.txt are not part of the list? > They were never part of the list. > Definitely BSD2-Clause.txt and and BSD-3-Clause.txt should be listed > here. These licenses explicitly require redistribution of the license > text together with the binary. This is a very good point. I fix this in V2. > In practice this is achieved by > shipping the build/tmp/deploy/licenses directory of the YP build. > > From a YP perspective all license files should be listed so the build > system can make sure that the text is still as the recipe author > thought it was. > Best regards, Stefano Babic
diff --git a/recipes-support/swupdate/swupdate_git.bb b/recipes-support/swupdate/swupdate_git.bb index 836ba2b..123dc43 100644 --- a/recipes-support/swupdate/swupdate_git.bb +++ b/recipes-support/swupdate/swupdate_git.bb @@ -2,5 +2,10 @@ require swupdate.inc DEFAULT_PREFERENCE = "-1" -SRCREV ?= "9b2155e3ef526cf0735483b2887c16eb97037a79" +SRCREV ?= "fa7f5a19cab6e475ce4f51c02f74bd5be55cb5ba" PV = "2020.11+git${SRCPV}" + +LIC_FILES_CHKSUM = "file://LICENSES/GPL-2.0-only.txt;md5=4ee23c52855c222cba72583d301d2338 \ + file://LICENSES/LGPL-2.1-or-later.txt;md5=4fbd65380cdd255951079008b364516c \ + file://LICENSES/MIT.txt;md5=838c366f69b72c5df05c96dff79b35f2 \ + file://LICENSES/LicenseRef-OpenSSL-Exception.txt;md5=5f205fe7a7f2b056b4fa42603fe2d63a"
This adjust checksum for licenses because the licenses directory is renamed to LICENSES as specified by REUSE 3.0. This includes the following changes fa7f5a1 bsdqueue: Make REUSE compliant e870ac9 mongoose: Make REUSE compliant 4ef88a9 LICENSES: Rename LGPL-2.1 to match SPDX ĺist 3.0 af2cc98 LICENSES: Remove GPL-2.0, add GPL-2.0-only text 2f513d1 LICENSES: Rename Exception to obey SPDX naming 141380f doc: Add BSD 1-Clause to license list c1bad02 Rename Licenses to LICENSES for REUSE compliance 77863d7 Fix SPDX inside the project 550ac19 README: drop erroneous statement about license 5c048cf (github/coverity_scan) core/stream_interface: add free space checks before writing file copies 06e19d3 utils: fix get_output_size segfault if properties not set 1474ac1 utils: move get_output_size from ubivol handler 43952cc all_handlers_defconfig: add FAT formatter 79b42c0 doc: handlers: add filesystem creation with diskpart handler description fb50fad handlers: diskpart: add filesystem creation support 498fd2a fatfs: add wrapper for FatFs e419b06 Licenses: add BSD 1 clause license text c35590c fatfs: add FatFs library R0.14a by ChaN 0404ce4 utils: add read_lines_notify helper 3db1d94 grubenv: fix buffer overflow on strtok function Signed-off-by: Stefano Babic <sbabic@denx.de> --- recipes-support/swupdate/swupdate_git.bb | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)