diff mbox series

[meta-swupdate] swupdate: Depend on util-linux if CONFIG_DISKPART is set

Message ID 20201111014451.2878554-1-raj.khem@gmail.com
State Accepted
Headers show
Series [meta-swupdate] swupdate: Depend on util-linux if CONFIG_DISKPART is set | expand

Commit Message

Khem Raj Nov. 11, 2020, 1:44 a.m. UTC
it depends on libfdisk/libfdisk.h for disk parition management
which is provided by util-linux

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 recipes-support/swupdate/swupdate.inc | 3 +++
 1 file changed, 3 insertions(+)

Comments

Stefano Babic Nov. 11, 2020, 8:17 a.m. UTC | #1
Hi Khem,

On 11.11.20 02:44, Khem Raj wrote:
> it depends on libfdisk/libfdisk.h for disk parition management
> which is provided by util-linux
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  recipes-support/swupdate/swupdate.inc | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/recipes-support/swupdate/swupdate.inc b/recipes-support/swupdate/swupdate.inc
> index 51befed..7146e98 100644
> --- a/recipes-support/swupdate/swupdate.inc
> +++ b/recipes-support/swupdate/swupdate.inc
> @@ -169,6 +169,9 @@ python () {
>      if 'CONFIG_ZSTD=y\n' in features:
>          depends += ' zstd'
>  
> +    if 'CONFIG_DISKPART=y\n' in features:
> +        depends += ' util-linux'
> +
>      d.setVar('DEPENDS', depends)
>  
>      if 'CONFIG_MONGOOSE=y\n' in features:
> 

Reviewed-by: Stefano Babic <sbabic@denx.de>

Best regards,
Stefano Babic
Stefano Babic Nov. 16, 2020, 3:01 p.m. UTC | #2
On 11.11.20 09:17, Stefano Babic wrote:
> Hi Khem,
> 
> On 11.11.20 02:44, Khem Raj wrote:
>> it depends on libfdisk/libfdisk.h for disk parition management
>> which is provided by util-linux
>>
>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> ---
>>  recipes-support/swupdate/swupdate.inc | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/recipes-support/swupdate/swupdate.inc b/recipes-support/swupdate/swupdate.inc
>> index 51befed..7146e98 100644
>> --- a/recipes-support/swupdate/swupdate.inc
>> +++ b/recipes-support/swupdate/swupdate.inc
>> @@ -169,6 +169,9 @@ python () {
>>      if 'CONFIG_ZSTD=y\n' in features:
>>          depends += ' zstd'
>>  
>> +    if 'CONFIG_DISKPART=y\n' in features:
>> +        depends += ' util-linux'
>> +
>>      d.setVar('DEPENDS', depends)
>>  
>>      if 'CONFIG_MONGOOSE=y\n' in features:
>>
> 
> Reviewed-by: Stefano Babic <sbabic@denx.de>

Applied to -master and -gatesworth, thanks !

Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/recipes-support/swupdate/swupdate.inc b/recipes-support/swupdate/swupdate.inc
index 51befed..7146e98 100644
--- a/recipes-support/swupdate/swupdate.inc
+++ b/recipes-support/swupdate/swupdate.inc
@@ -169,6 +169,9 @@  python () {
     if 'CONFIG_ZSTD=y\n' in features:
         depends += ' zstd'
 
+    if 'CONFIG_DISKPART=y\n' in features:
+        depends += ' util-linux'
+
     d.setVar('DEPENDS', depends)
 
     if 'CONFIG_MONGOOSE=y\n' in features: