| Message ID | 20201110053152.64411-1-raj.khem@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [meta-swupdate] swupdate: Disable partition algorith when LTO is enabled | expand |
Hi Khem, On 10.11.20 06:31, Khem Raj wrote: > -flto-partition=none is needed when building with -flto Something new to me. I have not found in OE where LTOEXTRA is used at all, so I am quite puzzled. Do you have some extra info I can check ? Is -flto set automatically by new gcc ? And where is used LTOEXTRA ? > Use += to add libconfig to depends, so it does not overwrite the > programmatically added dependencies Sure, this is a bug, thanks for fixing it ! Regards, Stefano > > Signed-off-by: Khem Raj <raj.khem@gmail.com> > --- > recipes-support/swupdate/swupdate.inc | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/recipes-support/swupdate/swupdate.inc b/recipes-support/swupdate/swupdate.inc > index eb682aa..51befed 100644 > --- a/recipes-support/swupdate/swupdate.inc > +++ b/recipes-support/swupdate/swupdate.inc > @@ -1,7 +1,7 @@ > SUMMARY="Image updater for Yocto projects" > DESCRIPTION = "Application for automatic software update from USB Pen" > SECTION="swupdate" > -DEPENDS = "libconfig" > +DEPENDS += "libconfig" > > # SWUpdate licensing is described in the following pages: > # https://sbabic.github.io/swupdate/licensing.html > @@ -30,6 +30,8 @@ SRC_URI = "git://github.com/sbabic/swupdate.git;protocol=https \ > file://90-start-progress \ > " > > +LTOEXTRA += "-flto-partition=none" > + > PACKAGES =+ " \ > ${PN}-client \ > ${PN}-lua \ >
On Tue, Nov 10, 2020 at 3:39 AM Stefano Babic <sbabic@denx.de> wrote: > Hi Khem, > > On 10.11.20 06:31, Khem Raj wrote: > > -flto-partition=none is needed when building with -flto > > Something new to me. I have not found in OE where LTOEXTRA is used at > all, so I am quite puzzled. Do you have some extra info I can check ? Is > -flto set automatically by new gcc ? And where is used LTOEXTRA ? The patches to introduce LTOEXTRA are in master-next in Oe-core as of now so it will be soon in master > > > > Use += to add libconfig to depends, so it does not overwrite the > > programmatically added dependencies > > Sure, this is a bug, thanks for fixing it ! > > Regards, > Stefano > > > > > Signed-off-by: Khem Raj <raj.khem@gmail.com> > > --- > > recipes-support/swupdate/swupdate.inc | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/recipes-support/swupdate/swupdate.inc > b/recipes-support/swupdate/swupdate.inc > > index eb682aa..51befed 100644 > > --- a/recipes-support/swupdate/swupdate.inc > > +++ b/recipes-support/swupdate/swupdate.inc > > @@ -1,7 +1,7 @@ > > SUMMARY="Image updater for Yocto projects" > > DESCRIPTION = "Application for automatic software update from USB Pen" > > SECTION="swupdate" > > -DEPENDS = "libconfig" > > +DEPENDS += "libconfig" > > > > # SWUpdate licensing is described in the following pages: > > # https://sbabic.github.io/swupdate/licensing.html > > @@ -30,6 +30,8 @@ SRC_URI = "git:// > github.com/sbabic/swupdate.git;protocol=https \ > > file://90-start-progress \ > > " > > > > +LTOEXTRA += "-flto-partition=none" > > + > > PACKAGES =+ " \ > > ${PN}-client \ > > ${PN}-lua \ > > > > > -- > ===================================================================== > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de > ===================================================================== >
On 10.11.20 06:31, Khem Raj wrote: > -flto-partition=none is needed when building with -flto > Use += to add libconfig to depends, so it does not overwrite the > programmatically added dependencies > > Signed-off-by: Khem Raj <raj.khem@gmail.com> > --- > recipes-support/swupdate/swupdate.inc | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/recipes-support/swupdate/swupdate.inc b/recipes-support/swupdate/swupdate.inc > index eb682aa..51befed 100644 > --- a/recipes-support/swupdate/swupdate.inc > +++ b/recipes-support/swupdate/swupdate.inc > @@ -1,7 +1,7 @@ > SUMMARY="Image updater for Yocto projects" > DESCRIPTION = "Application for automatic software update from USB Pen" > SECTION="swupdate" > -DEPENDS = "libconfig" > +DEPENDS += "libconfig" > > # SWUpdate licensing is described in the following pages: > # https://sbabic.github.io/swupdate/licensing.html > @@ -30,6 +30,8 @@ SRC_URI = "git://github.com/sbabic/swupdate.git;protocol=https \ > file://90-start-progress \ > " > > +LTOEXTRA += "-flto-partition=none" > + > PACKAGES =+ " \ > ${PN}-client \ > ${PN}-lua \ > Applied to -master and -gatesworth, thanks ! Best regards, Stefano Babic
diff --git a/recipes-support/swupdate/swupdate.inc b/recipes-support/swupdate/swupdate.inc index eb682aa..51befed 100644 --- a/recipes-support/swupdate/swupdate.inc +++ b/recipes-support/swupdate/swupdate.inc @@ -1,7 +1,7 @@ SUMMARY="Image updater for Yocto projects" DESCRIPTION = "Application for automatic software update from USB Pen" SECTION="swupdate" -DEPENDS = "libconfig" +DEPENDS += "libconfig" # SWUpdate licensing is described in the following pages: # https://sbabic.github.io/swupdate/licensing.html @@ -30,6 +30,8 @@ SRC_URI = "git://github.com/sbabic/swupdate.git;protocol=https \ file://90-start-progress \ " +LTOEXTRA += "-flto-partition=none" + PACKAGES =+ " \ ${PN}-client \ ${PN}-lua \
-flto-partition=none is needed when building with -flto Use += to add libconfig to depends, so it does not overwrite the programmatically added dependencies Signed-off-by: Khem Raj <raj.khem@gmail.com> --- recipes-support/swupdate/swupdate.inc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)