Message ID | 20201026140342.147578-6-sbabic@denx.de |
---|---|
State | Accepted |
Headers | show
Return-Path: <swupdate+bncBCXPLOXJ6IKRBUVO3P6AKGQEOHMMR3A@googlegroups.com> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=googlegroups.com (client-ip=2a00:1450:4864:20::43c; helo=mail-wr1-x43c.google.com; envelope-from=swupdate+bncbcxploxj6ikrbuvo3p6akgqeohmmr3a@googlegroups.com; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.a=rsa-sha256 header.s=20161025 header.b=fpdUPWOf; dkim-atps=neutral Received: from mail-wr1-x43c.google.com (mail-wr1-x43c.google.com [IPv6:2a00:1450:4864:20::43c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4CKc5M281wz9sV0 for <incoming@patchwork.ozlabs.org>; Tue, 27 Oct 2020 01:04:06 +1100 (AEDT) Received: by mail-wr1-x43c.google.com with SMTP id i6sf8464329wrx.11 for <incoming@patchwork.ozlabs.org>; Mon, 26 Oct 2020 07:04:06 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1603721043; cv=pass; d=google.com; s=arc-20160816; b=X+Bxg0cO+0PqmUtz7+sFJ7MiERB7yYrApMhctUyomJxfG3RSYOcLXW+S4c+U9RFAvD kp1+lUl4cyRuEa1HGxyReH2HjDSUaQOk/8NIxkLjQaNBBBn/c4CNG9B8uF8rkAPC+44S iNQVRrvqeD128ZJOdehbrJEiUgDjJP2I9UNZy1nI46VpYL6GDKWBeyq1hb3+4uCYDkId HsAXLHKWokMlkRH/pISTwaL5coTmfJ/rzowMV8RYVkM0pyPCFSXjf572GYAbN9iDC61G 6MPpWLLhQAa/rZ0A2zq7a/7DHac9C9NgD5OythAfStkSh2/CVh12/9ul5boteRdQd/pN OctQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:dkim-signature; bh=Rui45a3oGTTrjG/LiIfC7TkvHYmx5FCL9yBjIzfl7/A=; b=ulQYQx4+NsR2hwsaRPE5zgXkoYySEqIZqtwdqYnh/jGwtCKuBQBR9y4yEOLR9WuOxB fW95EVkER3Y2QG5lMD6ylkeqRk/tpHusXQyI2zbwj0gTbjD/Cepx6P7BuCXubf8yHRW2 EZLeBwmSicP9P4i5Atl8SywuJhrMPv5+F+5pprC/rvap3BLhyvXkZ5KpnqOpFTRtFbso tLZU7b2CevwSzvQDCfjeXzJe+W9SWrGxXsXnOJUXx1rDbNaHfh/76xPtRD1aVeRnuT7F OkGtUYhHZ0nDB9+5FLpchHzNn/M+Z2LnFKE3qi5BSVkPeP/RWvogjeWcijdBixkvdhHl hNUA== ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=neutral (google.com: 212.18.0.10 is neither permitted nor denied by best guess record for domain of sbabic@denx.de) smtp.mailfrom=sbabic@denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=Rui45a3oGTTrjG/LiIfC7TkvHYmx5FCL9yBjIzfl7/A=; b=fpdUPWOfPmXME7HExwRr2rwHy/+4C1sa1ko7ozAHcBigvK0AZ+vv9Cy4ey+VIduxpI tqwLTJmw5hbcFQqj96wp3wxL21aegzI86N/68nK55W9twYQ/O/QSK115gSpGDUL95SJh qYv8x12gV7+z3kaXYs5Pyetr3ihvY3rDSYMur1bkNK0fx41UXzHK/b9yPXM6XUuJRo4w sLZ3ENIEH/CsYqJkzyHMe17+wI9tZ3Ten06zRiZkV0mI5sW+CKxiF4h1EaODvsRHxNfa ffPALuvRvJ0qw1hTH8F9g2nnI8adf5cxJbpT+ZnJ9Hj5D97PoaMbdW24Bs5ubU100IY9 lMpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=sender:x-gm-message-state:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-spam-checked-in-group:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=Rui45a3oGTTrjG/LiIfC7TkvHYmx5FCL9yBjIzfl7/A=; b=T1WSnrpEOYJB/IayvbDEWRQTJwIfzm3wvTC6yzrXSPf414sgvRNkl4wsZm6vLcjEJr fTiZ3IjHSqxCmoek8CXg86W9PJk4H1EJehTzsxqH4qAeVqsEZ0XrZMSAtTAB4/4jD9RI FqIOAXbvedyE7IPfRMxBoa90hxURouk6XOz/UlssdV9R0OiDqj2RONZWCodaWd13wxX9 5QoVGf/hxw6EhQmToicfpD6ah83qWdMAt/6Uwqr58cqCWlh5RjtH72AzpGycCIWpqXYp /b0czrjgEs5gqzeohuw8fqUe88GVwjrMyDCxJUG+EgcZiolQhb5/ebeGYQa4gPv7GjiC 97Hg== Sender: swupdate@googlegroups.com X-Gm-Message-State: AOAM530T0T325MQ6/rId7T45dqXRta/zah51DQOS2W/h0ta8GdXBCEra QfyAue9UBuov5Doln4KpsAM= X-Google-Smtp-Source: ABdhPJx2nNRpkiUxCPqAA5v+aBVdw7CuSdVMxA7HXI+pau1+cqgffKXPanAYDZhk+5jk57rqMeZYcg== X-Received: by 2002:a05:6000:1005:: with SMTP id a5mr18923482wrx.360.1603721043331; Mon, 26 Oct 2020 07:04:03 -0700 (PDT) X-BeenThere: swupdate@googlegroups.com Received: by 2002:a5d:4ac3:: with SMTP id y3ls908784wrs.2.gmail; Mon, 26 Oct 2020 07:04:02 -0700 (PDT) X-Received: by 2002:a5d:69ce:: with SMTP id s14mr19356795wrw.39.1603721042296; Mon, 26 Oct 2020 07:04:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603721042; cv=none; d=google.com; s=arc-20160816; b=BRKkGzuukVRAD9jkuJRx4OIolL20sfQyTNyHXv/xR1wcFnZeiYWQzwTWag5zyZdZfm eUEtu/mXBRT3u6SJ1P4dRIHo4IkJfJPUKpwzU9pNtP0kTseGPTf4gInNCd6OZhGnvSRI xNM97cSq4RieHPGnabIjYxemyBavDvrSr5OgAZ2+/3PD5m/L7IHpJabTGQIjKdsT4zyT qdp4bjeDMlRDjvpdnhDbl2MZReYJQ+yAwKZrvXpDKk9IVTrmlWBujpFxPitzKk1evrIh k0iVO8OunjEVJ7bCVHV0KqRzec4C2MDAJ44hyW2vaairlCPwOCdIfca4wJRDO00Fhddb VIqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=YRwIFhqYyq3iNaAy/DecKeWMtt4uYLeiBSAGIfxCbXo=; b=WiVUTC/SP8aX4w7ckXi3I2d9U9CBUBtMRWPZ6RDOdQgNalXZVWFpkZxsBkXW1xV18V UWAEsL3GHgoMc1pfpcBGXLPXr00ACNdCuDE9D92XdH9zweKSwZlpMN35SovxVLDt0IIF xRAuWD7DrseBq8g7PaaKuL5OkxbZQEu4AC203EstKw16f/w5UMtlQvuS/k6XumZGKgHb qeezdgUuGAEoYeiJJr19EnKT6EOJpVNNQmxkRo6yX7kL81PFTQl0pTFHqrZzOtHCIuzs mvstgVwbneaK9RVOnFWMiwFtGT4zlwM+bny3D8JkxkB71rExeKDrBOJ1Q8Rfs6x+AMVz 8zJA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 212.18.0.10 is neither permitted nor denied by best guess record for domain of sbabic@denx.de) smtp.mailfrom=sbabic@denx.de Received: from mail-out.m-online.net (mail-out.m-online.net. [212.18.0.10]) by gmr-mx.google.com with ESMTPS id o16si312412wrv.1.2020.10.26.07.04.02 for <swupdate@googlegroups.com> (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Oct 2020 07:04:02 -0700 (PDT) Received-SPF: neutral (google.com: 212.18.0.10 is neither permitted nor denied by best guess record for domain of sbabic@denx.de) client-ip=212.18.0.10; Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4CKc5G04XNz1rx8f; Mon, 26 Oct 2020 15:04:02 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4CKc5F6qylz1qsXC; Mon, 26 Oct 2020 15:04:01 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id J9gtSYCxqwCk; Mon, 26 Oct 2020 15:04:00 +0100 (CET) Received: from babic.homelinux.org (host-88-217-136-221.customer.m-online.net [88.217.136.221]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS; Mon, 26 Oct 2020 15:04:00 +0100 (CET) Received: from localhost (mail.babic.homelinux.org [127.0.0.1]) by babic.homelinux.org (Postfix) with ESMTP id 295A34540607; Mon, 26 Oct 2020 15:04:00 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at babic.homelinux.org Received: from babic.homelinux.org ([IPv6:::1]) by localhost (mail.babic.homelinux.org [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id YmzxROQIqy7t; Mon, 26 Oct 2020 15:03:57 +0100 (CET) Received: from paperino.fritz.box (paperino.fritz.box [192.168.178.64]) by babic.homelinux.org (Postfix) with ESMTP id 5291E45408BC; Mon, 26 Oct 2020 15:03:45 +0100 (CET) From: Stefano Babic <sbabic@denx.de> To: swupdate@googlegroups.com Cc: Stefano Babic <sbabic@denx.de> Subject: [swupdate] [Patch V2 6/7] hakbit: missing initialization of msg in postupdate Date: Mon, 26 Oct 2020 15:03:41 +0100 Message-Id: <20201026140342.147578-6-sbabic@denx.de> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201026140342.147578-1-sbabic@denx.de> References: <20201026140342.147578-1-sbabic@denx.de> MIME-Version: 1.0 X-Original-Sender: sbabic@denx.de X-Original-Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 212.18.0.10 is neither permitted nor denied by best guess record for domain of sbabic@denx.de) smtp.mailfrom=sbabic@denx.de Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: <swupdate.googlegroups.com> X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: <https://groups.google.com/group/swupdate/post>, <mailto:swupdate@googlegroups.com> List-Help: <https://groups.google.com/support/>, <mailto:swupdate+help@googlegroups.com> List-Archive: <https://groups.google.com/group/swupdate List-Subscribe: <https://groups.google.com/group/swupdate/subscribe>, <mailto:swupdate+subscribe@googlegroups.com> List-Unsubscribe: <mailto:googlegroups-manage+605343134186+unsubscribe@googlegroups.com>, <https://groups.google.com/group/swupdate/subscribe> |
Series |
[V2,1/7] downloader: drop unuseful marker when dwl is started
|
expand
|
diff --git a/suricatta/server_hawkbit.c b/suricatta/server_hawkbit.c index dbe18a0..42e8569 100644 --- a/suricatta/server_hawkbit.c +++ b/suricatta/server_hawkbit.c @@ -1415,6 +1415,7 @@ cleanup: if (result == SERVER_OK) { INFO("Update successful, executing post-update actions."); ipc_message msg; + memset(&msg, 0, sizeof(msg)); if (ipc_postupdate(&msg) != 0) { result = SERVER_EERR; } else {
The postupdate command checks if there is an info message and sent it to the progress interface (with a "DONE" status). The missing initialisation causes garbage on the client because a valid info message (length > 0) is detected. Signed-off-by: Stefano Babic <sbabic@denx.de> --- suricatta/server_hawkbit.c | 1 + 1 file changed, 1 insertion(+)