diff mbox series

[meta-swupdate] Use find_cfgs() helper from cml1.bbclass

Message ID 20201007140853.930658-1-wickbergster@gmail.com
State Accepted
Headers show
Series [meta-swupdate] Use find_cfgs() helper from cml1.bbclass | expand

Commit Message

Alexander Vickberg Oct. 7, 2020, 2:08 p.m. UTC
Since Yocto commit 329665d cml1.bbclass now contains the function
find_cfgs(). This bbclass is already inherited.

Signed-off-by: Alexander Vickberg <wickbergster@gmail.com>
---
 recipes-support/swupdate/swupdate.inc | 4 ----
 1 file changed, 4 deletions(-)

Comments

Stefano Babic Oct. 7, 2020, 2:16 p.m. UTC | #1
On 07.10.20 16:08, Alexander Vickberg wrote:
> Since Yocto commit 329665d cml1.bbclass now contains the function
> find_cfgs(). This bbclass is already inherited.
> 

I see.

> Signed-off-by: Alexander Vickberg <wickbergster@gmail.com>
> ---
>  recipes-support/swupdate/swupdate.inc | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/recipes-support/swupdate/swupdate.inc b/recipes-support/swupdate/swupdate.inc
> index 94da375..b652250 100644
> --- a/recipes-support/swupdate/swupdate.inc
> +++ b/recipes-support/swupdate/swupdate.inc
> @@ -75,10 +75,6 @@ EXTRA_OEMAKE += " O=${B} HOSTCC="${BUILD_CC}" HOSTCXX="${BUILD_CXX}" LD="${CC}"
>  
>  DEPENDS += "kern-tools-native"
>  
> -# returns all the elements from the src uri that are .cfg files
> -def find_cfgs(d):
> -    return [s for s in src_patches(d, True) if s.endswith('.cfg')]
> -
>  python () {
>      import re
>  
> 

Reviewed-by: Stefano Babic <sbabic@denx.de>

Best regards,
Stefano Babic
Stefano Babic Oct. 12, 2020, 1:46 p.m. UTC | #2
On 07.10.20 16:08, Alexander Vickberg wrote:
> Since Yocto commit 329665d cml1.bbclass now contains the function
> find_cfgs(). This bbclass is already inherited.
> 
> Signed-off-by: Alexander Vickberg <wickbergster@gmail.com>
> ---
>  recipes-support/swupdate/swupdate.inc | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/recipes-support/swupdate/swupdate.inc b/recipes-support/swupdate/swupdate.inc
> index 94da375..b652250 100644
> --- a/recipes-support/swupdate/swupdate.inc
> +++ b/recipes-support/swupdate/swupdate.inc
> @@ -75,10 +75,6 @@ EXTRA_OEMAKE += " O=${B} HOSTCC="${BUILD_CC}" HOSTCXX="${BUILD_CXX}" LD="${CC}"
>  
>  DEPENDS += "kern-tools-native"
>  
> -# returns all the elements from the src uri that are .cfg files
> -def find_cfgs(d):
> -    return [s for s in src_patches(d, True) if s.endswith('.cfg')]
> -
>  python () {
>      import re
>  
> 

Applied to -master, thanks !

Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/recipes-support/swupdate/swupdate.inc b/recipes-support/swupdate/swupdate.inc
index 94da375..b652250 100644
--- a/recipes-support/swupdate/swupdate.inc
+++ b/recipes-support/swupdate/swupdate.inc
@@ -75,10 +75,6 @@  EXTRA_OEMAKE += " O=${B} HOSTCC="${BUILD_CC}" HOSTCXX="${BUILD_CXX}" LD="${CC}"
 
 DEPENDS += "kern-tools-native"
 
-# returns all the elements from the src uri that are .cfg files
-def find_cfgs(d):
-    return [s for s in src_patches(d, True) if s.endswith('.cfg')]
-
 python () {
     import re